Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 49675,
    "url": "http://patches.dpdk.org/api/patches/49675/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190111113239.61275-1-harry.van.haaren@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190111113239.61275-1-harry.van.haaren@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190111113239.61275-1-harry.van.haaren@intel.com",
    "date": "2019-01-11T11:32:39",
    "name": "[v3] mbuf: fix compile by making sched struct visible",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "9150b8defb5b3235254e20ad1a92fc9e5a8cbd43",
    "submitter": {
        "id": 317,
        "url": "http://patches.dpdk.org/api/people/317/?format=api",
        "name": "Van Haaren, Harry",
        "email": "harry.van.haaren@intel.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190111113239.61275-1-harry.van.haaren@intel.com/mbox/",
    "series": [
        {
            "id": 3119,
            "url": "http://patches.dpdk.org/api/series/3119/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3119",
            "date": "2019-01-11T11:32:39",
            "name": "[v3] mbuf: fix compile by making sched struct visible",
            "version": 3,
            "mbox": "http://patches.dpdk.org/series/3119/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/49675/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/49675/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 588B51B94A;\n\tFri, 11 Jan 2019 12:32:14 +0100 (CET)",
            "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 761BA1B945\n\tfor <dev@dpdk.org>; Fri, 11 Jan 2019 12:32:12 +0100 (CET)",
            "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t11 Jan 2019 03:32:09 -0800",
            "from silpixa00399779.ir.intel.com (HELO\n\tsilpixa00399779.ger.corp.intel.com) ([10.237.222.118])\n\tby orsmga003.jf.intel.com with ESMTP; 11 Jan 2019 03:32:09 -0800"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.56,465,1539673200\"; d=\"scan'208\";a=\"117317254\"",
        "From": "Harry van Haaren <harry.van.haaren@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "Harry van Haaren <harry.van.haaren@intel.com>, reshma.pattan@intel.com, \n\tcristian.dumitrescu@intel.com, olivier.matz@6wind.com,\n\tthomas@monjalon.net, stephen@networkplumber.org, gavin.hu@arm.com,\n\thonnappa.nagarahalli@arm.com",
        "Date": "Fri, 11 Jan 2019 11:32:39 +0000",
        "Message-Id": "<20190111113239.61275-1-harry.van.haaren@intel.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "In-Reply-To": "<20190110180658.23302-1-harry.van.haaren@intel.com>",
        "References": "<20190110180658.23302-1-harry.van.haaren@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v3] mbuf: fix compile by making sched struct\n\tvisible",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Although C compilation works with the struct rte_mbuf_sched\ndeclared inside the struct rte_mbuf namespace, C++ fails to\ncompile. This fix moves the rte_mbuf_sched struct up to the\nglobal namespace, instead of declaring it inside the struct\nmbuf namespace.\n\nThe struct rte_mbuf_sched is being used on the stack in\nrte_mbuf_sched_get() and as a cast in _set(). For this\nreason, it must be exposed as an available type.\n\nFixes: 5d3f72100904 (\"mbuf: implement generic format for sched field\")\n\nSigned-off-by: Harry van Haaren <harry.van.haaren@intel.com>\n\n---\n\nv3:\n - Update comment in mbuf to state size of struct sched (Crisitian)\n\nv2:\n - Different solution, not applicable, v3 based on v1 (ML discussion)\n\nCc: reshma.pattan@intel.com\nCc: cristian.dumitrescu@intel.com\nCc: olivier.matz@6wind.com\nCc: thomas@monjalon.net\nCc: stephen@networkplumber.org\nCc: gavin.hu@arm.com\nCc: honnappa.nagarahalli@arm.com\n---\n lib/librte_mbuf/rte_mbuf.h | 23 +++++++++++++----------\n 1 file changed, 13 insertions(+), 10 deletions(-)",
    "diff": "diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h\nindex bc562dc8a..d53b68253 100644\n--- a/lib/librte_mbuf/rte_mbuf.h\n+++ b/lib/librte_mbuf/rte_mbuf.h\n@@ -468,6 +468,17 @@ __extension__\n typedef uint64_t MARKER64[0]; /**< marker that allows us to overwrite 8 bytes\n                                * with a single assignment */\n \n+struct rte_mbuf_sched {\n+\tuint32_t queue_id;   /**< Queue ID. */\n+\tuint8_t traffic_class;\n+\t/**< Traffic class ID. Traffic class 0\n+\t * is the highest priority traffic class.\n+\t */\n+\tuint8_t color;\n+\t/**< Color. @see enum rte_color.*/\n+\tuint16_t reserved;   /**< Reserved. */\n+}; /**< Hierarchical scheduler */\n+\n /**\n  * The generic rte_mbuf, containing a packet mbuf.\n  */\n@@ -574,16 +585,8 @@ struct rte_mbuf {\n \t\t\t\t * on PKT_RX_FDIR_* flag in ol_flags.\n \t\t\t\t */\n \t\t\t} fdir;\t/**< Filter identifier if FDIR enabled */\n-\t\t\tstruct rte_mbuf_sched {\n-\t\t\t\tuint32_t queue_id;   /**< Queue ID. */\n-\t\t\t\tuint8_t traffic_class;\n-\t\t\t\t/**< Traffic class ID. Traffic class 0\n-\t\t\t\t * is the highest priority traffic class.\n-\t\t\t\t */\n-\t\t\t\tuint8_t color;\n-\t\t\t\t/**< Color. @see enum rte_color.*/\n-\t\t\t\tuint16_t reserved;   /**< Reserved. */\n-\t\t\t} sched; /**< Hierarchical scheduler */\n+\t\t\tstruct rte_mbuf_sched sched;\n+\t\t\t/**< Hierarchical scheduler : 8 bytes */\n \t\t\tstruct {\n \t\t\t\tuint32_t reserved1;\n \t\t\t\tuint16_t reserved2;\n",
    "prefixes": [
        "v3"
    ]
}