Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/49626/?format=api
{ "id": 49626, "url": "http://patches.dpdk.org/api/patches/49626/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/2dc9211eb382657207032477c3bb58260aa75c16.1547138000.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<2dc9211eb382657207032477c3bb58260aa75c16.1547138000.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/2dc9211eb382657207032477c3bb58260aa75c16.1547138000.git.anatoly.burakov@intel.com", "date": "2019-01-10T16:33:39", "name": "[v2] vfio: don't unregister callback in secondaries", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "1f4dd236bee5c5464ee6227cd9ff93e990e5a93b", "submitter": { "id": 4, "url": "http://patches.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/2dc9211eb382657207032477c3bb58260aa75c16.1547138000.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 3102, "url": "http://patches.dpdk.org/api/series/3102/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3102", "date": "2019-01-10T16:33:39", "name": "[v2] vfio: don't unregister callback in secondaries", "version": 2, "mbox": "http://patches.dpdk.org/series/3102/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/49626/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/49626/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1B0BF1B90D;\n\tThu, 10 Jan 2019 17:33:48 +0100 (CET)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby dpdk.org (Postfix) with ESMTP id 711F51B8F9;\n\tThu, 10 Jan 2019 17:33:46 +0100 (CET)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t10 Jan 2019 08:33:41 -0800", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby orsmga002.jf.intel.com with ESMTP; 10 Jan 2019 08:33:40 -0800", "from sivswdev05.ir.intel.com (sivswdev05.ir.intel.com\n\t[10.243.17.64])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tx0AGXe9E004251; Thu, 10 Jan 2019 16:33:40 GMT", "from sivswdev05.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev05.ir.intel.com with ESMTP id x0AGXeDV020377;\n\tThu, 10 Jan 2019 16:33:40 GMT", "(from aburakov@localhost)\n\tby sivswdev05.ir.intel.com with LOCAL id x0AGXdxB020373;\n\tThu, 10 Jan 2019 16:33:40 GMT" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.56,462,1539673200\"; d=\"scan'208\";a=\"125028379\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "stable@dpdk.org", "Date": "Thu, 10 Jan 2019 16:33:39 +0000", "Message-Id": "<2dc9211eb382657207032477c3bb58260aa75c16.1547138000.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "In-Reply-To": "<a0a70bf6c434c4378e239042dc4f3cbbc19cb879.1547137811.git.anatoly.burakov@intel.com>", "References": "<a0a70bf6c434c4378e239042dc4f3cbbc19cb879.1547137811.git.anatoly.burakov@intel.com>", "Subject": "[dpdk-dev] [PATCH v2] vfio: don't unregister callback in secondaries", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Callbacks are only registered in the primary, so do not attempt to\nunregister callbacks in secondary processes.\n\nFixes: 43e463137154 (\"vfio: support memory event callbacks\")\nCc: stable@dpdk.org\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n\nNotes:\n v2:\n - Skip secondaries instead of primaries\n\n lib/librte_eal/linuxapp/eal/eal_vfio.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/librte_eal/linuxapp/eal/eal_vfio.c b/lib/librte_eal/linuxapp/eal/eal_vfio.c\nindex 0516b1597..72cc65151 100644\n--- a/lib/librte_eal/linuxapp/eal/eal_vfio.c\n+++ b/lib/librte_eal/linuxapp/eal/eal_vfio.c\n@@ -857,7 +857,8 @@ rte_vfio_release_device(const char *sysfs_base, const char *dev_addr,\n \t/* if there are no active device groups, unregister the callback to\n \t * avoid spurious attempts to map/unmap memory from VFIO.\n \t */\n-\tif (vfio_cfg == default_vfio_cfg && vfio_cfg->vfio_active_groups == 0)\n+\tif (vfio_cfg == default_vfio_cfg && vfio_cfg->vfio_active_groups == 0 &&\n+\t\t\trte_eal_process_type() != RTE_PROC_SECONDARY)\n \t\trte_mem_event_callback_unregister(VFIO_MEM_EVENT_CLB_NAME,\n \t\t\t\tNULL);\n \n", "prefixes": [ "v2" ] }