Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/49554/?format=api
{ "id": 49554, "url": "http://patches.dpdk.org/api/patches/49554/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/98ec658513d481f8d22c8b438cc3fedc4a718d3f.1547054251.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<98ec658513d481f8d22c8b438cc3fedc4a718d3f.1547054251.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/98ec658513d481f8d22c8b438cc3fedc4a718d3f.1547054251.git.anatoly.burakov@intel.com", "date": "2019-01-09T17:18:11", "name": "eal: move compat includes to common meson file", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "268736af8cc8e8940d180e409e785a30630cf659", "submitter": { "id": 4, "url": "http://patches.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/98ec658513d481f8d22c8b438cc3fedc4a718d3f.1547054251.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 3078, "url": "http://patches.dpdk.org/api/series/3078/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3078", "date": "2019-01-09T17:18:11", "name": "eal: move compat includes to common meson file", "version": 1, "mbox": "http://patches.dpdk.org/series/3078/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/49554/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/49554/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A97971B589;\n\tWed, 9 Jan 2019 18:18:18 +0100 (CET)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id E4A901B586;\n\tWed, 9 Jan 2019 18:18:16 +0100 (CET)", "from orsmga007.jf.intel.com ([10.7.209.58])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t09 Jan 2019 09:18:16 -0800", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby orsmga007.jf.intel.com with ESMTP; 09 Jan 2019 09:18:14 -0800", "from sivswdev05.ir.intel.com (sivswdev05.ir.intel.com\n\t[10.243.17.64])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tx09HID5S017782; Wed, 9 Jan 2019 17:18:13 GMT", "from sivswdev05.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev05.ir.intel.com with ESMTP id x09HIDZR024162;\n\tWed, 9 Jan 2019 17:18:13 GMT", "(from aburakov@localhost)\n\tby sivswdev05.ir.intel.com with LOCAL id x09HIBb1024158;\n\tWed, 9 Jan 2019 17:18:12 GMT" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.56,458,1539673200\"; d=\"scan'208\";a=\"105274734\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, bruce.richardson@intel.com,\n\tdavid.marchand@redhat.com, stable@dpdk.org", "Date": "Wed, 9 Jan 2019 17:18:11 +0000", "Message-Id": "<98ec658513d481f8d22c8b438cc3fedc4a718d3f.1547054251.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "Subject": "[dpdk-dev] [PATCH] eal: move compat includes to common meson file", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Currently, while EAL does depend on librte_compat as far as common\nmeson build is concerned, for some reason the headers for that\nlibrary are not added into the list of includes. This is fixed in\nLinuxapp-specific meson file, but is absent from FreeBSD meson file.\n\nThis worked fine up until recently, when an rte_compat dependency\nwas added to rte_log, which is a common header. Fix this issue by\nadding librte_compat includes to common EAL meson file.\n\nFixes: 844514c73569 (\"eal: build with meson\")\nFixes: a8499f65a1d1 (\"log: add missing experimental tag\")\nCc: bruce.richardson@intel.com\nCc: david.marchand@redhat.com\nCc: stable@dpdk.org\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n lib/librte_eal/linuxapp/eal/meson.build | 2 +-\n lib/librte_eal/meson.build | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/librte_eal/linuxapp/eal/meson.build b/lib/librte_eal/linuxapp/eal/meson.build\nindex 6e31c2aaa..7e68b2c0d 100644\n--- a/lib/librte_eal/linuxapp/eal/meson.build\n+++ b/lib/librte_eal/linuxapp/eal/meson.build\n@@ -1,7 +1,7 @@\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright(c) 2017 Intel Corporation\n \n-eal_inc += include_directories('include', '../../../librte_compat')\n+eal_inc += include_directories('include')\n install_subdir('include/exec-env', install_dir: get_option('includedir'))\n \n env_objs = []\ndiff --git a/lib/librte_eal/meson.build b/lib/librte_eal/meson.build\nindex a18f3a826..67e26de8d 100644\n--- a/lib/librte_eal/meson.build\n+++ b/lib/librte_eal/meson.build\n@@ -4,7 +4,7 @@\n # Custom EAL processing. EAL is complicated enough that it can't just\n # have a straight list of headers and source files.\n # Initially pull in common settings\n-eal_inc = [global_inc]\n+eal_inc = [global_inc, include_directories('../librte_compat')]\n subdir('common') # defines common_sources, common_objs, etc.\n \n # Now do OS/exec-env specific settings, including building kernel modules\n", "prefixes": [] }