Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/49490/?format=api
{ "id": 49490, "url": "http://patches.dpdk.org/api/patches/49490/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190107202225.4249-1-sthemmin@microsoft.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190107202225.4249-1-sthemmin@microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190107202225.4249-1-sthemmin@microsoft.com", "date": "2019-01-07T20:22:25", "name": "[pktgen] Fix string truncation warnings", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": true, "hash": "3f794e527371132dcc450b6c7f6a945eec0ae708", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190107202225.4249-1-sthemmin@microsoft.com/mbox/", "series": [ { "id": 3042, "url": "http://patches.dpdk.org/api/series/3042/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=3042", "date": "2019-01-07T20:22:25", "name": "[pktgen] Fix string truncation warnings", "version": 1, "mbox": "http://patches.dpdk.org/series/3042/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/49490/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/49490/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D3BEB1B508;\n\tMon, 7 Jan 2019 21:22:40 +0100 (CET)", "from mail-pl1-f169.google.com (mail-pl1-f169.google.com\n\t[209.85.214.169]) by dpdk.org (Postfix) with ESMTP id C2A691B505\n\tfor <dev@dpdk.org>; Mon, 7 Jan 2019 21:22:35 +0100 (CET)", "by mail-pl1-f169.google.com with SMTP id p8so684136plo.2\n\tfor <dev@dpdk.org>; Mon, 07 Jan 2019 12:22:35 -0800 (PST)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\t4sm110701409pfq.10.2019.01.07.12.22.32\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 07 Jan 2019 12:22:32 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=tC0EitVnRs5SM83dxSdlWIk8W2il3QguQIotfdT/UWA=;\n\tb=h8LMzgG/lZ0r8kPqjEG+6Q/b9hiiQaKkn7Sepf4PUXyx/VrPFzQWDd3Y2OCT6vKvBx\n\t5mACcx1XILXBFaqCgUTCG/saasDK68IME6ticRB6EEAIJn6IkfgabT3c3D5gIlZ9Ep/M\n\th4uZz++AjqAs+t5jFzXdrcuDEFA5ufv17alRh1slFrRxFC7mHfQH5D/axSKQ23Zsjg58\n\t8I2Y5fcgrQ+Bdsn0YnpP5XuzH4pVWmy6KZ4ZhoWMD8VhJVX1WV9xlSzJ+1InQS4t25NN\n\tUUTT8ye0aJfXKN/CHYokpPfaODQdLSFZ94FXlzpXpLNmz7jujpqP1EmfOtWLUetjWAEm\n\tlUXw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=tC0EitVnRs5SM83dxSdlWIk8W2il3QguQIotfdT/UWA=;\n\tb=Wnrgzo7Q8zhk4PZ+LBBDTYBShnnq0X9l3eYVu29dyzLl+vpAFLOii9GWLp+01sIh1O\n\tXyT8Fl1E1H9DA2egLVJUe/bWV5glY/XmbrPt3xAg0Py3+oqDExlFGuAIiScmc5hxi1s1\n\t3pSQMn5PbnnufKORSRKbgnS5H+h8M+6M1tF0+rMUCfLmatjaS6hP4rYWjFERJ29NCl8B\n\tRxk87hhlNf5rbFcTIO1vnu6CoxaWK/HBfdP/odgyuWHx/CWmadNkrTsbunTfTq4yToaQ\n\tYu6nLIqsI9oD+rakRIZWLkymkrqkblM3+jyDiyVwpuA3nZm0RVEz6hK73oCjkMmzN7Xx\n\tD9Yw==", "X-Gm-Message-State": "AJcUukev/7rYA5+5bJr0cfIaLPpvOf903bepaCAbISgHG350OJwfeCTv\n\t3P+PPUhz9yJv7FExD2cXlcF1+LWCwi0=", "X-Google-Smtp-Source": "ALg8bN7m7iW1ltugQRUKnHEiPWO+4zZ09MnxYggMQGiDpVTSlLHcaAb67jo0M9KRex6y3eD70gPt3w==", "X-Received": "by 2002:a17:902:b90b:: with SMTP id\n\tbf11mr61930199plb.284.1546892554069; \n\tMon, 07 Jan 2019 12:22:34 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "X-Google-Original-From": "Stephen Hemminger <sthemmin@microsoft.com>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Mon, 7 Jan 2019 12:22:25 -0800", "Message-Id": "<20190107202225.4249-1-sthemmin@microsoft.com>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] [pktgen] Fix string truncation warnings", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Stephen Hemminger <stephen@networkplumber.org>\n\nThe strncatf macro will cause warnings with latest GCC\nif the sizeof the destination buffer is smaller than the temporary buffer.\n\nResolve by adjusting buffer sizes.\n\nSuch as:\ngit/pktgen-dpdk/app/pktgen-capture.c: In function ‘pktgen_set_capture’:\ngit/pktgen-dpdk/app/pktgen-log.h:114:3: error: ‘strncat’ output may be truncated copying between 0 and 255 bytes from a string of length 1022 [-Werror=stringop-truncation]\n strncat(dest, _buff, sizeof(dest) - strlen(dest) - 1); \\\n ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\ngit/pktgen-dpdk/app/pktgen-capture.c:246:7: note: in expansion of macro ‘strncatf’\n strncatf(status, \"%d%%\", pct);\n ^~~~~~~~\ncc1: all warnings being treated as errors\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n app/pktgen-capture.c | 2 +-\n app/pktgen-log.h | 10 +++++-----\n 2 files changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/app/pktgen-capture.c b/app/pktgen-capture.c\nindex aee4ff9bd650..0f3f42bdc488 100644\n--- a/app/pktgen-capture.c\n+++ b/app/pktgen-capture.c\n@@ -200,7 +200,7 @@ found_rx_lid:\n \t\t\tsize_t mem_dumped = 0;\n \t\t\tunsigned int pct = 0;\n \n-\t\t\tchar status[256];\n+\t\t\tchar status[1024];\n \t\t\tsprintf(\n \t\t\t status,\n \t\t\t \"\\r Dumping ~%.2fMB of captured data to disk: 0%%\",\ndiff --git a/app/pktgen-log.h b/app/pktgen-log.h\nindex 46e347b72b3f..8d132d88c748 100644\n--- a/app/pktgen-log.h\n+++ b/app/pktgen-log.h\n@@ -108,11 +108,11 @@ extern \"C\" {\n * arguments. It formats the string and appends it to the existing string, while\n * avoiding possible buffer overruns.\n */\n-#define strncatf(dest, fmt, ...) do {\t\t\t\t\t \\\n-\t\tchar _buff[1024];\t\t\t\t\t\t \\\n-\t\tsnprintf(_buff, sizeof(_buff), fmt, ## __VA_ARGS__);\t\t\t\\\n-\t\tstrncat(dest, _buff, sizeof(dest) - strlen(dest) - 1);\t\t \\\n-} while (0)\n+#define strncatf(dest, fmt, ...) do {\t\t\t\t\t\\\n+\t\tchar _buff[1023];\t\t\t\t\t\\\n+\t\tsnprintf(_buff, sizeof(_buff), fmt, ## __VA_ARGS__);\t\\\n+\t\tstrncat(dest, _buff, sizeof(dest) - strlen(dest) - 1);\t\\\n+\t} while (0)\n \n /* Initialize log data structures */\n void pktgen_init_log(void);\n", "prefixes": [ "pktgen" ] }