Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/49299/?format=api
{ "id": 49299, "url": "http://patches.dpdk.org/api/patches/49299/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20181227062233.30781-12-hemant.agrawal@nxp.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20181227062233.30781-12-hemant.agrawal@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20181227062233.30781-12-hemant.agrawal@nxp.com", "date": "2018-12-27T06:23:08", "name": "[11/20] bus/fslmc: rename portal pi index to consumer index", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "dfe99bb8b11beaab87b5033c32a76ba7b847d086", "submitter": { "id": 477, "url": "http://patches.dpdk.org/api/people/477/?format=api", "name": "Hemant Agrawal", "email": "hemant.agrawal@nxp.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20181227062233.30781-12-hemant.agrawal@nxp.com/mbox/", "series": [ { "id": 2954, "url": "http://patches.dpdk.org/api/series/2954/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=2954", "date": "2018-12-27T06:22:50", "name": "NXP DPAA2 fixes and enhancements", "version": 1, "mbox": "http://patches.dpdk.org/series/2954/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/49299/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/49299/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 33D8E5B3A;\n\tThu, 27 Dec 2018 07:23:20 +0100 (CET)", "from EUR01-VE1-obe.outbound.protection.outlook.com\n\t(mail-eopbgr140084.outbound.protection.outlook.com [40.107.14.84])\n\tby dpdk.org (Postfix) with ESMTP id 63B6B5689\n\tfor <dev@dpdk.org>; Thu, 27 Dec 2018 07:23:09 +0100 (CET)", "from VI1PR0401MB2541.eurprd04.prod.outlook.com (10.168.65.19) by\n\tVI1PR0401MB2382.eurprd04.prod.outlook.com (10.169.134.11) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1471.20; Thu, 27 Dec 2018 06:23:08 +0000", "from VI1PR0401MB2541.eurprd04.prod.outlook.com\n\t([fe80::555e:164:f8f0:dbb4]) by\n\tVI1PR0401MB2541.eurprd04.prod.outlook.com\n\t([fe80::555e:164:f8f0:dbb4%2]) with mapi id 15.20.1471.019;\n\tThu, 27 Dec 2018 06:23:08 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=9CuOq796UjiJQbUIFpBH2AAxFTj/0nyzLS+l5XC//DA=;\n\tb=k26UTk2BIXpMavAtKhmUBrmMw0iv/FUO6/ASxOHELEn94r7ZijVKg/GSbQvvSLiPnwt/hxHQ9mPKT9xZdLQXYOpiWRTPv4OoXYvJmCfoef1tGWS4yBqz7Y8fL27ke7L8dWhBspqNL4SBIkLxZoHzItpxTTQGmeQ1o/I/Oy+OC18=", "From": "Hemant Agrawal <hemant.agrawal@nxp.com>", "To": "\"dev@dpdk.org\" <dev@dpdk.org>", "CC": "\"ferruh.yigit@intel.com\" <ferruh.yigit@intel.com>, Shreyansh Jain\n\t<shreyansh.jain@nxp.com>, Youri Querry <youri.querry_1@nxp.com>", "Thread-Topic": "[PATCH 11/20] bus/fslmc: rename portal pi index to consumer\n\tindex", "Thread-Index": "AQHUnayiIT6BsRrKw0qXGAwMptZ4Mg==", "Date": "Thu, 27 Dec 2018 06:23:08 +0000", "Message-ID": "<20181227062233.30781-12-hemant.agrawal@nxp.com>", "References": "<20181227062233.30781-1-hemant.agrawal@nxp.com>", "In-Reply-To": "<20181227062233.30781-1-hemant.agrawal@nxp.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[14.143.30.134]", "x-mailer": "git-send-email 2.17.1", "x-clientproxiedby": "BM1PR01CA0120.INDPRD01.PROD.OUTLOOK.COM\n\t(2603:1096:b00:40::14) To VI1PR0401MB2541.eurprd04.prod.outlook.com\n\t(2603:10a6:800:56::19)", "authentication-results": "spf=none (sender IP is )\n\tsmtp.mailfrom=hemant.agrawal@nxp.com; ", "x-ms-exchange-messagesentrepresentingtype": "1", "x-ms-publictraffictype": "Email", "x-microsoft-exchange-diagnostics": "1; VI1PR0401MB2382;\n\t6:uyX0FLKuMJ5Jqy9GcO8mlQ6TfBEt3bIql67YAzR+kZYRHX/hJtMkt+ZDFqAPFLCENUtFVjI2lXmYHt6h4yrsHUiTei4SDHPjigudsYpFG3mkZVKQFxEA92C21Xb+Mn5wUPAG73lx6dfUjcHb8z6l7OZ32hfm5VRYCT3qjfmLKdvrrplxrLOGBsrXKDozb3wOuCq0mUJBRr4tYJup/fdHJXlJeUrLjnyC3IxH3I2x+adBmkBkrBuFJhvNiYDXVokNi5Fw+f8JDP3vEohskyO7bwx34PqO/QiI1qsRkuG+wkA/9LEQqVvO2y7jBOsk7BpRaYtNKYdjN1ycWWkRKU6D6Q5+VKYkHcKEqxdZbRRfe/ydzpwteBFzuc7dDHFIN5UJuUZi/o/Qa/3+dsJvH9JYPqgSWJlzB4/UtCA76TQCngvQSda8LUPiZVo+lcT/PEwqIGmSr3Iz04Z/sjCDxE2Qsg==;\n\t5:T+8PFyEMiyCMzZ6TDwjXzEYfybV9xnmFW4gE1XYOynvJ38pNH1EEOqPwIm11c30HgK5NLadWYEh5yoSgbEonBjDGebnfn4ElN95/eQPARX9jhe9flP3cmRHYTDW3Ki3SAqe7BlNZZdKDJd6liWtYtK7d1ybwKrf92L4y5i6JBPU=;\n\t7:tLLFiHbnYKHoUcS90jpT6sLUGWOrKbK/a1g/M41371hwIZp4pMbuGr+37a43s/MiLOIMzOMsmN65LBWYgeEJyucDyx80Ujs/hZetJnSqbndwfP9CrAZpP/WAOAoYNXPbov3stjL6045z+x2R89nccA==", "x-ms-office365-filtering-correlation-id": "0ce76b5a-3d08-40d1-a796-08d66bc3c48f", "x-ms-office365-filtering-ht": "Tenant", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020);\n\tSRVR:VI1PR0401MB2382; ", "x-ms-traffictypediagnostic": "VI1PR0401MB2382:", "x-microsoft-antispam-prvs": "<VI1PR0401MB238223A69DD7666F04E8E45889B60@VI1PR0401MB2382.eurprd04.prod.outlook.com>", "x-exchange-antispam-report-cfa-test": "BCL:0; PCL:0;\n\tRULEID:(8211001083)(3230021)(908002)(999002)(5005026)(6040522)(2401047)(8121501046)(10201501046)(3002001)(93006095)(93001095)(3231475)(944501520)(52105112)(6055026)(6041310)(20161123560045)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(201708071742011)(7699051)(76991095);\n\tSRVR:VI1PR0401MB2382; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0401MB2382; ", "x-forefront-prvs": "0899B47777", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(136003)(396003)(366004)(376002)(39860400002)(346002)(199004)(189003)(5660300001)(1076003)(575784001)(26005)(76176011)(186003)(71200400001)(256004)(25786009)(105586002)(4326008)(6436002)(305945005)(11346002)(106356001)(14444005)(446003)(44832011)(476003)(7736002)(55236004)(102836004)(78486014)(486006)(386003)(68736007)(52116002)(86362001)(6506007)(2616005)(71190400001)(66066001)(316002)(54906003)(6116002)(3846002)(2906002)(14454004)(36756003)(99286004)(50226002)(8936002)(1730700003)(81156014)(81166006)(8676002)(6512007)(53936002)(478600001)(97736004)(6486002)(6916009)(5640700003)(2351001)(2501003);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0401MB2382;\n\tH:VI1PR0401MB2541.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; \n\tPTR:InfoNoRecords; A:1; MX:1; ", "received-spf": "None (protection.outlook.com: nxp.com does not designate\n\tpermitted sender hosts)", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam-message-info": "uLtThg0PzY/mZsSLa4VVOC1Fx4WUDNJykK4vOtA4sURPo2ZwNa1zJoQqze5VLv2+Uxt4JahxXxAa4oSHMMnxYS660O16PzP6UHiFt1h30imFM/ZHJ22jnLLW1BmK+aCuNnwWhHPkcjZVI46ymjlkPNIO1XgI+s6MOqEXbgdNMvW5AKedf9yNOqobfAVL9d+MLbNmX1ObM/faqc7FtQMGk03pN1O612fBxOeLPo0G313rAQOv10JaRnfD3edirSD0ZBOYUMChlSVlxB+Zxe+QsTbrK63Od/JzO/SfY9MHieHdJRu8mj/YUTPyYRSrPXv3", "spamdiagnosticoutput": "1:99", "spamdiagnosticmetadata": "NSPM", "Content-Type": "text/plain; charset=\"iso-8859-1\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-OriginatorOrg": "nxp.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "0ce76b5a-3d08-40d1-a796-08d66bc3c48f", "X-MS-Exchange-CrossTenant-originalarrivaltime": "27 Dec 2018 06:23:08.3328\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "VI1PR0401MB2382", "Subject": "[dpdk-dev] [PATCH 11/20] bus/fslmc: rename portal pi index to\n\tconsumer index", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This is to align with the latest qbman hw library\n\nSigned-off-by: Youri Querry <youri.querry_1@nxp.com>\nSigned-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>\n---\n drivers/bus/fslmc/qbman/qbman_portal.c | 51 +++++++++++---------------\n drivers/bus/fslmc/qbman/qbman_portal.h | 2 +-\n 2 files changed, 23 insertions(+), 30 deletions(-)", "diff": "diff --git a/drivers/bus/fslmc/qbman/qbman_portal.c b/drivers/bus/fslmc/qbman/qbman_portal.c\nindex 08bfdc9f8..14f4b0344 100644\n--- a/drivers/bus/fslmc/qbman/qbman_portal.c\n+++ b/drivers/bus/fslmc/qbman/qbman_portal.c\n@@ -251,21 +251,21 @@ struct qbman_swp *qbman_swp_init(const struct qbman_swp_desc *d)\n \t}\n \n \tfor (mask_size = p->eqcr.pi_ring_size; mask_size > 0; mask_size >>= 1)\n-\t\tp->eqcr.pi_mask = (p->eqcr.pi_mask<<1) + 1;\n+\t\tp->eqcr.pi_ci_mask = (p->eqcr.pi_ci_mask<<1) + 1;\n \teqcr_pi = qbman_cinh_read(&p->sys, QBMAN_CINH_SWP_EQCR_PI);\n-\tp->eqcr.pi = eqcr_pi & p->eqcr.pi_mask;\n+\tp->eqcr.pi = eqcr_pi & p->eqcr.pi_ci_mask;\n \tp->eqcr.pi_vb = eqcr_pi & QB_VALID_BIT;\n \tif ((p->desc.qman_version & QMAN_REV_MASK) >= QMAN_REV_5000\n \t\t\t&& (d->cena_access_mode == qman_cena_fastest_access))\n-\t\tp->eqcr.ci = qbman_cinh_read(&p->sys,\n-\t\t\t\tQBMAN_CINH_SWP_EQCR_CI) & p->eqcr.pi_mask;\n+\t\tp->eqcr.ci = qbman_cinh_read(&p->sys, QBMAN_CINH_SWP_EQCR_PI)\n+\t\t\t\t\t & p->eqcr.pi_ci_mask;\n \telse\n-\t\tp->eqcr.ci = qbman_cinh_read(&p->sys,\n-\t\t\t\tQBMAN_CINH_SWP_EQCR_PI) & p->eqcr.pi_mask;\n+\t\tp->eqcr.ci = qbman_cinh_read(&p->sys, QBMAN_CINH_SWP_EQCR_CI)\n+\t\t\t\t\t & p->eqcr.pi_ci_mask;\n \tp->eqcr.available = p->eqcr.pi_ring_size -\n \t\t\t\tqm_cyc_diff(p->eqcr.pi_ring_size,\n-\t\t\t\tp->eqcr.ci & (p->eqcr.pi_mask<<1),\n-\t\t\t\tp->eqcr.pi & (p->eqcr.pi_mask<<1));\n+\t\t\t\tp->eqcr.ci & (p->eqcr.pi_ci_mask<<1),\n+\t\t\t\tp->eqcr.pi & (p->eqcr.pi_ci_mask<<1));\n \n \tportal_idx_map[p->desc.idx] = p;\n \treturn p;\n@@ -646,8 +646,8 @@ static int qbman_swp_enqueue_ring_mode_direct(struct qbman_swp *s,\n \tconst uint32_t *cl = qb_cl(d);\n \tuint32_t eqcr_ci, full_mask, half_mask;\n \n-\thalf_mask = (s->eqcr.pi_mask>>1);\n-\tfull_mask = s->eqcr.pi_mask;\n+\thalf_mask = (s->eqcr.pi_ci_mask>>1);\n+\tfull_mask = s->eqcr.pi_ci_mask;\n \tif (!s->eqcr.available) {\n \t\teqcr_ci = s->eqcr.ci;\n \t\ts->eqcr.ci = qbman_cena_read_reg(&s->sys,\n@@ -685,8 +685,8 @@ static int qbman_swp_enqueue_ring_mode_mem_back(struct qbman_swp *s,\n \tconst uint32_t *cl = qb_cl(d);\n \tuint32_t eqcr_ci, full_mask, half_mask;\n \n-\thalf_mask = (s->eqcr.pi_mask>>1);\n-\tfull_mask = s->eqcr.pi_mask;\n+\thalf_mask = (s->eqcr.pi_ci_mask>>1);\n+\tfull_mask = s->eqcr.pi_ci_mask;\n \tif (!s->eqcr.available) {\n \t\teqcr_ci = s->eqcr.ci;\n \t\ts->eqcr.ci = qbman_cena_read_reg(&s->sys,\n@@ -743,8 +743,8 @@ static int qbman_swp_enqueue_multiple_direct(struct qbman_swp *s,\n \tint i, num_enqueued = 0;\n \tuint64_t addr_cena;\n \n-\thalf_mask = (s->eqcr.pi_mask>>1);\n-\tfull_mask = s->eqcr.pi_mask;\n+\thalf_mask = (s->eqcr.pi_ci_mask>>1);\n+\tfull_mask = s->eqcr.pi_ci_mask;\n \tif (!s->eqcr.available) {\n \t\teqcr_ci = s->eqcr.ci;\n \t\ts->eqcr.ci = qbman_cena_read_reg(&s->sys,\n@@ -811,8 +811,8 @@ static int qbman_swp_enqueue_multiple_mem_back(struct qbman_swp *s,\n \tuint32_t eqcr_ci, eqcr_pi, half_mask, full_mask;\n \tint i, num_enqueued = 0;\n \n-\thalf_mask = (s->eqcr.pi_mask>>1);\n-\tfull_mask = s->eqcr.pi_mask;\n+\thalf_mask = (s->eqcr.pi_ci_mask>>1);\n+\tfull_mask = s->eqcr.pi_ci_mask;\n \tif (!s->eqcr.available) {\n \t\teqcr_ci = s->eqcr.ci;\n \t\ts->eqcr.ci = qbman_cena_read_reg(&s->sys,\n@@ -833,15 +833,6 @@ static int qbman_swp_enqueue_multiple_mem_back(struct qbman_swp *s,\n \t\t\t\tQBMAN_CENA_SWP_EQCR(eqcr_pi & half_mask));\n \t\tmemcpy(&p[1], &cl[1], 28);\n \t\tmemcpy(&p[8], &fd[i], sizeof(*fd));\n-\t\teqcr_pi++;\n-\t}\n-\n-\t/* Set the verb byte, have to substitute in the valid-bit */\n-\teqcr_pi = s->eqcr.pi;\n-\tfor (i = 0; i < num_enqueued; i++) {\n-\t\tp = qbman_cena_write_start_wo_shadow(&s->sys,\n-\t\t\t\tQBMAN_CENA_SWP_EQCR(eqcr_pi & half_mask));\n-\t\tp[0] = cl[0] | s->eqcr.pi_vb;\n \t\tif (flags && (flags[i] & QBMAN_ENQUEUE_FLAG_DCA)) {\n \t\t\tstruct qbman_eq_desc *d = (struct qbman_eq_desc *)p;\n \n@@ -849,6 +840,8 @@ static int qbman_swp_enqueue_multiple_mem_back(struct qbman_swp *s,\n \t\t\t\t((flags[i]) & QBMAN_EQCR_DCA_IDXMASK);\n \t\t}\n \t\teqcr_pi++;\n+\t\tp[0] = cl[0] | s->eqcr.pi_vb;\n+\n \t\tif (!(eqcr_pi & half_mask))\n \t\t\ts->eqcr.pi_vb ^= QB_VALID_BIT;\n \t}\n@@ -880,8 +873,8 @@ static int qbman_swp_enqueue_multiple_desc_direct(struct qbman_swp *s,\n \tint i, num_enqueued = 0;\n \tuint64_t addr_cena;\n \n-\thalf_mask = (s->eqcr.pi_mask>>1);\n-\tfull_mask = s->eqcr.pi_mask;\n+\thalf_mask = (s->eqcr.pi_ci_mask>>1);\n+\tfull_mask = s->eqcr.pi_ci_mask;\n \tif (!s->eqcr.available) {\n \t\teqcr_ci = s->eqcr.ci;\n \t\ts->eqcr.ci = qbman_cena_read_reg(&s->sys,\n@@ -943,8 +936,8 @@ static int qbman_swp_enqueue_multiple_desc_mem_back(struct qbman_swp *s,\n \tuint32_t eqcr_ci, eqcr_pi, half_mask, full_mask;\n \tint i, num_enqueued = 0;\n \n-\thalf_mask = (s->eqcr.pi_mask>>1);\n-\tfull_mask = s->eqcr.pi_mask;\n+\thalf_mask = (s->eqcr.pi_ci_mask>>1);\n+\tfull_mask = s->eqcr.pi_ci_mask;\n \tif (!s->eqcr.available) {\n \t\teqcr_ci = s->eqcr.ci;\n \t\ts->eqcr.ci = qbman_cena_read_reg(&s->sys,\ndiff --git a/drivers/bus/fslmc/qbman/qbman_portal.h b/drivers/bus/fslmc/qbman/qbman_portal.h\nindex 3b0fc540b..e54f2661c 100644\n--- a/drivers/bus/fslmc/qbman/qbman_portal.h\n+++ b/drivers/bus/fslmc/qbman/qbman_portal.h\n@@ -98,7 +98,7 @@ struct qbman_swp {\n \t\tuint32_t pi;\n \t\tuint32_t pi_vb;\n \t\tuint32_t pi_ring_size;\n-\t\tuint32_t pi_mask;\n+\t\tuint32_t pi_ci_mask;\n \t\tuint32_t ci;\n \t\tint available;\n \t} eqcr;\n", "prefixes": [ "11/20" ] }