Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/4925/?format=api
{ "id": 4925, "url": "http://patches.dpdk.org/api/patches/4925/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1432757539-8544-1-git-send-email-zoltan.kiss@linaro.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1432757539-8544-1-git-send-email-zoltan.kiss@linaro.org>", "list_archive_url": "https://inbox.dpdk.org/dev/1432757539-8544-1-git-send-email-zoltan.kiss@linaro.org", "date": "2015-05-27T20:12:19", "name": "[dpdk-dev] ixgbe: fix checking for tx_free_thresh", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "272e3a1d8b6d2d5e6b05e93ca74d3b32c01d3c49", "submitter": { "id": 202, "url": "http://patches.dpdk.org/api/people/202/?format=api", "name": "Zoltan Kiss", "email": "zoltan.kiss@linaro.org" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1432757539-8544-1-git-send-email-zoltan.kiss@linaro.org/mbox/", "series": [], "comments": "http://patches.dpdk.org/api/patches/4925/comments/", "check": "pending", "checks": "http://patches.dpdk.org/api/patches/4925/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 1B585567E;\n\tWed, 27 May 2015 22:12:46 +0200 (CEST)", "from mail-wi0-f178.google.com (mail-wi0-f178.google.com\n\t[209.85.212.178]) by dpdk.org (Postfix) with ESMTP id C636F2A07\n\tfor <dev@dpdk.org>; Wed, 27 May 2015 22:12:44 +0200 (CEST)", "by wicmx19 with SMTP id mx19so104476983wic.0\n\tfor <dev@dpdk.org>; Wed, 27 May 2015 13:12:44 -0700 (PDT)", "from localhost.localdomain ([90.152.119.35])\n\tby mx.google.com with ESMTPSA id tl3sm52654wjc.20.2015.05.27.13.12.43\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tWed, 27 May 2015 13:12:43 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=m4kJpY5UZfD4yU9V7vysebfph6vkNo/+LL95La55XEM=;\n\tb=YaZ8P8OCHLssWleL4s362fbdrbrKAOs4bSA0ugAPHjkp0MeLRe5eBoUz4m2he8IXMD\n\tBneIxrg5MQNEyR22o4Nlpntv9Od4yudXioaCxbVXwKXwf7izS43pJrMi+XgBDkmRw0Gz\n\tZAxTS+iR5vL7PQmazxkgPdLL7LgVMFQVynTh1K/N6K7jmU3HrsHR4eyOsyvK8/vmREGr\n\tAtGt1pESaG2Hsrr7ExzOxRelE8WShn5RsSDPgHHb6COG6dSWCJp26voqg6Yave4wBysg\n\teVcM3xZIYpLvAzd3wLhlM6DbuNqoTrjnFFOTqXUpPltFL96id4JGvxtZPsoElw3mG/PP\n\tYd0g==", "X-Gm-Message-State": "ALoCoQkh7L82KIqkvvvSmoq1k856xODceMLFBxHU0MwPW22JfOE4NOtz6AMuJMlG+4qMSUoD2g/j", "X-Received": "by 10.180.105.74 with SMTP id gk10mr54496684wib.29.1432757564568;\n\tWed, 27 May 2015 13:12:44 -0700 (PDT)", "From": "Zoltan Kiss <zoltan.kiss@linaro.org>", "To": "dev@dpdk.org", "Date": "Wed, 27 May 2015 21:12:19 +0100", "Message-Id": "<1432757539-8544-1-git-send-email-zoltan.kiss@linaro.org>", "X-Mailer": "git-send-email 1.9.1", "Subject": "[dpdk-dev] [PATCH] ixgbe: fix checking for tx_free_thresh", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This check doesn't do what's required by rte_eth_tx_burst:\n\"When the number of previously sent packets reached the \"minimum transmit\npackets to free\" threshold\"\n\nThis can cause problems when txq->tx_free_thresh + [number of elements in the\npool] < txq->nb_tx_desc.\n\nSigned-off-by: Zoltan Kiss <zoltan.kiss@linaro.org>\n---\n drivers/net/ixgbe/ixgbe_rxtx.c | 4 ++--\n drivers/net/ixgbe/ixgbe_rxtx_vec.c | 2 +-\n 2 files changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c\nindex 4f9ab22..b70ed8c 100644\n--- a/drivers/net/ixgbe/ixgbe_rxtx.c\n+++ b/drivers/net/ixgbe/ixgbe_rxtx.c\n@@ -250,10 +250,10 @@ tx_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \n \t/*\n \t * Begin scanning the H/W ring for done descriptors when the\n-\t * number of available descriptors drops below tx_free_thresh. For\n+\t * number of in flight descriptors reaches tx_free_thresh. For\n \t * each done descriptor, free the associated buffer.\n \t */\n-\tif (txq->nb_tx_free < txq->tx_free_thresh)\n+\tif ((txq->nb_tx_desc - txq->nb_tx_free) > txq->tx_free_thresh)\n \t\tixgbe_tx_free_bufs(txq);\n \n \t/* Only use descriptors that are available */\ndiff --git a/drivers/net/ixgbe/ixgbe_rxtx_vec.c b/drivers/net/ixgbe/ixgbe_rxtx_vec.c\nindex abd10f6..f91c698 100644\n--- a/drivers/net/ixgbe/ixgbe_rxtx_vec.c\n+++ b/drivers/net/ixgbe/ixgbe_rxtx_vec.c\n@@ -598,7 +598,7 @@ ixgbe_xmit_pkts_vec(void *tx_queue, struct rte_mbuf **tx_pkts,\n \tif (unlikely(nb_pkts > RTE_IXGBE_VPMD_TX_BURST))\n \t\tnb_pkts = RTE_IXGBE_VPMD_TX_BURST;\n \n-\tif (txq->nb_tx_free < txq->tx_free_thresh)\n+\tif ((txq->nb_tx_desc - txq->nb_tx_free) > txq->tx_free_thresh)\n \t\tixgbe_tx_free_bufs(txq);\n \n \tnb_commit = nb_pkts = (uint16_t)RTE_MIN(txq->nb_tx_free, nb_pkts);\n", "prefixes": [ "dpdk-dev" ] }