Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/49208/?format=api
{ "id": 49208, "url": "http://patches.dpdk.org/api/patches/49208/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/4a38da694ec265a04da45810aa1ea64ae9fa4e8a.1545325395.git.gaetan.rivet@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<4a38da694ec265a04da45810aa1ea64ae9fa4e8a.1545325395.git.gaetan.rivet@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/4a38da694ec265a04da45810aa1ea64ae9fa4e8a.1545325395.git.gaetan.rivet@6wind.com", "date": "2018-12-20T17:06:47", "name": "[v1,8/8] option: return an error when register fail", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "20bcdc8c19354af84e8e1e28025df34c3265c6f1", "submitter": { "id": 269, "url": "http://patches.dpdk.org/api/people/269/?format=api", "name": "Gaëtan Rivet", "email": "gaetan.rivet@6wind.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/4a38da694ec265a04da45810aa1ea64ae9fa4e8a.1545325395.git.gaetan.rivet@6wind.com/mbox/", "series": [ { "id": 2907, "url": "http://patches.dpdk.org/api/series/2907/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=2907", "date": "2018-12-20T17:06:39", "name": "Clean up rte_option", "version": 1, "mbox": "http://patches.dpdk.org/series/2907/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/49208/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/49208/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6BBB41BDCA;\n\tThu, 20 Dec 2018 18:07:30 +0100 (CET)", "from mail-wr1-f67.google.com (mail-wr1-f67.google.com\n\t[209.85.221.67]) by dpdk.org (Postfix) with ESMTP id 4A30C1BDB1\n\tfor <dev@dpdk.org>; Thu, 20 Dec 2018 18:07:25 +0100 (CET)", "by mail-wr1-f67.google.com with SMTP id t6so2525655wrr.12\n\tfor <dev@dpdk.org>; Thu, 20 Dec 2018 09:07:25 -0800 (PST)", "from bidouze.dev.6wind.com. (host.78.145.23.62.rev.coltfrance.com.\n\t[62.23.145.78]) by smtp.gmail.com with ESMTPSA id\n\tn5sm11951688wrr.94.2018.12.20.09.07.23\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 20 Dec 2018 09:07:23 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=Fq/+lKpw0k3c0gxNQ7oXHZFU55uXKlpp/hK4aJLsNsw=;\n\tb=1kXIxjcvcMAsPhCBZLWmbH1V1bVPxbg1Y5Nef9CmN4udx7Xyf9tFGPV7bxlBapjJDb\n\tntBWubuoe6RL2q7/n4vaThU0FaObUxMnythBPXsmF6EBxFaLX6RQw/cOU0Fsg+bD+zNP\n\tXsj0o5XBuRyUeWGlybysQi8l2YjrDjcL3VJtlRKfgUFlG0as67PfAK/hImw9rm9pzT3L\n\tZWYkW3oFnUXm20J4+MznvzegykUxsgDbonW4D2UQdJAHns0KGlQF3mZMYvFRBNhaAGzP\n\tn6Slqzb3Au1BLM9wsQwYwB3nVKB9pmuVMYTSRCvdn8nPnV650ccF8AU3vV9kdzPlgIyM\n\tihKw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=Fq/+lKpw0k3c0gxNQ7oXHZFU55uXKlpp/hK4aJLsNsw=;\n\tb=Y6APPaxeSk5NtzxHRJixzCxvM//VFtB92Gs4GlZFe3VotzE5SqNABUn4eZ4a0z/aSV\n\tMwv3mw50seFlknZieNMTbU3F7sHEg+AXxWZnfin4G8l6KdaRSm4a4YThbP1fYxCj3pB4\n\tk2OPaTwH63FqoezkWjuEwlVB9/Kcl92RNl2nybGr8sGzYx02z5R8NIeQ1YVXr1cweUvh\n\tETbQjyj3Nmyu0zBnXK0I+InS35oQ+WiOx1Dg+RrdJoqc4VpehygFvyttqpsmH0spFfqq\n\tPTx6SAOomNARx1GE9/xg3DavJZLCwGb9kJp6NexiHrYD17ns60N3pDfgCO06ZBDi4laL\n\tPoZQ==", "X-Gm-Message-State": "AA+aEWYxEL0dOkviLTijwL3QZ10FYid2nccfAZpumGerxDuhK7CFZAzw\n\tSJYW95LI/pFPEiW5Ezc8ngfwlDXO33Q=", "X-Google-Smtp-Source": "AFSGD/VRNzjMAiPxK4zJcQwAJfooWif4j8Z+VhmABJsvcBtgJs1weuG1aqlXnWqSnjX2MRDhiXwqBw==", "X-Received": "by 2002:adf:fd03:: with SMTP id\n\te3mr22489130wrr.280.1545325644620; \n\tThu, 20 Dec 2018 09:07:24 -0800 (PST)", "From": "Gaetan Rivet <gaetan.rivet@6wind.com>", "To": "dev@dpdk.org", "Cc": "Gaetan Rivet <gaetan.rivet@6wind.com>", "Date": "Thu, 20 Dec 2018 18:06:47 +0100", "Message-Id": "<4a38da694ec265a04da45810aa1ea64ae9fa4e8a.1545325395.git.gaetan.rivet@6wind.com>", "X-Mailer": "git-send-email 2.19.1", "In-Reply-To": "<cover.1545325395.git.gaetan.rivet@6wind.com>", "References": "<cover.1545325395.git.gaetan.rivet@6wind.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v1 8/8] option: return an error when register fail", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Make rte_option_register return a negative value when\nan error occur.\n\nSigned-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>\n---\n lib/librte_eal/common/include/rte_option.h | 6 +++++-\n lib/librte_eal/common/rte_option.c | 8 +++++---\n 2 files changed, 10 insertions(+), 4 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/include/rte_option.h b/lib/librte_eal/common/include/rte_option.h\nindex 20be47d91..7ad65a4eb 100644\n--- a/lib/librte_eal/common/include/rte_option.h\n+++ b/lib/librte_eal/common/include/rte_option.h\n@@ -57,8 +57,12 @@ struct rte_option {\n *\n * @param opt\n * Structure describing the option to parse.\n+ *\n+ * @return\n+ * 0 on success, <0 otherwise.\n */\n-void __rte_experimental\n+__rte_experimental\n+int\n rte_option_register(struct rte_option *opt);\n \n #ifdef __cplusplus\ndiff --git a/lib/librte_eal/common/rte_option.c b/lib/librte_eal/common/rte_option.c\nindex b2c93b220..fe7f2ab4e 100644\n--- a/lib/librte_eal/common/rte_option.c\n+++ b/lib/librte_eal/common/rte_option.c\n@@ -38,7 +38,8 @@ rte_option_parse(const char *opt)\n \treturn -1;\n }\n \n-void __rte_experimental\n+__rte_experimental\n+int\n rte_option_register(struct rte_option *opt)\n {\n \tstruct rte_option *option;\n@@ -49,7 +50,7 @@ rte_option_register(struct rte_option *opt)\n \t\tif (strcmp(gopt->name, opt->name) == 0) {\n \t\t\tRTE_LOG(ERR, EAL, \"Option %s is already a common EAL option.\\n\",\n \t\t\t\t\topt->name);\n-\t\t\treturn;\n+\t\t\treturn -1;\n \t\t}\n \t\tgopt++;\n \t}\n@@ -58,11 +59,12 @@ rte_option_register(struct rte_option *opt)\n \t\tif (strcmp(opt->name, option->name) == 0) {\n \t\t\tRTE_LOG(ERR, EAL, \"Option %s has already been registered.\\n\",\n \t\t\t\t\topt->name);\n-\t\t\treturn;\n+\t\t\treturn -1;\n \t\t}\n \t}\n \n \tTAILQ_INSERT_HEAD(&rte_option_list, opt, next);\n+\treturn 0;\n }\n \n void\n", "prefixes": [ "v1", "8/8" ] }