Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/49205/?format=api
{ "id": 49205, "url": "http://patches.dpdk.org/api/patches/49205/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/64e6b0b1b696b3e99e28ab35f42b1e94e8e42582.1545325395.git.gaetan.rivet@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<64e6b0b1b696b3e99e28ab35f42b1e94e8e42582.1545325395.git.gaetan.rivet@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/64e6b0b1b696b3e99e28ab35f42b1e94e8e42582.1545325395.git.gaetan.rivet@6wind.com", "date": "2018-12-20T17:06:44", "name": "[v1,5/8] option: check against common option on register", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "f2228fa7b475026b6b4ada4e8a0288ba12bc63c2", "submitter": { "id": 269, "url": "http://patches.dpdk.org/api/people/269/?format=api", "name": "Gaëtan Rivet", "email": "gaetan.rivet@6wind.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/64e6b0b1b696b3e99e28ab35f42b1e94e8e42582.1545325395.git.gaetan.rivet@6wind.com/mbox/", "series": [ { "id": 2907, "url": "http://patches.dpdk.org/api/series/2907/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=2907", "date": "2018-12-20T17:06:39", "name": "Clean up rte_option", "version": 1, "mbox": "http://patches.dpdk.org/series/2907/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/49205/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/49205/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7AC371BDB8;\n\tThu, 20 Dec 2018 18:07:25 +0100 (CET)", "from mail-wr1-f67.google.com (mail-wr1-f67.google.com\n\t[209.85.221.67]) by dpdk.org (Postfix) with ESMTP id 7984C1BD7E\n\tfor <dev@dpdk.org>; Thu, 20 Dec 2018 18:07:21 +0100 (CET)", "by mail-wr1-f67.google.com with SMTP id v13so2531754wrw.5\n\tfor <dev@dpdk.org>; Thu, 20 Dec 2018 09:07:21 -0800 (PST)", "from bidouze.dev.6wind.com. (host.78.145.23.62.rev.coltfrance.com.\n\t[62.23.145.78]) by smtp.gmail.com with ESMTPSA id\n\tn5sm11951688wrr.94.2018.12.20.09.07.19\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 20 Dec 2018 09:07:19 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=uie/3rwQ24KmeEpvlOrXaqi5jI/o7o1nZhLCcUAXDZQ=;\n\tb=khEzqVlpZx98cx+QcJ/YCq6syTf4WYUhCc9sJfBZAAQuPtqS2zFZeXtVirwsdwzKXP\n\t5GeAHiw952mlFqNDCBVQGeH5Wily6Nxo2VD2d+IDc44LvcWk55BgPo5MSdZtq+NccTsK\n\t5oLFYbCX4RAZ/xphw7f4sRt1bUpYyM12rVZC4WSOggmRadvJjwlc560KaIhMflWu44Gx\n\tmuIHb9jerGwiJIaOJd+e12AeyrYZOHjDr1a5a+vD98J7E7Fd8Vatv/YTSch6z+EU8WED\n\tskbUdkuaCVQSNHflDPmXizwiYnN+9cHb5Nq6FCzP0FVd0r99vZsY3V/jvTdW8ttZyrqn\n\tWmiQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=uie/3rwQ24KmeEpvlOrXaqi5jI/o7o1nZhLCcUAXDZQ=;\n\tb=T1lqMYiJd00NPUPRqO/p0rhlIP+RX4oM7nPtS7G4ZQdfQOESvjv3PUM01/dP3CBdW8\n\tzugUFcpHat43FhAm7gwkvtL/Ln9/kzUOZ7rJ3CGcn8kovp7NLFhHDSXu9hSEKKl1r/m8\n\ts2pJgnZVc6FMcLyRKD73EWdo8mcGUPhubqzCIHQVNLdOxTYccMYECt9h31FzaInx+FRn\n\tDk0St7LriCGgLNBmhIGUtpaGvfHc0Ohdih1nrDIgb68o/dnXSHVHW6OkH3EFys00XNEX\n\tPNbOt8m7gTVac3DjH0EO8TmMJd2FxU17FZ6y/zYPOB08w/HJeDsgEY9oktsJ63q24GlF\n\tWV4A==", "X-Gm-Message-State": "AA+aEWbqVjnlW3JiilvjadmT7E/Hh4OMuHc0/t+DXc3bPXlTq3w8eUKI\n\tvcRL2zCz+Vy4b+gsO7hFKYBcpiIbVgQ=", "X-Google-Smtp-Source": "AFSGD/UHBu2BQsdI/8FP7ejNIzu3bWoGl2dxo6jeiWa7gwRqxYfg6Xysdrtduwge4lBcM2bjEIo47A==", "X-Received": "by 2002:adf:a357:: with SMTP id\n\td23mr24294425wrb.195.1545325640702; \n\tThu, 20 Dec 2018 09:07:20 -0800 (PST)", "From": "Gaetan Rivet <gaetan.rivet@6wind.com>", "To": "dev@dpdk.org", "Cc": "Gaetan Rivet <gaetan.rivet@6wind.com>", "Date": "Thu, 20 Dec 2018 18:06:44 +0100", "Message-Id": "<64e6b0b1b696b3e99e28ab35f42b1e94e8e42582.1545325395.git.gaetan.rivet@6wind.com>", "X-Mailer": "git-send-email 2.19.1", "In-Reply-To": "<cover.1545325395.git.gaetan.rivet@6wind.com>", "References": "<cover.1545325395.git.gaetan.rivet@6wind.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v1 5/8] option: check against common option on\n\tregister", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Not only check against other registered options, but also common EAL\noptions. This will mitigate user confusion.\n\nSigned-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>\n---\n lib/librte_eal/common/rte_option.c | 14 ++++++++++++++\n 1 file changed, 14 insertions(+)", "diff": "diff --git a/lib/librte_eal/common/rte_option.c b/lib/librte_eal/common/rte_option.c\nindex d94363872..ae8a0e2ca 100644\n--- a/lib/librte_eal/common/rte_option.c\n+++ b/lib/librte_eal/common/rte_option.c\n@@ -2,6 +2,7 @@\n * Copyright(c) 2018 Intel Corporation.\n */\n \n+#include <getopt.h>\n #include <unistd.h>\n #include <string.h>\n \n@@ -9,6 +10,8 @@\n #include <rte_option.h>\n \n #include \"eal_private.h\"\n+#include \"eal_internal_cfg.h\" /* Necessary for eal_options.h */\n+#include \"eal_options.h\"\n \n TAILQ_HEAD(rte_option_list, rte_option);\n \n@@ -39,6 +42,17 @@ void __rte_experimental\n rte_option_register(struct rte_option *opt)\n {\n \tstruct rte_option *option;\n+\tconst struct option *gopt;\n+\n+\tgopt = &eal_long_options[0];\n+\twhile (gopt->name != NULL) {\n+\t\tif (strcmp(gopt->name, opt->name) == 0) {\n+\t\t\tRTE_LOG(ERR, EAL, \"Option %s is already a common EAL option.\\n\",\n+\t\t\t\t\topt->name);\n+\t\t\treturn;\n+\t\t}\n+\t\tgopt++;\n+\t}\n \n \tTAILQ_FOREACH(option, &rte_option_list, next) {\n \t\tif (strcmp(opt->name, option->name) == 0) {\n", "prefixes": [ "v1", "5/8" ] }