Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/49204/?format=api
{ "id": 49204, "url": "http://patches.dpdk.org/api/patches/49204/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/5ed62946ea2ffd627c5422bb5569cb0841f88a69.1545325395.git.gaetan.rivet@6wind.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<5ed62946ea2ffd627c5422bb5569cb0841f88a69.1545325395.git.gaetan.rivet@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/5ed62946ea2ffd627c5422bb5569cb0841f88a69.1545325395.git.gaetan.rivet@6wind.com", "date": "2018-12-20T17:06:43", "name": "[v1,4/8] option: rename name field", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "699862e318e173b915d83bb734b385e8ef530b31", "submitter": { "id": 269, "url": "http://patches.dpdk.org/api/people/269/?format=api", "name": "Gaëtan Rivet", "email": "gaetan.rivet@6wind.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/5ed62946ea2ffd627c5422bb5569cb0841f88a69.1545325395.git.gaetan.rivet@6wind.com/mbox/", "series": [ { "id": 2907, "url": "http://patches.dpdk.org/api/series/2907/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=2907", "date": "2018-12-20T17:06:39", "name": "Clean up rte_option", "version": 1, "mbox": "http://patches.dpdk.org/series/2907/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/49204/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/49204/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 124901BDB3;\n\tThu, 20 Dec 2018 18:07:24 +0100 (CET)", "from mail-wr1-f65.google.com (mail-wr1-f65.google.com\n\t[209.85.221.65]) by dpdk.org (Postfix) with ESMTP id 175F21BD78\n\tfor <dev@dpdk.org>; Thu, 20 Dec 2018 18:07:20 +0100 (CET)", "by mail-wr1-f65.google.com with SMTP id u4so2537128wrp.3\n\tfor <dev@dpdk.org>; Thu, 20 Dec 2018 09:07:20 -0800 (PST)", "from bidouze.dev.6wind.com. (host.78.145.23.62.rev.coltfrance.com.\n\t[62.23.145.78]) by smtp.gmail.com with ESMTPSA id\n\tn5sm11951688wrr.94.2018.12.20.09.07.17\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 20 Dec 2018 09:07:18 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=P2npiJFGxtEAvJUY0SsDOH23cB3yWfyPopJj5zBAsw0=;\n\tb=Txz//tAdze7tb2U6wLCP9bjB90cmJcrUDyK5O+Gg5DtYEHzUWgb3d9dvR2nGlkP9D8\n\twW2a7qJsbXJhmbMW/cuHNH9gD+yv3MsDerbS3+rxT9meyISMVo5V6Gt/fjI6Z0p9uB01\n\tZ/VN1enJV4xO/8ym2rY8O2T8aE9HPSXaAZmXkQFbEMG1RN82SObky6EMZW4okpWgEq+U\n\tMmuSnMVe/LIUDQkuibRPiobWOCs0+1jBznPCKM8ewC+5Abr05EDl3f3O/jpQy2ZI3lRU\n\t5C6ZG/c91/vm8nGS0poDwrUpAepGdtAEJYzZun2x4UmQNmKB92QYyBrQFOIdbeyZVDk7\n\toiBQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=P2npiJFGxtEAvJUY0SsDOH23cB3yWfyPopJj5zBAsw0=;\n\tb=kehAQgVObcHcUBHnkSMoLS/vs6TBAl1RnvNW0BmquowDbbQzxKXYkiAKRmQK+88dBm\n\tEtvv+iWLvXsTGuX3RF+1LM53y1EjjmxA0NEsVDkip6UkApyEJmpD49WFyJX6XZOEpHj0\n\tmyBr+Lwm97raR5XMSgVOAbO26QFiyZKzR8SJ9sFGlIooGdvWNQHh8V+3/Mmg+D5VjO9V\n\tVsgH6RuQE1rNA2Df9WsXbHBNnIZsYa9iOoaY5qy2gPhe9jx0aWNLFfUs6lcfF7XbaOXQ\n\tm0HFoQiBjYPtTGREPjX67SUZ13aEul8SENZbETS+bs/B/3x2fOmDNd+SmcxJQHtOLKwb\n\t19qQ==", "X-Gm-Message-State": "AA+aEWaUBtp1e03KDThnuwf7yYfzgQNco6mCNy5ZTqki02dyVCOuDa+l\n\tD4/LvELHKAIiCz6ugPGZYV9N3HKfFFQ=", "X-Google-Smtp-Source": "AFSGD/W+GMaKPcTRPbO9VdG83E67IVAJBevvOToRez6BMb8uWXNZHYQn/1+OfVtABpVhKkunOC+e8Q==", "X-Received": "by 2002:adf:f703:: with SMTP id r3mr22919878wrp.93.1545325639234;\n\tThu, 20 Dec 2018 09:07:19 -0800 (PST)", "From": "Gaetan Rivet <gaetan.rivet@6wind.com>", "To": "dev@dpdk.org", "Cc": "Gaetan Rivet <gaetan.rivet@6wind.com>", "Date": "Thu, 20 Dec 2018 18:06:43 +0100", "Message-Id": "<5ed62946ea2ffd627c5422bb5569cb0841f88a69.1545325395.git.gaetan.rivet@6wind.com>", "X-Mailer": "git-send-email 2.19.1", "In-Reply-To": "<cover.1545325395.git.gaetan.rivet@6wind.com>", "References": "<cover.1545325395.git.gaetan.rivet@6wind.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v1 4/8] option: rename name field", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "option->opt_* is redundant.\nThe field should also be constant.\n\nSigned-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>\n---\n lib/librte_eal/common/include/rte_option.h | 2 +-\n lib/librte_eal/common/rte_option.c | 8 ++++----\n lib/librte_telemetry/rte_telemetry.c | 2 +-\n 3 files changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/include/rte_option.h b/lib/librte_eal/common/include/rte_option.h\nindex bbcc6cec9..eea95e477 100644\n--- a/lib/librte_eal/common/include/rte_option.h\n+++ b/lib/librte_eal/common/include/rte_option.h\n@@ -34,7 +34,7 @@ typedef int (*rte_option_cb)(void);\n */\n struct rte_option {\n \tTAILQ_ENTRY(rte_option) next; /**< Next entry in the list. */\n-\tchar *opt_str; /**< The option name. */\n+\tconst char *name; /**< The option name. */\n \tconst char *usage; /**< Option summary string. */\n \trte_option_cb cb; /**< Function called when option is used. */\n \tint enabled; /**< Set when the option is used. */\ndiff --git a/lib/librte_eal/common/rte_option.c b/lib/librte_eal/common/rte_option.c\nindex 2ed74873b..d94363872 100644\n--- a/lib/librte_eal/common/rte_option.c\n+++ b/lib/librte_eal/common/rte_option.c\n@@ -26,7 +26,7 @@ rte_option_parse(const char *opt)\n \n \t/* Check if the option is registered */\n \tTAILQ_FOREACH(option, &rte_option_list, next) {\n-\t\tif (strcmp(&opt[2], option->opt_str) == 0) {\n+\t\tif (strcmp(&opt[2], option->name) == 0) {\n \t\t\toption->enabled = 1;\n \t\t\treturn 0;\n \t\t}\n@@ -41,9 +41,9 @@ rte_option_register(struct rte_option *opt)\n \tstruct rte_option *option;\n \n \tTAILQ_FOREACH(option, &rte_option_list, next) {\n-\t\tif (strcmp(opt->opt_str, option->opt_str) == 0) {\n+\t\tif (strcmp(opt->name, option->name) == 0) {\n \t\t\tRTE_LOG(INFO, EAL, \"Option %s has already been registered.\\n\",\n-\t\t\t\t\topt->opt_str);\n+\t\t\t\t\topt->name);\n \t\t\treturn;\n \t\t}\n \t}\n@@ -75,6 +75,6 @@ rte_option_usage(void)\n \n \tprintf(\"EAL dynamic options:\\n\");\n \tTAILQ_FOREACH(option, &rte_option_list, next)\n-\t\tprintf(\" --%-*s %s\\n\", 17, option->opt_str, option->usage);\n+\t\tprintf(\" --%-*s %s\\n\", 17, option->name, option->usage);\n \tprintf(\"\\n\");\n }\ndiff --git a/lib/librte_telemetry/rte_telemetry.c b/lib/librte_telemetry/rte_telemetry.c\nindex 0ba6626c1..3ba7ae8de 100644\n--- a/lib/librte_telemetry/rte_telemetry.c\n+++ b/lib/librte_telemetry/rte_telemetry.c\n@@ -1798,7 +1798,7 @@ rte_telemetry_json_socket_message_test(struct telemetry_impl *telemetry, int fd)\n int telemetry_log_level;\n \n static struct rte_option option = {\n-\t.opt_str = \"telemetry\",\n+\t.name = \"telemetry\",\n \t.usage = \"Enable telemetry backend\",\n \t.cb = &rte_telemetry_init,\n \t.enabled = 0\n", "prefixes": [ "v1", "4/8" ] }