Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/49173/?format=api
{ "id": 49173, "url": "http://patches.dpdk.org/api/patches/49173/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/e41a1a5b087d7bbe93e6bef424637fabb541383e.1545304267.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<e41a1a5b087d7bbe93e6bef424637fabb541383e.1545304267.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/e41a1a5b087d7bbe93e6bef424637fabb541383e.1545304267.git.anatoly.burakov@intel.com", "date": "2018-12-20T11:11:48", "name": "eal: fix runtime dir cleanup in noshconf mode", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "2d8f4705a40bef4d12b8b61e17513ce8ad141d30", "submitter": { "id": 4, "url": "http://patches.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/e41a1a5b087d7bbe93e6bef424637fabb541383e.1545304267.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 2892, "url": "http://patches.dpdk.org/api/series/2892/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=2892", "date": "2018-12-20T11:11:48", "name": "eal: fix runtime dir cleanup in noshconf mode", "version": 1, "mbox": "http://patches.dpdk.org/series/2892/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/49173/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/49173/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CBF4E1BAE5;\n\tThu, 20 Dec 2018 12:11:52 +0100 (CET)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n\tby dpdk.org (Postfix) with ESMTP id D023D1BAA8\n\tfor <dev@dpdk.org>; Thu, 20 Dec 2018 12:11:51 +0100 (CET)", "from orsmga007.jf.intel.com ([10.7.209.58])\n\tby fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t20 Dec 2018 03:11:50 -0800", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby orsmga007.jf.intel.com with ESMTP; 20 Dec 2018 03:11:49 -0800", "from sivswdev05.ir.intel.com (sivswdev05.ir.intel.com\n\t[10.243.17.64])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\twBKBBnYS029348; Thu, 20 Dec 2018 11:11:49 GMT", "from sivswdev05.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev05.ir.intel.com with ESMTP id wBKBBncK019100;\n\tThu, 20 Dec 2018 11:11:49 GMT", "(from aburakov@localhost)\n\tby sivswdev05.ir.intel.com with LOCAL id wBKBBmuF019096;\n\tThu, 20 Dec 2018 11:11:48 GMT" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.56,376,1539673200\"; d=\"scan'208\";a=\"100188312\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>", "Date": "Thu, 20 Dec 2018 11:11:48 +0000", "Message-Id": "<e41a1a5b087d7bbe93e6bef424637fabb541383e.1545304267.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "Subject": "[dpdk-dev] [PATCH] eal: fix runtime dir cleanup in noshconf mode", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When using --no-shconf or --in-memory modes, there is no runtime\ndirectory to be created, so there is no point in attempting to\nclean it.\n\nFixes: 0a529578f162 (\"eal: clean up unused files on initialization\")\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n lib/librte_eal/bsdapp/eal/eal.c | 5 ++++-\n lib/librte_eal/linuxapp/eal/eal.c | 5 ++++-\n 2 files changed, 8 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/eal.c\nindex 41ddb5a22..20f790a71 100644\n--- a/lib/librte_eal/bsdapp/eal/eal.c\n+++ b/lib/librte_eal/bsdapp/eal/eal.c\n@@ -901,8 +901,11 @@ rte_eal_init(int argc, char **argv)\n \t * whether we are primary or secondary process, but we cannot remove\n \t * primary process' files because secondary should be able to run even\n \t * if primary process is dead.\n+\t *\n+\t * In no_shconf mode, no runtime directory is created in the first\n+\t * place, so no cleanup needed.\n \t */\n-\tif (eal_clean_runtime_dir() < 0) {\n+\tif (!internal_config.no_shconf && eal_clean_runtime_dir() < 0) {\n \t\trte_eal_init_alert(\"Cannot clear runtime directory\\n\");\n \t\treturn -1;\n \t}\ndiff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c\nindex d252c8591..acac92987 100644\n--- a/lib/librte_eal/linuxapp/eal/eal.c\n+++ b/lib/librte_eal/linuxapp/eal/eal.c\n@@ -1189,8 +1189,11 @@ rte_eal_init(int argc, char **argv)\n \t * whether we are primary or secondary process, but we cannot remove\n \t * primary process' files because secondary should be able to run even\n \t * if primary process is dead.\n+\t *\n+\t * In no_shconf mode, no runtime directory is created in the first\n+\t * place, so no cleanup needed.\n \t */\n-\tif (eal_clean_runtime_dir() < 0) {\n+\tif (!internal_config.no_shconf && eal_clean_runtime_dir() < 0) {\n \t\trte_eal_init_alert(\"Cannot clear runtime directory\\n\");\n \t\treturn -1;\n \t}\n", "prefixes": [] }