Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/48931/?format=api
{ "id": 48931, "url": "http://patches.dpdk.org/api/patches/48931/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20181214125055.1153c38c@xeon-e3/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20181214125055.1153c38c@xeon-e3>", "list_archive_url": "https://inbox.dpdk.org/dev/20181214125055.1153c38c@xeon-e3", "date": "2018-12-14T20:50:55", "name": "eal: simplify RTE_PMD_DEBUG_TRACE", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e5699dc832df62d8ee136f4e3197fc153056be6c", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20181214125055.1153c38c@xeon-e3/mbox/", "series": [ { "id": 2808, "url": "http://patches.dpdk.org/api/series/2808/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=2808", "date": "2018-12-14T20:50:55", "name": "eal: simplify RTE_PMD_DEBUG_TRACE", "version": 1, "mbox": "http://patches.dpdk.org/series/2808/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/48931/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/48931/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E41801B94D;\n\tFri, 14 Dec 2018 21:51:00 +0100 (CET)", "from mail-pg1-f194.google.com (mail-pg1-f194.google.com\n\t[209.85.215.194]) by dpdk.org (Postfix) with ESMTP id 5D4101B946\n\tfor <dev@dpdk.org>; Fri, 14 Dec 2018 21:50:59 +0100 (CET)", "by mail-pg1-f194.google.com with SMTP id w6so3207269pgl.6\n\tfor <dev@dpdk.org>; Fri, 14 Dec 2018 12:50:59 -0800 (PST)", "from xeon-e3 (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tw136sm9219385pfd.169.2018.12.14.12.50.58\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tFri, 14 Dec 2018 12:50:58 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=aDW+SxmUG4mliVfUt3ao7pz+OXpa4sxdkKsYCtKdbWc=;\n\tb=oWssoH1uEN6iYropXy2MCDQAt04Dw6Cwl5mhLilxZqOimVC9Dt7yZHiFvfKz0zK+us\n\t00h3wZPSxsB2h/Yzs1CYLe6n7Ev7wCTXcQqe/couhrTlZIJwd//y+TNfGXv2nMBrWsSu\n\toljGvatU+/tDT1AfMntcKjlQ8MeLv+x9kjvNscppRMv+LTJN6xDLE3EwUC2XfqLJU1i5\n\tb6hElD/KWzjkA0jbJ41XU9mkzqXlZBnCTM78RCWGXPuJfoMzIeH382JbH6V2fY2NP68v\n\t7zu6as3RV+ix/sXsXrbpcl03DLOJhuLfavo/BxR8P7HdyYjIQKqxdiLw4zHtIUqS5KfA\n\tseIw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=aDW+SxmUG4mliVfUt3ao7pz+OXpa4sxdkKsYCtKdbWc=;\n\tb=d413GmpBVjh6FM9RqtOrWXtEL98pQPXUtL8+m0umFGpzm3ZWlacnqHScyN+S5eGetn\n\tM7PvZRf4SBx+Kp8SzJiDTssCmKQCwIFQMgo+W5sg+wal2HkZBZwmgvTVD0s+j7cWp8w3\n\tS1poQcxlTjR2Lew7yepgMTFdkOxDERKOoYIN8R0YX2Y/mETSzRjuwu+Xgt7A/YYE/V8c\n\tup0tQkcOOFXGTk1bcJRY75zuGauQIewnfCvLgfAt10iIIIjkmx8Wb5+a5cYv4vfkUBDr\n\t6gc+jjTAL3WAbqa83PQVpQIdqRjAE+iSgcwn5qefEeu40zViOYZd7dmqt2XM2JiCeijq\n\tvVsw==", "X-Gm-Message-State": "AA+aEWYcqbwReIibmo4ZE7aRFVs9UPzGlNti+wzuTXGoEUygCV4LxGzh\n\tJu94j1KgleqMyJpjMrWcKlq6tg==", "X-Google-Smtp-Source": "AFSGD/XxofIMdaXltW6uTdKRX9Iokk93NJ5utBfLs45etknnlqV+yMPhVkABBX0LoAPb8G36dE0Ipg==", "X-Received": "by 2002:a63:2643:: with SMTP id m64mr3966317pgm.35.1544820658281;\n\tFri, 14 Dec 2018 12:50:58 -0800 (PST)", "Date": "Fri, 14 Dec 2018 12:50:55 -0800", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "Mattias =?utf-8?b?UsO2bm5ibG9t?= <mattias.ronnblom@ericsson.com>", "Cc": "Jeff Shaw <jeffrey.b.shaw@intel.com>, dev@dpdk.org", "Message-ID": "<20181214125055.1153c38c@xeon-e3>", "In-Reply-To": "<3a573b56-6ea0-812c-4641-830fbd3c59cc@ericsson.com>", "References": "<20181214163827.9403-1-jeffrey.b.shaw@intel.com>\n\t<dc4f658d-76a4-ff6f-d3c0-21084e439d27@lysator.liu.se>\n\t<20181214190713.GB9964@ae13-28.jf.intel.com>\n\t<3a573b56-6ea0-812c-4641-830fbd3c59cc@ericsson.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=US-ASCII", "Content-Transfer-Encoding": "7bit", "Subject": "[dpdk-dev] [PATCH] eal: simplify RTE_PMD_DEBUG_TRACE", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Use rte_log directly, eliminating no longer used rte_pmd_dev_trace\nfunction. This removes variable length array which is problem on\nWindows and other compilers not doing C99.\n\nAlso, drop unused RTE_PROC_PRIMARY macros.\n\nReported-by: Jeff Shaw <jeffrey.b.shaw@intel.com>\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/librte_eal/common/include/rte_dev.h | 43 ++-----------------------\n 1 file changed, 3 insertions(+), 40 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/include/rte_dev.h b/lib/librte_eal/common/include/rte_dev.h\nindex a9724dc9181c..e496da440028 100644\n--- a/lib/librte_eal/common/include/rte_dev.h\n+++ b/lib/librte_eal/common/include/rte_dev.h\n@@ -43,54 +43,17 @@ typedef void (*rte_dev_event_cb_fn)(const char *device_name,\n \t\t\t\t\tenum rte_dev_event_type event,\n \t\t\t\t\tvoid *cb_arg);\n \n-__attribute__((format(printf, 2, 0)))\n-static inline void\n-rte_pmd_debug_trace(const char *func_name, const char *fmt, ...)\n-{\n-\tva_list ap;\n-\n-\tva_start(ap, fmt);\n-\n-\t{\n-\t\tchar buffer[vsnprintf(NULL, 0, fmt, ap) + 1];\n-\n-\t\tva_end(ap);\n-\n-\t\tva_start(ap, fmt);\n-\t\tvsnprintf(buffer, sizeof(buffer), fmt, ap);\n-\t\tva_end(ap);\n-\n-\t\trte_log(RTE_LOG_ERR, RTE_LOGTYPE_PMD, \"%s: %s\",\n-\t\t\tfunc_name, buffer);\n-\t}\n-}\n-\n /*\n * Enable RTE_PMD_DEBUG_TRACE() when at least one component relying on the\n * RTE_*_RET() macros defined below is compiled in debug mode.\n */\n #if defined(RTE_LIBRTE_EVENTDEV_DEBUG)\n-#define RTE_PMD_DEBUG_TRACE(...) \\\n-\trte_pmd_debug_trace(__func__, __VA_ARGS__)\n+#define RTE_PMD_DEBUG_TRACE(fmt, args...) \\\n+\trte_log(RTE_LOG_ERR, RTE_LOGTYPE_PMD, \"%s():\" fmt, __func__, ## args)\n #else\n-#define RTE_PMD_DEBUG_TRACE(...) (void)0\n+#define RTE_PMD_DEBUG_TRACE(...) do { } while(0)\n #endif\n \n-/* Macros for checking for restricting functions to primary instance only */\n-#define RTE_PROC_PRIMARY_OR_ERR_RET(retval) do { \\\n-\tif (rte_eal_process_type() != RTE_PROC_PRIMARY) { \\\n-\t\tRTE_PMD_DEBUG_TRACE(\"Cannot run in secondary processes\\n\"); \\\n-\t\treturn retval; \\\n-\t} \\\n-} while (0)\n-\n-#define RTE_PROC_PRIMARY_OR_RET() do { \\\n-\tif (rte_eal_process_type() != RTE_PROC_PRIMARY) { \\\n-\t\tRTE_PMD_DEBUG_TRACE(\"Cannot run in secondary processes\\n\"); \\\n-\t\treturn; \\\n-\t} \\\n-} while (0)\n-\n /* Macros to check for invalid function pointers */\n #define RTE_FUNC_PTR_OR_ERR_RET(func, retval) do { \\\n \tif ((func) == NULL) { \\\n", "prefixes": [] }