Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 48876,
    "url": "http://patches.dpdk.org/api/patches/48876/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20181214131846.22439-19-mk@semihalf.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20181214131846.22439-19-mk@semihalf.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20181214131846.22439-19-mk@semihalf.com",
    "date": "2018-12-14T13:18:44",
    "name": "[18/20] net/ena: update completion queue after cleanup",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "c8bdfb8c0183b872250516fab185cc860315f5a4",
    "submitter": {
        "id": 786,
        "url": "http://patches.dpdk.org/api/people/786/?format=api",
        "name": "Michal Krawczyk",
        "email": "mk@semihalf.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20181214131846.22439-19-mk@semihalf.com/mbox/",
    "series": [
        {
            "id": 2783,
            "url": "http://patches.dpdk.org/api/series/2783/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=2783",
            "date": "2018-12-14T13:18:26",
            "name": "net/ena: ENAv2 release",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/2783/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/48876/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/48876/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B2B891BC6F;\n\tFri, 14 Dec 2018 14:19:42 +0100 (CET)",
            "from mail-lf1-f66.google.com (mail-lf1-f66.google.com\n\t[209.85.167.66]) by dpdk.org (Postfix) with ESMTP id B46151BB6F\n\tfor <dev@dpdk.org>; Fri, 14 Dec 2018 14:19:21 +0100 (CET)",
            "by mail-lf1-f66.google.com with SMTP id z13so4208605lfe.11\n\tfor <dev@dpdk.org>; Fri, 14 Dec 2018 05:19:21 -0800 (PST)",
            "from mkPC.semihalf.local (31-172-191-173.noc.fibertech.net.pl.\n\t[31.172.191.173]) by smtp.gmail.com with ESMTPSA id\n\to25sm873884lfd.29.2018.12.14.05.19.19\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 14 Dec 2018 05:19:20 -0800 (PST)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=semihalf-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=1YHLFG7lWUwpcmncfPR5dF9Zm66KjEAUP9Bpv+KhUpM=;\n\tb=nwqFJlgfpTuoomocYMTMJ3qs8c14Qux0BFDIyBQZHdtgfhJrblx1ZMeJDKzORgGsqo\n\tEMsPQRi/uc++J3jekBtqBWfcDhqFZcU3Bv1JKJv6aYYlQg2X1Vgb1q+Jw8fUcTw2Pj6J\n\tF2PeO9nCcWAPcadJDeh42FFtalKvl5UoBStAbt/cTt4z+Bj2cXcjnv3/bWcfH1Xmq69W\n\tepiERJlTqPNDd8U4ggarANWuVIxWZf4q/QLOA75QUBbvqh6Nry9XOCqMLySGUNE0YFDF\n\tjWxfY+ytJCam9IEmaI2l5iBzzzxeI7I6fiJGjZ6RAo4OsU1EaJ+U1f4LgEPUuoSyAz4B\n\tJlVw==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=1YHLFG7lWUwpcmncfPR5dF9Zm66KjEAUP9Bpv+KhUpM=;\n\tb=TzA2JwNIsXL40KEft36hloXYAmfjClllTv+m/4s5M7z8VMcMV8GTLtqmdaKlwx1lzb\n\tZGvuob+vJkJvqO6mdDsnNvkrdGbn5pR2xIDN6LHXu1Evny7SYnb8F7PBffRAx7uo0XRU\n\tIZ5aV1F64/yzBDxSaYYjslHUTejyoARlFvKw8SMirtisXiytggPBi6WDkVh6BfgKoZYv\n\taOsj9PJrUYkVj0BoGSj7nSRST45MTto6oe5Ey/LW7JJSz0Ivq6QhcG8n4By6M8sUzKXw\n\tV/YK5qHBEbYLjfMd2rQrEihZeOlZ57w988KIt3qChGMAD908oqKG9pLhqE2ci00hNs4/\n\t2Xpg==",
        "X-Gm-Message-State": "AA+aEWYnw+Zkq9yyNLPv8hHkPgMwfc44a6zc7r8Lk3s5udZQNOsGU7JV\n\tAOIszpZW0ytNhFdPhlDU+jahcCoWWls=",
        "X-Google-Smtp-Source": "AFSGD/V2EZZNd5SLIDisXJm9GjrPCBzfQDYkljkG6wE8o1KO67FKHtcyZLd4CiMRzK3oKIiBLkNmtA==",
        "X-Received": "by 2002:a19:200b:: with SMTP id g11mr1772830lfg.58.1544793561066;\n\tFri, 14 Dec 2018 05:19:21 -0800 (PST)",
        "From": "Michal Krawczyk <mk@semihalf.com>",
        "To": "dev@dpdk.org",
        "Cc": "gtzalik@dpdk.org,\n\tmw@dpdk.org,\n\tmatua@amazon.com,\n\trk@semihalf.com",
        "Date": "Fri, 14 Dec 2018 14:18:44 +0100",
        "Message-Id": "<20181214131846.22439-19-mk@semihalf.com>",
        "X-Mailer": "git-send-email 2.14.1",
        "In-Reply-To": "<20181214131846.22439-1-mk@semihalf.com>",
        "References": "<20181214131846.22439-1-mk@semihalf.com>",
        "Subject": "[dpdk-dev] [PATCH 18/20] net/ena: update completion queue after\n\tcleanup",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Rafal Kozik <rk@semihalf.com>\n\nAfter Rx or Tx cleanup update completion queue head by calling\nena_com_update_dev_comp_head().\n\nFixes: 1daff5260ff8 (\"net/ena: use unmasked head and tail\")\n\nSigned-off-by: Rafal Kozik <rk@semihalf.com>\nAcked-by: Michal Krawczyk <mk@semihalf.com>\n---\n drivers/net/ena/ena_ethdev.c | 7 +++++--\n 1 file changed, 5 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c\nindex 2b84cc79d..b336102ba 100644\n--- a/drivers/net/ena/ena_ethdev.c\n+++ b/drivers/net/ena/ena_ethdev.c\n@@ -2126,8 +2126,10 @@ static uint16_t eth_ena_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,\n \n \tdesc_in_use = desc_in_use - completed + 1;\n \t/* Burst refill to save doorbells, memory barriers, const interval */\n-\tif (ring_size - desc_in_use > ENA_RING_DESCS_RATIO(ring_size))\n+\tif (ring_size - desc_in_use > ENA_RING_DESCS_RATIO(ring_size)) {\n+\t\tena_com_update_dev_comp_head(rx_ring->ena_com_io_cq);\n \t\tena_populate_rx_queue(rx_ring, ring_size - desc_in_use);\n+\t}\n \n \treturn recv_idx;\n }\n@@ -2438,8 +2440,9 @@ static uint16_t eth_ena_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \n \tif (total_tx_descs > 0) {\n \t\t/* acknowledge completion of sent packets */\n-\t\tena_com_comp_ack(tx_ring->ena_com_io_sq, total_tx_descs);\n \t\ttx_ring->next_to_clean = next_to_clean;\n+\t\tena_com_comp_ack(tx_ring->ena_com_io_sq, total_tx_descs);\n+\t\tena_com_update_dev_comp_head(tx_ring->ena_com_io_cq);\n \t}\n \n \ttx_ring->tx_stats.tx_poll++;\n",
    "prefixes": [
        "18/20"
    ]
}