Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/48875/?format=api
{ "id": 48875, "url": "http://patches.dpdk.org/api/patches/48875/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20181214131846.22439-18-mk@semihalf.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20181214131846.22439-18-mk@semihalf.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20181214131846.22439-18-mk@semihalf.com", "date": "2018-12-14T13:18:43", "name": "[17/20] net/ena: new way of getting rx drops", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "af449efde1a7eca3a6f0bb727a7c4ed54a768738", "submitter": { "id": 786, "url": "http://patches.dpdk.org/api/people/786/?format=api", "name": "Michal Krawczyk", "email": "mk@semihalf.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20181214131846.22439-18-mk@semihalf.com/mbox/", "series": [ { "id": 2783, "url": "http://patches.dpdk.org/api/series/2783/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=2783", "date": "2018-12-14T13:18:26", "name": "net/ena: ENAv2 release", "version": 1, "mbox": "http://patches.dpdk.org/series/2783/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/48875/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/48875/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6EF381BC1E;\n\tFri, 14 Dec 2018 14:19:40 +0100 (CET)", "from mail-lj1-f193.google.com (mail-lj1-f193.google.com\n\t[209.85.208.193]) by dpdk.org (Postfix) with ESMTP id 9CA821BB6F\n\tfor <dev@dpdk.org>; Fri, 14 Dec 2018 14:19:20 +0100 (CET)", "by mail-lj1-f193.google.com with SMTP id s5-v6so4846871ljd.12\n\tfor <dev@dpdk.org>; Fri, 14 Dec 2018 05:19:20 -0800 (PST)", "from mkPC.semihalf.local (31-172-191-173.noc.fibertech.net.pl.\n\t[31.172.191.173]) by smtp.gmail.com with ESMTPSA id\n\to25sm873884lfd.29.2018.12.14.05.19.17\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 14 Dec 2018 05:19:18 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=semihalf-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=Pi8SLZKHzKandWenyDGvOb2HK3j3GpKY+B3mTtl4z+w=;\n\tb=kbpT6Gtfqk7qg2Ph0ohQBUUD60/WyNjp1mXk+jBHEF3AGhpxXUaeDPGHnr0tUpSsTy\n\ta83swMZeaULbMS2po+IWAb5KqQOJQgjoZv93nKrNGKT/Oyvq0LwUdX8hY0Dr9d5IeV2B\n\tz2z6pxoSl50o41QeEScFA5ojRK27ATk5fh/UbUju1rJDLe5Fq6ESnchfSBifPXugXoFY\n\tRaprBF1Zu+fH11qunWXraKmOuBeujFQytv/OWvHazKqPec7DgCPMW+2rKuAW4sEoAqYR\n\tEFCOd5W5Su6iNxTMbJskZ9n9+JMH9xKvi2oJGLTo71fNTa7tAvB/Dajjeyb4YdWZxnE5\n\tNaxw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=Pi8SLZKHzKandWenyDGvOb2HK3j3GpKY+B3mTtl4z+w=;\n\tb=fHTD5SbIxqg/g6EujfATX1j1W3WNLRIz9zHzL1pmDCfmXtuEMo2pGgM7Zbm9TCt8GP\n\t8nh/hwdw3z/mU8xg90TK0NCwRfcEPIP5xE532Yc1kvDTBmfwuwqQ255/wuAuAAOwoiMQ\n\tqnOWWs20LOXSdqN/hx+fybu7bJqVLknJD8eD3c8WIlBVQYj2CNqkVR0z0yjtvMXZ5SaK\n\ta0BST7y9WzMULauaAqXgShNWdPT8pUzUW/RTUN1dj07CZOwiXC6loi5wlFwV6sOvv3Ty\n\tKXrp39eiUElJItylyS4REl6jh/T1rB75aoTKzuFQ/P0owtJr4ibvuJkmSxeIXIk9drr3\n\t2vlw==", "X-Gm-Message-State": "AA+aEWa7WqxvG0zS8+c91p9cpDjXCifiR6SndPb+E04TfFB7HRyKBFlE\n\tiQgEAvj7F/Gwc4qlCia7Q9r/Ic2DmC4=", "X-Google-Smtp-Source": "AFSGD/UeM2emdGydZ3cw6CwnnNUT1BLRmmyBJ6MWssLaEtkhXg20ENQ+pBknOA2oHV2UiLh8WNrtZw==", "X-Received": "by 2002:a2e:2281:: with SMTP id\n\ti123-v6mr1636762lji.154.1544793559852; \n\tFri, 14 Dec 2018 05:19:19 -0800 (PST)", "From": "Michal Krawczyk <mk@semihalf.com>", "To": "dev@dpdk.org", "Cc": "gtzalik@dpdk.org,\n\tmw@dpdk.org,\n\tmatua@amazon.com,\n\trk@semihalf.com", "Date": "Fri, 14 Dec 2018 14:18:43 +0100", "Message-Id": "<20181214131846.22439-18-mk@semihalf.com>", "X-Mailer": "git-send-email 2.14.1", "In-Reply-To": "<20181214131846.22439-1-mk@semihalf.com>", "References": "<20181214131846.22439-1-mk@semihalf.com>", "Subject": "[dpdk-dev] [PATCH 17/20] net/ena: new way of getting rx drops", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Rafal Kozik <rk@semihalf.com>\n\nThe Rx drops cannot be acquired using the older API. Now, it must be\nread in keep alive message.\n\nSigned-off-by: Rafal Kozik <rk@semihalf.com>\nAcked-by: Michal Krawczyk <mk@semihalf.com>\n---\n drivers/net/ena/ena_ethdev.c | 10 ++++++++--\n drivers/net/ena/ena_ethdev.h | 1 +\n 2 files changed, 9 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c\nindex c3a26d402..2b84cc79d 100644\n--- a/drivers/net/ena/ena_ethdev.c\n+++ b/drivers/net/ena/ena_ethdev.c\n@@ -933,6 +933,7 @@ static void ena_stats_restart(struct rte_eth_dev *dev)\n \trte_atomic64_init(&adapter->drv_stats->ierrors);\n \trte_atomic64_init(&adapter->drv_stats->oerrors);\n \trte_atomic64_init(&adapter->drv_stats->rx_nombuf);\n+\trte_atomic64_init(&adapter->drv_stats->rx_drops);\n }\n \n static int ena_stats_get(struct rte_eth_dev *dev,\n@@ -965,10 +966,9 @@ static int ena_stats_get(struct rte_eth_dev *dev,\n \t\t\t\t\tena_stats.rx_bytes_low);\n \tstats->obytes = __MERGE_64B_H_L(ena_stats.tx_bytes_high,\n \t\t\t\t\tena_stats.tx_bytes_low);\n-\tstats->imissed = __MERGE_64B_H_L(ena_stats.rx_drops_high,\n-\t\t\t\t\t ena_stats.rx_drops_low);\n \n \t/* Driver related stats */\n+\tstats->imissed = rte_atomic64_read(&adapter->drv_stats->rx_drops);\n \tstats->ierrors = rte_atomic64_read(&adapter->drv_stats->ierrors);\n \tstats->oerrors = rte_atomic64_read(&adapter->drv_stats->oerrors);\n \tstats->rx_nombuf = rte_atomic64_read(&adapter->drv_stats->rx_nombuf);\n@@ -2689,8 +2689,14 @@ static void ena_keep_alive(void *adapter_data,\n \t\t\t __rte_unused struct ena_admin_aenq_entry *aenq_e)\n {\n \tstruct ena_adapter *adapter = (struct ena_adapter *)adapter_data;\n+\tstruct ena_admin_aenq_keep_alive_desc *desc;\n+\tuint64_t rx_drops;\n \n \tadapter->timestamp_wd = rte_get_timer_cycles();\n+\n+\tdesc = (struct ena_admin_aenq_keep_alive_desc *)aenq_e;\n+\trx_drops = ((uint64_t)desc->rx_drops_high << 32) | desc->rx_drops_low;\n+\trte_atomic64_set(&adapter->drv_stats->rx_drops, rx_drops);\n }\n \n /**\ndiff --git a/drivers/net/ena/ena_ethdev.h b/drivers/net/ena/ena_ethdev.h\nindex 9eca6e63b..309b92f65 100644\n--- a/drivers/net/ena/ena_ethdev.h\n+++ b/drivers/net/ena/ena_ethdev.h\n@@ -158,6 +158,7 @@ struct ena_driver_stats {\n \trte_atomic64_t ierrors;\n \trte_atomic64_t oerrors;\n \trte_atomic64_t rx_nombuf;\n+\trte_atomic64_t rx_drops;\n };\n \n struct ena_stats_dev {\n", "prefixes": [ "17/20" ] }