Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/48873/?format=api
{ "id": 48873, "url": "http://patches.dpdk.org/api/patches/48873/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20181214131846.22439-16-mk@semihalf.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20181214131846.22439-16-mk@semihalf.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20181214131846.22439-16-mk@semihalf.com", "date": "2018-12-14T13:18:41", "name": "[15/20] net/ena: add per-queue software counters stats", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "8d2e1f9916d9bedc702c96b5c12b9fb9665d5b4e", "submitter": { "id": 786, "url": "http://patches.dpdk.org/api/people/786/?format=api", "name": "Michal Krawczyk", "email": "mk@semihalf.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20181214131846.22439-16-mk@semihalf.com/mbox/", "series": [ { "id": 2783, "url": "http://patches.dpdk.org/api/series/2783/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=2783", "date": "2018-12-14T13:18:26", "name": "net/ena: ENAv2 release", "version": 1, "mbox": "http://patches.dpdk.org/series/2783/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/48873/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/48873/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6CF5D1BC0C;\n\tFri, 14 Dec 2018 14:19:36 +0100 (CET)", "from mail-lj1-f194.google.com (mail-lj1-f194.google.com\n\t[209.85.208.194]) by dpdk.org (Postfix) with ESMTP id C76501BBD8\n\tfor <dev@dpdk.org>; Fri, 14 Dec 2018 14:19:16 +0100 (CET)", "by mail-lj1-f194.google.com with SMTP id l15-v6so4857208lja.9\n\tfor <dev@dpdk.org>; Fri, 14 Dec 2018 05:19:16 -0800 (PST)", "from mkPC.semihalf.local (31-172-191-173.noc.fibertech.net.pl.\n\t[31.172.191.173]) by smtp.gmail.com with ESMTPSA id\n\to25sm873884lfd.29.2018.12.14.05.19.14\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 14 Dec 2018 05:19:15 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=semihalf-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=5xFEFGHAsNLgJhKcjue8GxC66YHYFu816mwu83F5sQE=;\n\tb=U1Uh1LnYvoMCU4e2796TeQvM7IT4u8nzQYwkRUz/EQBXotjrTWCPHvmAZSwz6tvY/4\n\tdQmsFR8lxEHn0brLtJ0KCeirxRuXeZmVcmyiP36abYHmc81WMMfpy8Vm2Li/vN+dY5oa\n\tAgSarQ+CxBnA4VliQ5e3ZqseH68KVbVUCobgUWwMiyn1KGX/8cGfRxqzhB3MmBWvnSmk\n\t08EWqG9ub1IT+x+B0sQsYRqdVSyn4D3ruCY7tsrYyJSPBOCSlBiDPul+7xX9UsWJQ1m0\n\ttksULHO5pO8RzEmcHq142NQTx+V5CeEbwHu4QblJMCr9qffKDwXA9/578p1SjFYiLy+n\n\tff9g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=5xFEFGHAsNLgJhKcjue8GxC66YHYFu816mwu83F5sQE=;\n\tb=bzcirkNl03OlRnJzuu/LqZI17oQnXs6s4RYHH7s3uhZic1hrMtTxIzkPpTP2gJ6lab\n\tZmGRarBbKRdG1rIpnIziytOW6DzzLbQMYJaoFNkn1ofoyEp6MvYxnwtInx6iw2N9F+2r\n\t1iRTBycixKYVy2fhb69W89joVs0LIVea5sGK0vG0UEL9Dk/M8x/uY5w/ZtU/iGU5qMjG\n\tKzORhq5jqwGznpcYWiETXPUKFKFLI6BSqNuyIWCBX73Eh8g7M9OcUx8b9FHyQhjDJfab\n\tQ30UzbJPQfQNe+y1nPaHO119QGSqQdDQs2UnRvGwPp96xOJMjEEaIh1/fZkeZ3w2nGe1\n\tR39w==", "X-Gm-Message-State": "AA+aEWZIrON2PBEk3J0t8iZL08imrFtxKkXmXpAF2iyjOZgPhvKUTInh\n\t8PlW4Xx8E8EXr+20sjCqNzDBkmDx188=", "X-Google-Smtp-Source": "AFSGD/VzqVYm92EkuRY4zVMnGhaV6ZAAce+9iPuTNJd6XSgOrKhW/cZe+SfUzGvxwBeQFPvMlJgAaQ==", "X-Received": "by 2002:a2e:6594:: with SMTP id\n\te20-v6mr1998598ljf.123.1544793556064; \n\tFri, 14 Dec 2018 05:19:16 -0800 (PST)", "From": "Michal Krawczyk <mk@semihalf.com>", "To": "dev@dpdk.org", "Cc": "gtzalik@dpdk.org, mw@dpdk.org, matua@amazon.com, rk@semihalf.com,\n\tMichal Krawczyk <mk@semihalf.com>,\n\tSolganik Alexander <sashas@lightbitslabs.com>", "Date": "Fri, 14 Dec 2018 14:18:41 +0100", "Message-Id": "<20181214131846.22439-16-mk@semihalf.com>", "X-Mailer": "git-send-email 2.14.1", "In-Reply-To": "<20181214131846.22439-1-mk@semihalf.com>", "References": "<20181214131846.22439-1-mk@semihalf.com>", "Subject": "[dpdk-dev] [PATCH 15/20] net/ena: add per-queue software counters\n\tstats", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Those counters provide information regards sent/received bytes and\npackets per queue.\n\nSigned-off-by: Solganik Alexander <sashas@lightbitslabs.com>\nSigned-off-by: Michal Krawczyk <mk@semihalf.com>\n---\n drivers/net/ena/ena_ethdev.c | 36 +++++++++++++++++++++++++-\n drivers/net/ena/ena_ethdev.h | 60 ++++++++++++++++++++++++--------------------\n 2 files changed, 68 insertions(+), 28 deletions(-)", "diff": "diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c\nindex ce0ca40c4..799dcefcd 100644\n--- a/drivers/net/ena/ena_ethdev.c\n+++ b/drivers/net/ena/ena_ethdev.c\n@@ -160,6 +160,7 @@ static const struct ena_stats ena_stats_rx_strings[] = {\n \tENA_STAT_RX_ENTRY(dma_mapping_err),\n \tENA_STAT_RX_ENTRY(bad_desc_num),\n \tENA_STAT_RX_ENTRY(small_copy_len_pkt),\n+\tENA_STAT_TX_ENTRY(bad_req_id),\n };\n \n static const struct ena_stats ena_stats_ena_com_strings[] = {\n@@ -390,6 +391,7 @@ static inline int validate_rx_req_id(struct ena_ring *rx_ring, uint16_t req_id)\n \n \trx_ring->adapter->reset_reason = ENA_REGS_RESET_INV_RX_REQ_ID;\n \trx_ring->adapter->trigger_reset = true;\n+\t++rx_ring->rx_stats.bad_req_id;\n \n \treturn -EFAULT;\n }\n@@ -969,6 +971,8 @@ static int ena_stats_get(struct rte_eth_dev *dev,\n \t\t(struct ena_adapter *)(dev->data->dev_private);\n \tstruct ena_com_dev *ena_dev = &adapter->ena_dev;\n \tint rc;\n+\tint i;\n+\tint max_rings_stats;\n \n \tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n \t\treturn -ENOTSUP;\n@@ -996,6 +1000,27 @@ static int ena_stats_get(struct rte_eth_dev *dev,\n \tstats->ierrors = rte_atomic64_read(&adapter->drv_stats->ierrors);\n \tstats->oerrors = rte_atomic64_read(&adapter->drv_stats->oerrors);\n \tstats->rx_nombuf = rte_atomic64_read(&adapter->drv_stats->rx_nombuf);\n+\n+\tmax_rings_stats = RTE_MIN(dev->data->nb_rx_queues,\n+\t\tRTE_ETHDEV_QUEUE_STAT_CNTRS);\n+\tfor (i = 0; i < max_rings_stats; ++i) {\n+\t\tstruct ena_stats_rx *rx_stats = &adapter->rx_ring[i].rx_stats;\n+\n+\t\tstats->q_ibytes[i] = rx_stats->bytes;\n+\t\tstats->q_ipackets[i] = rx_stats->cnt;\n+\t\tstats->q_errors[i] = rx_stats->bad_desc_num +\n+\t\t\trx_stats->bad_req_id;\n+\t}\n+\n+\tmax_rings_stats = RTE_MIN(dev->data->nb_tx_queues,\n+\t\tRTE_ETHDEV_QUEUE_STAT_CNTRS);\n+\tfor (i = 0; i < max_rings_stats; ++i) {\n+\t\tstruct ena_stats_tx *tx_stats = &adapter->tx_ring[i].tx_stats;\n+\n+\t\tstats->q_obytes[i] = tx_stats->bytes;\n+\t\tstats->q_opackets[i] = tx_stats->cnt;\n+\t}\n+\n \treturn 0;\n }\n \n@@ -1408,6 +1433,7 @@ static int ena_populate_rx_queue(struct ena_ring *rxq, unsigned int count)\n \trc = rte_mempool_get_bulk(rxq->mb_pool, (void **)mbufs, count);\n \tif (unlikely(rc < 0)) {\n \t\trte_atomic64_inc(&rxq->adapter->drv_stats->rx_nombuf);\n+\t\t++rxq->rx_stats.page_alloc_fail;\n \t\tPMD_RX_LOG(DEBUG, \"there are no enough free buffers\");\n \t\treturn 0;\n \t}\n@@ -2108,8 +2134,10 @@ static uint16_t eth_ena_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,\n \t\t/* pass to DPDK application head mbuf */\n \t\trx_pkts[recv_idx] = mbuf_head;\n \t\trecv_idx++;\n+\t\trx_ring->rx_stats.bytes += mbuf_head->pkt_len;\n \t}\n \n+\trx_ring->rx_stats.cnt += recv_idx;\n \trx_ring->next_to_clean = next_to_clean;\n \n \tdesc_in_use = desc_in_use - completed + 1;\n@@ -2256,6 +2284,7 @@ static uint16_t eth_ena_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \tuint16_t push_len = 0;\n \tuint16_t delta = 0;\n \tint nb_hw_desc;\n+\tuint32_t total_length;\n \n \t/* Check adapter state */\n \tif (unlikely(tx_ring->adapter->state != ENA_ADAPTER_STATE_RUNNING)) {\n@@ -2270,6 +2299,7 @@ static uint16_t eth_ena_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \n \tfor (sent_idx = 0; sent_idx < nb_pkts; sent_idx++) {\n \t\tmbuf = tx_pkts[sent_idx];\n+\t\ttotal_length = 0;\n \n \t\trc = ena_check_and_linearize_mbuf(tx_ring, mbuf);\n \t\tif (unlikely(rc))\n@@ -2335,6 +2365,7 @@ static uint16_t eth_ena_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \t\t\tebuf++;\n \t\t\ttx_info->num_of_bufs++;\n \t\t}\n+\t\ttotal_length += mbuf->data_len;\n \n \t\twhile ((mbuf = mbuf->next) != NULL) {\n \t\t\tseg_len = mbuf->data_len;\n@@ -2347,6 +2378,7 @@ static uint16_t eth_ena_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \n \t\t\tebuf->paddr = mbuf->buf_iova + mbuf->data_off + delta;\n \t\t\tebuf->len = seg_len - delta;\n+\t\t\ttotal_length += ebuf->len;\n \t\t\tebuf++;\n \t\t\ttx_info->num_of_bufs++;\n \n@@ -2373,6 +2405,8 @@ static uint16_t eth_ena_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \t\ttx_info->tx_descs = nb_hw_desc;\n \n \t\tnext_to_use++;\n+\t\ttx_ring->tx_stats.cnt += tx_info->num_of_bufs;\n+\t\ttx_ring->tx_stats.bytes += total_length;\n \t}\n \n \t/* If there are ready packets to be xmitted... */\n@@ -2380,7 +2414,7 @@ static uint16_t eth_ena_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \t\t/* ...let HW do its best :-) */\n \t\trte_wmb();\n \t\tena_com_write_sq_doorbell(tx_ring->ena_com_io_sq);\n-\n+\t\ttx_ring->tx_stats.doorbells++;\n \t\ttx_ring->next_to_use = next_to_use;\n \t}\n \ndiff --git a/drivers/net/ena/ena_ethdev.h b/drivers/net/ena/ena_ethdev.h\nindex 713cdea97..255e1c0ec 100644\n--- a/drivers/net/ena/ena_ethdev.h\n+++ b/drivers/net/ena/ena_ethdev.h\n@@ -79,6 +79,34 @@ struct ena_calc_queue_size_ctx {\n \tu16 max_rx_sgl_size;\n };\n \n+struct ena_stats_tx {\n+\tu64 cnt;\n+\tu64 bytes;\n+\tu64 queue_stop;\n+\tu64 prepare_ctx_err;\n+\tu64 queue_wakeup;\n+\tu64 dma_mapping_err;\n+\tu64 linearize;\n+\tu64 linearize_failed;\n+\tu64 tx_poll;\n+\tu64 doorbells;\n+\tu64 missing_tx_comp;\n+\tu64 bad_req_id;\n+};\n+\n+struct ena_stats_rx {\n+\tu64 cnt;\n+\tu64 bytes;\n+\tu64 refil_partial;\n+\tu64 bad_csum;\n+\tu64 page_alloc_fail;\n+\tu64 skb_alloc_fail;\n+\tu64 dma_mapping_err;\n+\tu64 bad_desc_num;\n+\tu64 small_copy_len_pkt;\n+\tu64 bad_req_id;\n+};\n+\n struct ena_ring {\n \tu16 next_to_use;\n \tu16 next_to_clean;\n@@ -116,6 +144,11 @@ struct ena_ring {\n \tstruct ena_adapter *adapter;\n \tuint64_t offloads;\n \tu16 sgl_size;\n+\n+\tunion {\n+\t\tstruct ena_stats_rx rx_stats;\n+\t\tstruct ena_stats_tx tx_stats;\n+\t};\n } __rte_cache_aligned;\n \n enum ena_adapter_state {\n@@ -143,33 +176,6 @@ struct ena_stats_dev {\n \tu64 admin_q_pause;\n };\n \n-struct ena_stats_tx {\n-\tu64 cnt;\n-\tu64 bytes;\n-\tu64 queue_stop;\n-\tu64 prepare_ctx_err;\n-\tu64 queue_wakeup;\n-\tu64 dma_mapping_err;\n-\tu64 linearize;\n-\tu64 linearize_failed;\n-\tu64 tx_poll;\n-\tu64 doorbells;\n-\tu64 missing_tx_comp;\n-\tu64 bad_req_id;\n-};\n-\n-struct ena_stats_rx {\n-\tu64 cnt;\n-\tu64 bytes;\n-\tu64 refil_partial;\n-\tu64 bad_csum;\n-\tu64 page_alloc_fail;\n-\tu64 skb_alloc_fail;\n-\tu64 dma_mapping_err;\n-\tu64 bad_desc_num;\n-\tu64 small_copy_len_pkt;\n-};\n-\n /* board specific private data structure */\n struct ena_adapter {\n \t/* OS defined structs */\n", "prefixes": [ "15/20" ] }