Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/48869/?format=api
{ "id": 48869, "url": "http://patches.dpdk.org/api/patches/48869/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20181214131846.22439-12-mk@semihalf.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20181214131846.22439-12-mk@semihalf.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20181214131846.22439-12-mk@semihalf.com", "date": "2018-12-14T13:18:37", "name": "[11/20] net/ena: adjust new line in log messages", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "362b1210a20742bd005aca485bba43f3203c250a", "submitter": { "id": 786, "url": "http://patches.dpdk.org/api/people/786/?format=api", "name": "Michal Krawczyk", "email": "mk@semihalf.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20181214131846.22439-12-mk@semihalf.com/mbox/", "series": [ { "id": 2783, "url": "http://patches.dpdk.org/api/series/2783/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=2783", "date": "2018-12-14T13:18:26", "name": "net/ena: ENAv2 release", "version": 1, "mbox": "http://patches.dpdk.org/series/2783/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/48869/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/48869/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8CDD01BBED;\n\tFri, 14 Dec 2018 14:19:25 +0100 (CET)", "from mail-lj1-f195.google.com (mail-lj1-f195.google.com\n\t[209.85.208.195]) by dpdk.org (Postfix) with ESMTP id BF56C1BB3B\n\tfor <dev@dpdk.org>; Fri, 14 Dec 2018 14:19:11 +0100 (CET)", "by mail-lj1-f195.google.com with SMTP id v1-v6so4901916ljd.0\n\tfor <dev@dpdk.org>; Fri, 14 Dec 2018 05:19:11 -0800 (PST)", "from mkPC.semihalf.local (31-172-191-173.noc.fibertech.net.pl.\n\t[31.172.191.173]) by smtp.gmail.com with ESMTPSA id\n\to25sm873884lfd.29.2018.12.14.05.19.09\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 14 Dec 2018 05:19:10 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=semihalf-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=yKFLIxxNSAOzYQiuNB9YNQkgCvJCTjgDgBeqiem55UE=;\n\tb=vHbUo7D0fIXQdDzb0jWQ5dXGbqkuOuy3Koy4Yxes3UAaSYI28DQJapT/XKEzqPAMA/\n\toSyAsNmhMTmLisHSd7MsxsIGav3itUOHxJZllyqF9rzZgq2CQOzWgyB3AThcPX1zCdW0\n\tTw9BvGvw2QJgz17NrjFaYI+ext51FejfqIcqAyFF5qJHsMt+ascM9A1Qf55dmIiIupwu\n\tNI70LySuC59h206T8d7tLphpecROrDOi6/OcsKduLTVRRPY8V3lIdaESt3N+lixeevQG\n\tjN1DcmDul3ZDCnuaNN5Gqucwa67ZWP6GN42Ee6dbWds1RbwsE/SUTMlgpQbxh+XS5eQk\n\tYItw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=yKFLIxxNSAOzYQiuNB9YNQkgCvJCTjgDgBeqiem55UE=;\n\tb=dpMnTdmzQOD0+oCmf1sGxBnPGDm9WiZJIEiix5R21Q77HWhhdvfiOGVDDN4KjHG6Li\n\ttp0VgD+1ddYiwK4E/A6it9Btt4oncveSGXkEaFXiFhmPOigkbM3XYqX0ddUIBRt0cV0r\n\t0OdKdVLpLjjOLPWK79ZqEmrH0r2EnB3EZUTCbfPDLH67OBpTKnF3gNPC6weOCWgank3z\n\tqdC1MuXAbznA+/9MnXAjRvw01WRbS/fTr5VBAugIs60TDbffiWxl+CMKz2ZCDOxVZ3PA\n\tpQRFh5Z3GW67RpCUbtn3fjV6lbr39oZIweXRWtfYazxlSzWz1qCSIq3+xtHqaSNORfhW\n\tfaPQ==", "X-Gm-Message-State": "AA+aEWZlp8E/oSUJqjU8nAf2I1iyTGvO8VDkv5eFuQ+KotWAxuQKLI6Q\n\t4myJMDuZ0gVpZ9zqP3er5geG3W2feo0=", "X-Google-Smtp-Source": "AFSGD/XW3O9wqIQ0uMnIVfNCEq72Y0boca81k5vNEPnrQ2VNs5zaCT+XSq3luUcu0Rf6tXZ/OCmWjw==", "X-Received": "by 2002:a2e:9819:: with SMTP id\n\ta25-v6mr2042837ljj.6.1544793550851; \n\tFri, 14 Dec 2018 05:19:10 -0800 (PST)", "From": "Michal Krawczyk <mk@semihalf.com>", "To": "dev@dpdk.org", "Cc": "gtzalik@dpdk.org,\n\tmw@dpdk.org,\n\tmatua@amazon.com,\n\trk@semihalf.com", "Date": "Fri, 14 Dec 2018 14:18:37 +0100", "Message-Id": "<20181214131846.22439-12-mk@semihalf.com>", "X-Mailer": "git-send-email 2.14.1", "In-Reply-To": "<20181214131846.22439-1-mk@semihalf.com>", "References": "<20181214131846.22439-1-mk@semihalf.com>", "Subject": "[dpdk-dev] [PATCH 11/20] net/ena: adjust new line in log messages", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Rafal Kozik <rk@semihalf.com>\n\nOnly PMD_*_LOG is adding new line character to the log message.\nAll printouts were adjusted for consistency.\n\nSigned-off-by: Rafal Kozik <rk@semihalf.com>\nAcked-by: Michal Krawczyk <mk@semihalf.com>\n---\n drivers/net/ena/ena_ethdev.c | 28 ++++++++++++++--------------\n 1 file changed, 14 insertions(+), 14 deletions(-)", "diff": "diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c\nindex 3715619a7..5adc87355 100644\n--- a/drivers/net/ena/ena_ethdev.c\n+++ b/drivers/net/ena/ena_ethdev.c\n@@ -553,7 +553,7 @@ ena_dev_reset(struct rte_eth_dev *dev)\n \tena_destroy_device(dev);\n \trc = eth_ena_dev_init(dev);\n \tif (rc)\n-\t\tPMD_INIT_LOG(CRIT, \"Cannot initialize device\\n\");\n+\t\tPMD_INIT_LOG(CRIT, \"Cannot initialize device\");\n \n \treturn rc;\n }\n@@ -880,7 +880,7 @@ static int ena_check_valid_conf(struct ena_adapter *adapter)\n \n \tif (max_frame_len > adapter->max_mtu || max_frame_len < ENA_MIN_MTU) {\n \t\tPMD_INIT_LOG(ERR, \"Unsupported MTU of %d. \"\n-\t\t\t\t \"max mtu: %d, min mtu: %d\\n\",\n+\t\t\t\t \"max mtu: %d, min mtu: %d\",\n \t\t\t max_frame_len, adapter->max_mtu, ENA_MIN_MTU);\n \t\treturn ENA_COM_UNSUPPORTED;\n \t}\n@@ -984,7 +984,7 @@ static int ena_stats_get(struct rte_eth_dev *dev,\n \tmemset(&ena_stats, 0, sizeof(ena_stats));\n \trc = ena_com_get_dev_basic_stats(ena_dev, &ena_stats);\n \tif (unlikely(rc)) {\n-\t\tRTE_LOG(ERR, PMD, \"Could not retrieve statistics from ENA\");\n+\t\tRTE_LOG(ERR, PMD, \"Could not retrieve statistics from ENA\\n\");\n \t\treturn rc;\n \t}\n \n@@ -1013,12 +1013,12 @@ static int ena_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)\n \tstruct ena_com_dev *ena_dev;\n \tint rc = 0;\n \n-\tena_assert_msg(dev->data != NULL, \"Uninitialized device\");\n-\tena_assert_msg(dev->data->dev_private != NULL, \"Uninitialized device\");\n+\tena_assert_msg(dev->data != NULL, \"Uninitialized device\\n\");\n+\tena_assert_msg(dev->data->dev_private != NULL, \"Uninitialized device\\n\");\n \tadapter = (struct ena_adapter *)(dev->data->dev_private);\n \n \tena_dev = &adapter->ena_dev;\n-\tena_assert_msg(ena_dev != NULL, \"Uninitialized device\");\n+\tena_assert_msg(ena_dev != NULL, \"Uninitialized device\\n\");\n \n \tif (mtu > ena_get_mtu_conf(adapter) || mtu < ENA_MIN_MTU) {\n \t\tRTE_LOG(ERR, PMD,\n@@ -1204,7 +1204,7 @@ static int ena_queue_start(struct ena_ring *ring)\n \n \trc = ena_create_io_queue(ring);\n \tif (rc) {\n-\t\tPMD_INIT_LOG(ERR, \"Failed to create IO queue!\\n\");\n+\t\tPMD_INIT_LOG(ERR, \"Failed to create IO queue!\");\n \t\treturn rc;\n \t}\n \n@@ -1248,7 +1248,7 @@ static int ena_tx_queue_setup(struct rte_eth_dev *dev,\n \n \tif (!rte_is_power_of_2(nb_desc)) {\n \t\tRTE_LOG(ERR, PMD,\n-\t\t\t\"Unsupported size of TX queue: %d is not a power of 2.\",\n+\t\t\t\"Unsupported size of TX queue: %d is not a power of 2.\\n\",\n \t\t\tnb_desc);\n \t\treturn -EINVAL;\n \t}\n@@ -1337,7 +1337,7 @@ static int ena_rx_queue_setup(struct rte_eth_dev *dev,\n \n \tif (!rte_is_power_of_2(nb_desc)) {\n \t\tRTE_LOG(ERR, PMD,\n-\t\t\t\"Unsupported size of RX queue: %d is not a power of 2.\",\n+\t\t\t\"Unsupported size of RX queue: %d is not a power of 2.\\n\",\n \t\t\tnb_desc);\n \t\treturn -EINVAL;\n \t}\n@@ -1410,7 +1410,7 @@ static int ena_populate_rx_queue(struct ena_ring *rxq, unsigned int count)\n \t\treturn 0;\n \n \tin_use = rxq->next_to_use - rxq->next_to_clean;\n-\tena_assert_msg(((in_use + count) < ring_size), \"bad ring state\");\n+\tena_assert_msg(((in_use + count) < ring_size), \"bad ring state\\n\");\n \n \t/* get resources for incoming packets */\n \trc = rte_mempool_get_bulk(rxq->mb_pool, (void **)mbufs, count);\n@@ -1643,7 +1643,7 @@ ena_set_queues_placement_policy(struct ena_adapter *adapter,\n \trc = ena_com_config_dev_mode(ena_dev, llq, llq_default_configurations);\n \tif (unlikely(rc)) {\n \t\tPMD_INIT_LOG(WARNING, \"Failed to config dev mode. \"\n-\t\t\t\"Fallback to host mode policy.\\n\");\n+\t\t\t\"Fallback to host mode policy.\");\n \t\tena_dev->tx_mem_queue_type = ENA_ADMIN_PLACEMENT_POLICY_HOST;\n \t\treturn 0;\n \t}\n@@ -1945,12 +1945,12 @@ static void ena_infos_get(struct rte_eth_dev *dev,\n \tuint64_t rx_feat = 0, tx_feat = 0;\n \tint rc = 0;\n \n-\tena_assert_msg(dev->data != NULL, \"Uninitialized device\");\n-\tena_assert_msg(dev->data->dev_private != NULL, \"Uninitialized device\");\n+\tena_assert_msg(dev->data != NULL, \"Uninitialized device\\n\");\n+\tena_assert_msg(dev->data->dev_private != NULL, \"Uninitialized device\\n\");\n \tadapter = (struct ena_adapter *)(dev->data->dev_private);\n \n \tena_dev = &adapter->ena_dev;\n-\tena_assert_msg(ena_dev != NULL, \"Uninitialized device\");\n+\tena_assert_msg(ena_dev != NULL, \"Uninitialized device\\n\");\n \n \tdev_info->speed_capa =\n \t\t\tETH_LINK_SPEED_1G |\n", "prefixes": [ "11/20" ] }