Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/48720/?format=api
{ "id": 48720, "url": "http://patches.dpdk.org/api/patches/48720/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20181213011014.110089-4-xiao.w.wang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20181213011014.110089-4-xiao.w.wang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20181213011014.110089-4-xiao.w.wang@intel.com", "date": "2018-12-13T01:10:08", "name": "[v2,3/9] net/ifc: dump debug message for error", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3e0797d3dc52277ba19ddbdee04ab3a9c9ce3139", "submitter": { "id": 281, "url": "http://patches.dpdk.org/api/people/281/?format=api", "name": "Xiao Wang", "email": "xiao.w.wang@intel.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20181213011014.110089-4-xiao.w.wang@intel.com/mbox/", "series": [ { "id": 2747, "url": "http://patches.dpdk.org/api/series/2747/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=2747", "date": "2018-12-13T01:10:05", "name": "support SW assisted VDPA live migration", "version": 2, "mbox": "http://patches.dpdk.org/series/2747/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/48720/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/48720/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2A5DD1B465;\n\tThu, 13 Dec 2018 02:23:00 +0100 (CET)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n\tby dpdk.org (Postfix) with ESMTP id 1AB361B463\n\tfor <dev@dpdk.org>; Thu, 13 Dec 2018 02:22:58 +0100 (CET)", "from orsmga008.jf.intel.com ([10.7.209.65])\n\tby fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t12 Dec 2018 17:22:58 -0800", "from dpdk-xiao-1.sh.intel.com ([10.67.111.145])\n\tby orsmga008.jf.intel.com with ESMTP; 12 Dec 2018 17:22:57 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.56,346,1539673200\"; d=\"scan'208\";a=\"101112843\"", "From": "Xiao Wang <xiao.w.wang@intel.com>", "To": "alejandro.lucero@netronome.com,\n\ttiwei.bie@intel.com", "Cc": "maxime.coquelin@redhat.com, dev@dpdk.org, zhihong.wang@intel.com,\n\txiaolong.ye@intel.com, Xiao Wang <xiao.w.wang@intel.com>", "Date": "Thu, 13 Dec 2018 09:10:08 +0800", "Message-Id": "<20181213011014.110089-4-xiao.w.wang@intel.com>", "X-Mailer": "git-send-email 2.15.1", "In-Reply-To": "<20181213011014.110089-1-xiao.w.wang@intel.com>", "References": "<20181128094607.106173-3-xiao.w.wang@intel.com>\n\t<20181213011014.110089-1-xiao.w.wang@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 3/9] net/ifc: dump debug message for error", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Driver probe may fail for different causes, debug message is helpful for\ndebugging issue.\n\nSigned-off-by: Xiao Wang <xiao.w.wang@intel.com>\n---\n drivers/net/ifc/ifcvf_vdpa.c | 19 +++++++++++++------\n 1 file changed, 13 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/ifc/ifcvf_vdpa.c b/drivers/net/ifc/ifcvf_vdpa.c\nindex e844109f3..aacd5f9bf 100644\n--- a/drivers/net/ifc/ifcvf_vdpa.c\n+++ b/drivers/net/ifc/ifcvf_vdpa.c\n@@ -22,7 +22,7 @@\n \n #define DRV_LOG(level, fmt, args...) \\\n \trte_log(RTE_LOG_ ## level, ifcvf_vdpa_logtype, \\\n-\t\t\"%s(): \" fmt \"\\n\", __func__, ##args)\n+\t\t\"IFCVF %s(): \" fmt \"\\n\", __func__, ##args)\n \n #ifndef PAGE_SIZE\n #define PAGE_SIZE 4096\n@@ -756,11 +756,16 @@ ifcvf_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,\n \n \tinternal->pdev = pci_dev;\n \trte_spinlock_init(&internal->lock);\n-\tif (ifcvf_vfio_setup(internal) < 0)\n-\t\treturn -1;\n \n-\tif (ifcvf_init_hw(&internal->hw, internal->pdev) < 0)\n-\t\treturn -1;\n+\tif (ifcvf_vfio_setup(internal) < 0) {\n+\t\tDRV_LOG(ERR, \"failed to setup device %s\", pci_dev->name);\n+\t\tgoto error;\n+\t}\n+\n+\tif (ifcvf_init_hw(&internal->hw, internal->pdev) < 0) {\n+\t\tDRV_LOG(ERR, \"failed to init device %s\", pci_dev->name);\n+\t\tgoto error;\n+\t}\n \n \tinternal->max_queues = IFCVF_MAX_QUEUES;\n \tfeatures = ifcvf_get_features(&internal->hw);\n@@ -782,8 +787,10 @@ ifcvf_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,\n \n \tinternal->did = rte_vdpa_register_device(&internal->dev_addr,\n \t\t\t\t&ifcvf_ops);\n-\tif (internal->did < 0)\n+\tif (internal->did < 0) {\n+\t\tDRV_LOG(ERR, \"failed to register device %s\", pci_dev->name);\n \t\tgoto error;\n+\t}\n \n \trte_atomic32_set(&internal->started, 1);\n \tupdate_datapath(internal);\n", "prefixes": [ "v2", "3/9" ] }