Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/48555/?format=api
{ "id": 48555, "url": "http://patches.dpdk.org/api/patches/48555/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20181205221159.6336-4-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20181205221159.6336-4-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20181205221159.6336-4-stephen@networkplumber.org", "date": "2018-12-05T22:11:59", "name": "[v2,4/4] bus/vmbus: debug subchannel setup", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "62437a580b3b3aee987365fd71efabc537397a85", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20181205221159.6336-4-stephen@networkplumber.org/mbox/", "series": [ { "id": 2679, "url": "http://patches.dpdk.org/api/series/2679/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=2679", "date": "2018-12-05T22:11:56", "name": "[v2,1/4] bus/vmbus: fix race in sub channel creation", "version": 2, "mbox": "http://patches.dpdk.org/series/2679/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/48555/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/48555/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3B4011B105;\n\tWed, 5 Dec 2018 23:12:28 +0100 (CET)", "from mail-pg1-f196.google.com (mail-pg1-f196.google.com\n\t[209.85.215.196]) by dpdk.org (Postfix) with ESMTP id 9D4618E76\n\tfor <dev@dpdk.org>; Wed, 5 Dec 2018 23:12:24 +0100 (CET)", "by mail-pg1-f196.google.com with SMTP id z11so9661194pgu.0\n\tfor <dev@dpdk.org>; Wed, 05 Dec 2018 14:12:24 -0800 (PST)", "from xeon-e3.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tj14sm27704578pfn.175.2018.12.05.14.12.22\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 05 Dec 2018 14:12:22 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=sGUsUpZQbTZMdq0bum8xdHpUcyo0JaJV2c1as7pxrd8=;\n\tb=GuL0YhwR7fzW86ro6zkmlzQCbtnYCtAyufH99QMnjCx4mZ0Wu1td+2HIbjEDPQv5B8\n\tvpokuxTHMFBmrd3MqN1tcgbwVBKmfG+iPpkhHXamNi3rPS/6D2++T8q6UWzuyT2HU6AU\n\tDB++BF/VYHwTqs4m9WcSoIrtCIMsdUInxMqF5ltNRKm441Lr3/fq7urHJILzbZbKLCSC\n\tSEFIhAweOBNrvAvZEbckNCEH8hyJ8syCYKGT0i+861K0yO2PCCwHEZEe5QwjuTq9AJH3\n\tNNWwwtTGnG9efc64gudLjsH7YlnYy2nclV6hD8nYK/bfCZLwK2VBEZ5Oje8b1ePjLMmc\n\tuq5g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=sGUsUpZQbTZMdq0bum8xdHpUcyo0JaJV2c1as7pxrd8=;\n\tb=GVTE2b7a26zd0yqeuXaCtQEDG6mJVZi9mPle90WJC/MwkzO40/525kVN8A00W8kdfF\n\t2c90iOwTSJWkUvqiS1FkWcd2ml2ZWXvELejlFSvikpKY9nhD8zZvWczdDPZy1jvPND4u\n\t/fwAHcwcn2JV1Sygi2tFIL9qh+TXTJkx5SnWcGFSJPNtueTE/+cyhMRa8zEzsEMcXKnq\n\t/AU8NnC6bggG519G7uzmBiiuIxpNpTAPzkZTJ0BUw1ogHEu4GYmuBB3B4wH8VkA9tvVV\n\tiluzIIu2hj6NQKG5V0xmczYvKdjqs780Qq6arPhUhkNKxEGBAuGkR1MGDdAfhTcY3dU3\n\tdW0A==", "X-Gm-Message-State": "AA+aEWZUmtA49OeZlWUn0LtYXhYtv4Iht4j40jfdfpB872k3pySgxatZ\n\t4NuQfYLeTIZG85dF+pVqi+PvF8r9ZGI=", "X-Google-Smtp-Source": "AFSGD/WJWFED4L4+QVSULqdGQM3OXPZ9lVql6X9CmGIyJAhpwbPcXxSJCO3lVeE0pxwPMaFyxn+7HQ==", "X-Received": "by 2002:a62:5dd1:: with SMTP id\n\tn78mr25630379pfj.58.1544047943496; \n\tWed, 05 Dec 2018 14:12:23 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "mgamal@redhat.com, Stephen Hemminger <stephen@networkplumber.org>,\n\tStephen Hemminger <sthemmin@microsoft.com>", "Date": "Wed, 5 Dec 2018 14:11:59 -0800", "Message-Id": "<20181205221159.6336-4-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.19.2", "In-Reply-To": "<20181205221159.6336-1-stephen@networkplumber.org>", "References": "<1543575881.5400.33.camel@redhat.com>\n\t<20181205221159.6336-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 4/4] bus/vmbus: debug subchannel setup", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add more instrumentation to subchannel setup to help diagnose\nstartup issues.\n\nSigned-off-by: Stephen Hemminger <sthemmin@microsoft.com>\n---\n drivers/bus/vmbus/linux/vmbus_uio.c | 24 +++++++++++++++---------\n 1 file changed, 15 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/bus/vmbus/linux/vmbus_uio.c b/drivers/bus/vmbus/linux/vmbus_uio.c\nindex 38df4d724ed5..09f7efdca286 100644\n--- a/drivers/bus/vmbus/linux/vmbus_uio.c\n+++ b/drivers/bus/vmbus/linux/vmbus_uio.c\n@@ -357,19 +357,25 @@ int vmbus_uio_get_subchan(struct vmbus_channel *primary,\n \t\t\tcontinue;\n \t\t}\n \n-\t\tif (!vmbus_isnew_subchannel(primary, relid))\n-\t\t\tcontinue;\t/* Already know about you */\n+\t\tif (!vmbus_isnew_subchannel(primary, relid)) {\n+\t\t\tVMBUS_LOG(DEBUG, \"skip already found channel: %lu\",\n+\t\t\t\t relid);\n+\t\t\tcontinue;\n+\t\t}\n \n-\t\tif (!vmbus_uio_ring_present(dev, relid))\n-\t\t\tcontinue;\t/* Ring may not be ready yet */\n+\t\tif (!vmbus_uio_ring_present(dev, relid)) {\n+\t\t\tVMBUS_LOG(DEBUG, \"ring mmap not found (yet) for: %lu\",\n+\t\t\t\t relid);\n+\t\t\tcontinue;\n+\t\t}\n \n \t\tsnprintf(subchan_path, sizeof(subchan_path), \"%s/%lu\",\n \t\t\t chan_path, relid);\n \t\terr = vmbus_uio_sysfs_read(subchan_path, \"subchannel_id\",\n \t\t\t\t\t &subid, UINT16_MAX);\n \t\tif (err) {\n-\t\t\tVMBUS_LOG(NOTICE, \"invalid subchannel id %lu\",\n-\t\t\t\t subid);\n+\t\t\tVMBUS_LOG(NOTICE, \"no subchannel_id in %s:%s\",\n+\t\t\t\t subchan_path, strerror(-err));\n \t\t\tgoto fail;\n \t\t}\n \n@@ -379,14 +385,14 @@ int vmbus_uio_get_subchan(struct vmbus_channel *primary,\n \t\terr = vmbus_uio_sysfs_read(subchan_path, \"monitor_id\",\n \t\t\t\t\t &monid, UINT8_MAX);\n \t\tif (err) {\n-\t\t\tVMBUS_LOG(NOTICE, \"invalid monitor id %lu\",\n-\t\t\t\t monid);\n+\t\t\tVMBUS_LOG(NOTICE, \"no monitor_id in %s:%s\",\n+\t\t\t\t subchan_path, strerror(-err));\n \t\t\tgoto fail;\n \t\t}\n \n \t\terr = vmbus_chan_create(dev, relid, subid, monid, subchan);\n \t\tif (err) {\n-\t\t\tVMBUS_LOG(NOTICE, \"subchannel setup failed\");\n+\t\t\tVMBUS_LOG(ERR, \"subchannel setup failed\");\n \t\t\tgoto fail;\n \t\t}\n \t\tbreak;\n", "prefixes": [ "v2", "4/4" ] }