Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/48510/?format=api
{ "id": 48510, "url": "http://patches.dpdk.org/api/patches/48510/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20181203162013.17310-1-i.maximets@samsung.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20181203162013.17310-1-i.maximets@samsung.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20181203162013.17310-1-i.maximets@samsung.com", "date": "2018-12-03T16:20:13", "name": "net/virtio: move bytes accounting to common function", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "88d688fdbf83cfcd89c156f5870ed14c3dea5745", "submitter": { "id": 323, "url": "http://patches.dpdk.org/api/people/323/?format=api", "name": "Ilya Maximets", "email": "i.maximets@samsung.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20181203162013.17310-1-i.maximets@samsung.com/mbox/", "series": [ { "id": 2647, "url": "http://patches.dpdk.org/api/series/2647/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=2647", "date": "2018-12-03T16:20:13", "name": "net/virtio: move bytes accounting to common function", "version": 1, "mbox": "http://patches.dpdk.org/series/2647/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/48510/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/48510/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C3D6E23D;\n\tMon, 3 Dec 2018 17:20:24 +0100 (CET)", "from mailout2.w1.samsung.com (mailout2.w1.samsung.com\n\t[210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 990AB235\n\tfor <dev@dpdk.org>; Mon, 3 Dec 2018 17:20:23 +0100 (CET)", "from eucas1p1.samsung.com (unknown [182.198.249.206])\n\tby mailout2.w1.samsung.com (KnoxPortal) with ESMTP id\n\t20181203162022euoutp02f86bd1efafe07c5fbb089bc8b2406308~s3w22IAep0141401414euoutp02k\n\tfor <dev@dpdk.org>; Mon, 3 Dec 2018 16:20:22 +0000 (GMT)", "from eusmges3new.samsung.com (unknown [203.254.199.245]) by\n\teucas1p1.samsung.com (KnoxPortal) with ESMTP id\n\t20181203162021eucas1p175ca7a5bbdc5150f4034dd626a6dd4bb~s3w2ZR8aR1239212392eucas1p1J;\n\tMon, 3 Dec 2018 16:20:21 +0000 (GMT)", "from eucas1p1.samsung.com ( [182.198.249.206]) by\n\teusmges3new.samsung.com (EUCPMTA) with SMTP id 22.43.04806.5C7550C5;\n\tMon, 3 Dec 2018 16:20:21 +0000 (GMT)", "from eusmtrp1.samsung.com (unknown [182.198.249.138]) by\n\teucas1p1.samsung.com (KnoxPortal) with ESMTPA id\n\t20181203162020eucas1p137dab9f1790df9966f73c3b296a2cbce~s3w1lqrAO2763827638eucas1p1W;\n\tMon, 3 Dec 2018 16:20:20 +0000 (GMT)", "from eusmgms1.samsung.com (unknown [182.198.249.179]) by\n\teusmtrp1.samsung.com (KnoxPortal) with ESMTP id\n\t20181203162020eusmtrp1abae78f7675227025932736eea019642~s3w1Tqim31756817568eusmtrp1M;\n\tMon, 3 Dec 2018 16:20:20 +0000 (GMT)", "from eusmtip2.samsung.com ( [203.254.199.222]) by\n\teusmgms1.samsung.com (EUCPMTA) with SMTP id B5.81.04284.4C7550C5;\n\tMon, 3 Dec 2018 16:20:20 +0000 (GMT)", "from imaximets.rnd.samsung.ru (unknown [106.109.129.180]) by\n\teusmtip2.samsung.com (KnoxPortal) with ESMTPA id\n\t20181203162020eusmtip2c01863b9ad7b8288d8cf5308fc8bc99c~s3w02U8T90404904049eusmtip21;\n\tMon, 3 Dec 2018 16:20:20 +0000 (GMT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com\n\t20181203162022euoutp02f86bd1efafe07c5fbb089bc8b2406308~s3w22IAep0141401414euoutp02k", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com;\n\ts=mail20170921; t=1543854022;\n\tbh=DNF9gXwEN9hotEuxbeyLRRcVV9fntClx2+vBGekRDGw=;\n\th=From:To:Cc:Subject:Date:References:From;\n\tb=UTWvCNwZ6GRKL/qL+MmbJGLAJAJD0FV5wH/GZOHrNl2LKs2mcBcTBGSWyF3AFBxZL\n\tVBnED+3tn6cA3L9161gg5hHu4xT4GDC2JNxO/U2qHdsNTNrzFOSX3pd1fhBcDHXNM8\n\tvceA/Vvp/k9zkD+y8HxdjRrX8PrYWxILmJXAWbtc=", "X-AuditID": "cbfec7f5-34dff700000012c6-b9-5c0557c56271", "From": "Ilya Maximets <i.maximets@samsung.com>", "To": "dev@dpdk.org", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>, Tiwei Bie\n\t<tiwei.bie@intel.com>, Zhihong Wang <zhihong.wang@intel.com>,\n\tIlya Maximets <i.maximets@samsung.com>", "Date": "Mon, 3 Dec 2018 19:20:13 +0300", "Message-Id": "<20181203162013.17310-1-i.maximets@samsung.com>", "X-Mailer": "git-send-email 2.17.1", "X-Brightmail-Tracker": [ "H4sIAAAAAAAAA+NgFnrEIsWRmVeSWpSXmKPExsWy7djPc7pHw1ljDC6/UrB492k7k8WV9p/s\n\tFsc697BYbG34z2Sx+eIkJgdWj18LlrJ6LN7zksnj/b6rbB59W1YxBrBEcdmkpOZklqUW6dsl\n\tcGXs3vaZsWAVf8XqxedZGxgv8XQxcnJICJhIfDl3k7GLkYtDSGAFo8S0M3OZIZwvjBKbd7ew\n\tQjifGSV+XZzNDtPybOUCqKrljBK3l3WxQTg/GCUeHN7GDFLFJqAjcWr1EUYQW0RAQOJz52Kw\n\tImaBJYwSB56eBUsIC7hKzJwxGcxmEVCVeNrfzQZi8wpYS0z+OJkJYp28xOoNB8DWSQgcYJM4\n\t+fgOC0TCReJVzxuoImGJV8e3QN0nI3F6cg9UTb3E/ZaXjBDNHYwS0w/9g2qwl9jy+hxQAwfQ\n\tSZoS63fpQ4QdJe4/ms8EEpYQ4JO48VYQJMwMZE7aNp0ZIswr0dEmBFGtIvH74HJmCFtK4ua7\n\tz1AXeEg0ndsJ9paQQKzEvosTmScwys1C2LWAkXEVo3hqaXFuemqxcV5quV5xYm5xaV66XnJ+\n\t7iZGYMyf/nf86w7GfX+SDjEKcDAq8fDOcGKNEWJNLCuuzD3EKMHBrCTCW1DIEiPEm5JYWZVa\n\tlB9fVJqTWnyIUZqDRUmct5rhQbSQQHpiSWp2ampBahFMlomDU6qB8fzJoBtKJUE161iflW5R\n\t+7/uc+ZaiR8GSsteOefWvTg9uyD1+VHrri3/6sTK10Zl2tyYqritJvNi2NTd0fbXjjzpPPP7\n\tqHH5fyPtJfbe7xJ/dTJvuWkgPEWpxcDZLE03U0d/34tVd2/2r86YeHEtX/+N7Kub/Rv3ZTb9\n\t7FVaLPIggq/4q4qhnBJLcUaioRZzUXEiANQXxOj1AgAA", "H4sIAAAAAAAAA+NgFtrOLMWRmVeSWpSXmKPExsVy+t/xe7pHwlljDLpPyVu8+7SdyeJK+092\n\ti2Ode1gstjb8Z7LYfHESkwOrx68FS1k9Fu95yeTxft9VNo++LasYA1ii9GyK8ktLUhUy8otL\n\tbJWiDS2M9AwtLfSMTCz1DI3NY62MTJX07WxSUnMyy1KL9O0S9DJ2b/vMWLCKv2L14vOsDYyX\n\teLoYOTkkBEwknq1cwNzFyMUhJLCUUWLJtt9sEAkpiR+/LrBC2MISf651sUEUfWOUmPxhMztI\n\tgk1AR+LU6iOMILaIgIDE587FYM3MAssYJf5tlAaxhQVcJWbOmAxWwyKgKvG0vxushlfAWmLy\n\tx8lMEAvkJVZvOMA8gZFnASPDKkaR1NLi3PTcYkO94sTc4tK8dL3k/NxNjMBA23bs5+YdjJc2\n\tBh9iFOBgVOLhneHEGiPEmlhWXJl7iFGCg1lJhLegkCVGiDclsbIqtSg/vqg0J7X4EKMp0PKJ\n\tzFKiyfnAKMgriTc0NTS3sDQ0NzY3NrNQEuc9b1AZJSSQnliSmp2aWpBaBNPHxMEp1cCoYZx2\n\td26JVKFMoI5Igts58z3zfMMXLF5U/k3++dp5pgfXvF1mHnbjQ3Li7nmyHB5XtwomxPPE2nem\n\t7Dvx7tiyb2p/DbIK3faYvfqf4pKssGm7tFLWu/zAh9Z/+18eKi35c3yHcWNysUf5isXfBKuO\n\tzPxUMnuycYfTCc4zPec+GXyLZzob4XVQiaU4I9FQi7moOBEAu6og0koCAAA=" ], "X-CMS-MailID": "20181203162020eucas1p137dab9f1790df9966f73c3b296a2cbce", "X-Msg-Generator": "CA", "Content-Type": "text/plain; charset=\"utf-8\"", "X-RootMTR": "20181203162020eucas1p137dab9f1790df9966f73c3b296a2cbce", "X-EPHeader": "CA", "CMS-TYPE": "201P", "X-CMS-RootMailID": "20181203162020eucas1p137dab9f1790df9966f73c3b296a2cbce", "References": "<CGME20181203162020eucas1p137dab9f1790df9966f73c3b296a2cbce@eucas1p1.samsung.com>", "Subject": "[dpdk-dev] [PATCH] net/virtio: move bytes accounting to common\n\tfunction", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "There is no need to count 'bytes' separately.\n\nSigned-off-by: Ilya Maximets <i.maximets@samsung.com>\n---\n drivers/net/virtio/virtio_rxtx.c | 7 ++-----\n 1 file changed, 2 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c\nindex eb891433e..cb8f89f18 100644\n--- a/drivers/net/virtio/virtio_rxtx.c\n+++ b/drivers/net/virtio/virtio_rxtx.c\n@@ -775,6 +775,8 @@ virtio_update_packet_stats(struct virtnet_stats *stats, struct rte_mbuf *mbuf)\n \tuint32_t s = mbuf->pkt_len;\n \tstruct ether_addr *ea;\n \n+\tstats->bytes += s;\n+\n \tif (s == 64) {\n \t\tstats->size_bins[1]++;\n \t} else if (s > 64 && s < 1024) {\n@@ -806,7 +808,6 @@ virtio_rx_stats_updated(struct virtnet_rx *rxvq, struct rte_mbuf *m)\n {\n \tVIRTIO_DUMP_PACKET(m, m->data_len);\n \n-\trxvq->stats.bytes += m->pkt_len;\n \tvirtio_update_packet_stats(&rxvq->stats, m);\n }\n \n@@ -1310,7 +1311,6 @@ virtio_recv_mergeable_pkts(void *rx_queue,\n \t\tVIRTIO_DUMP_PACKET(rx_pkts[nb_rx],\n \t\t\trx_pkts[nb_rx]->data_len);\n \n-\t\trxvq->stats.bytes += rx_pkts[nb_rx]->pkt_len;\n \t\tvirtio_update_packet_stats(&rxvq->stats, rx_pkts[nb_rx]);\n \t\tnb_rx++;\n \t}\n@@ -1423,7 +1423,6 @@ virtio_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)\n \t\tvirtqueue_enqueue_xmit(txvq, txm, slots, use_indirect,\n \t\t\tcan_push, 0);\n \n-\t\ttxvq->stats.bytes += txm->pkt_len;\n \t\tvirtio_update_packet_stats(&txvq->stats, txm);\n \t}\n \n@@ -1498,7 +1497,6 @@ virtio_xmit_pkts_inorder(void *tx_queue,\n \t\t\tinorder_pkts[nb_inorder_pkts] = txm;\n \t\t\tnb_inorder_pkts++;\n \n-\t\t\ttxvq->stats.bytes += txm->pkt_len;\n \t\t\tvirtio_update_packet_stats(&txvq->stats, txm);\n \t\t\tcontinue;\n \t\t}\n@@ -1529,7 +1527,6 @@ virtio_xmit_pkts_inorder(void *tx_queue,\n \t\t/* Enqueue Packet buffers */\n \t\tvirtqueue_enqueue_xmit(txvq, txm, slots, 0, 0, 1);\n \n-\t\ttxvq->stats.bytes += txm->pkt_len;\n \t\tvirtio_update_packet_stats(&txvq->stats, txm);\n \t}\n \n", "prefixes": [] }