Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/48459/?format=api
{ "id": 48459, "url": "http://patches.dpdk.org/api/patches/48459/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20181203025857.23670-1-tiwei.bie@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20181203025857.23670-1-tiwei.bie@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20181203025857.23670-1-tiwei.bie@intel.com", "date": "2018-12-03T02:58:57", "name": "pdump: remove deprecated APIs", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "66dd364d3c13c25ceb16392a8f2816d6b949fa2c", "submitter": { "id": 617, "url": "http://patches.dpdk.org/api/people/617/?format=api", "name": "Tiwei Bie", "email": "tiwei.bie@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20181203025857.23670-1-tiwei.bie@intel.com/mbox/", "series": [ { "id": 2637, "url": "http://patches.dpdk.org/api/series/2637/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=2637", "date": "2018-12-03T02:58:57", "name": "pdump: remove deprecated APIs", "version": 1, "mbox": "http://patches.dpdk.org/series/2637/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/48459/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/48459/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 76AF51B3AF;\n\tMon, 3 Dec 2018 04:01:40 +0100 (CET)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id 331181B3AD\n\tfor <dev@dpdk.org>; Mon, 3 Dec 2018 04:01:37 +0100 (CET)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t02 Dec 2018 19:01:36 -0800", "from btwcube1.sh.intel.com ([10.67.104.173])\n\tby fmsmga006.fm.intel.com with ESMTP; 02 Dec 2018 19:01:35 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.56,308,1539673200\"; d=\"scan'208\";a=\"298388609\"", "From": "Tiwei Bie <tiwei.bie@intel.com>", "To": "dev@dpdk.org", "Cc": "reshma.pattan@intel.com, john.mcnamara@intel.com,\n\tmarko.kovacevic@intel.com", "Date": "Mon, 3 Dec 2018 10:58:57 +0800", "Message-Id": "<20181203025857.23670-1-tiwei.bie@intel.com>", "X-Mailer": "git-send-email 2.14.5", "In-Reply-To": "<20181122025541.2120-1-tiwei.bie@intel.com>", "References": "<20181122025541.2120-1-tiwei.bie@intel.com>", "Subject": "[dpdk-dev] [PATCH] pdump: remove deprecated APIs", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "We already changed to use generic IPC in pdump since below commit:\n\ncommit 660098d61f57 (\"pdump: use generic multi-process channel\")\n\nThe `rte_pdump_set_socket_dir()`, the `path` parameter of\n`rte_pdump_init()` and the `enum rte_pdump_socktype` have been\ndeprecated since then. This commit removes these deprecated\nAPIs and also bumps the pdump ABI.\n\nSigned-off-by: Tiwei Bie <tiwei.bie@intel.com>\n---\nchanges:\n- update release notes;\n- minor updates in pdump_lib.rst;\n\n app/test-pmd/testpmd.c | 2 +-\n doc/guides/prog_guide/pdump_lib.rst | 18 ++++--------------\n doc/guides/rel_notes/deprecation.rst | 7 -------\n doc/guides/rel_notes/release_19_02.rst | 6 +++++-\n lib/librte_pdump/Makefile | 2 +-\n lib/librte_pdump/meson.build | 2 +-\n lib/librte_pdump/rte_pdump.c | 9 +--------\n lib/librte_pdump/rte_pdump.h | 34 +---------------------------------\n lib/librte_pdump/rte_pdump_version.map | 1 -\n 9 files changed, 14 insertions(+), 67 deletions(-)", "diff": "diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\nindex 4c75587d0..a10bc40bb 100644\n--- a/app/test-pmd/testpmd.c\n+++ b/app/test-pmd/testpmd.c\n@@ -3104,7 +3104,7 @@ main(int argc, char** argv)\n \n #ifdef RTE_LIBRTE_PDUMP\n \t/* initialize packet capture framework */\n-\trte_pdump_init(NULL);\n+\trte_pdump_init();\n #endif\n \n \tcount = 0;\ndiff --git a/doc/guides/prog_guide/pdump_lib.rst b/doc/guides/prog_guide/pdump_lib.rst\nindex ed3c15e58..2a0f1f397 100644\n--- a/doc/guides/prog_guide/pdump_lib.rst\n+++ b/doc/guides/prog_guide/pdump_lib.rst\n@@ -34,10 +34,6 @@ or disable the packet capture, and to uninitialize it:\n * ``rte_pdump_uninit()``:\n This API uninitializes the packet capture framework.\n \n-* ``rte_pdump_set_socket_dir()``:\n- This API sets the server and client socket paths.\n- Note: This API is not thread-safe.\n-\n \n Operation\n ---------\n@@ -60,8 +56,8 @@ enabling or disabling the packet capture.\n Implementation Details\n ----------------------\n \n-The library API ``rte_pdump_init()``, initializes the packet capture framework by creating the pthread and the server\n-socket. The server socket in the pthread context will be listening to the client requests to enable or disable the\n+The library API ``rte_pdump_init()``, initializes the packet capture framework by creating the pdump server by calling\n+``rte_mp_action_register()`` function. The server will listen to the client requests to enable or disable the\n packet capture.\n \n The library APIs ``rte_pdump_enable()`` and ``rte_pdump_enable_by_deviceid()`` enables the packet capture.\n@@ -79,14 +75,8 @@ capture by removing the Ethernet RX and TX callbacks for the given port or devic\n also sends the response back to the client about the status of the request that was processed. After the response is\n received from the server, the client socket is closed.\n \n-The library API ``rte_pdump_uninit()``, uninitializes the packet capture framework by closing the pthread and the\n-server socket.\n-\n-The library API ``rte_pdump_set_socket_dir()``, sets the given path as either server socket path\n-or client socket path based on the ``type`` argument of the API.\n-If the given path is ``NULL``, default path will be selected, i.e. either ``/var/run/.dpdk`` for root user or ``~/.dpdk``\n-for non root user. Clients also need to call this API to set their server socket path if the server socket\n-path is different from default path.\n+The library API ``rte_pdump_uninit()``, uninitializes the packet capture framework by calling ``rte_mp_action_unregister()``\n+function.\n \n \n Use Case: Packet Capturing\ndiff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst\nindex b48486d36..ac7fb29a7 100644\n--- a/doc/guides/rel_notes/deprecation.rst\n+++ b/doc/guides/rel_notes/deprecation.rst\n@@ -98,10 +98,3 @@ Deprecation Notices\n - The size and layout of ``rte_cryptodev_qp_conf`` and syntax of\n ``rte_cryptodev_queue_pair_setup`` will change to to allow to use\n two different mempools for crypto and device private sessions.\n-\n-* pdump: As we changed to use generic IPC, some changes in APIs and structure\n- are expected in subsequent release.\n-\n- - ``rte_pdump_set_socket_dir`` will be removed;\n- - The parameter, ``path``, of ``rte_pdump_init`` will be removed;\n- - The enum ``rte_pdump_socktype`` will be removed.\ndiff --git a/doc/guides/rel_notes/release_19_02.rst b/doc/guides/rel_notes/release_19_02.rst\nindex a94fa86a7..4710fb7b8 100644\n--- a/doc/guides/rel_notes/release_19_02.rst\n+++ b/doc/guides/rel_notes/release_19_02.rst\n@@ -83,6 +83,10 @@ API Changes\n Also, make sure to start the actual text at the margin.\n =========================================================\n \n+* pdump: The ``rte_pdump_set_socket_dir()``, the parameter ``path`` of\n+ ``rte_pdump_init()`` and enum ``rte_pdump_socktype`` were deprecated\n+ since 18.05 and are removed in this release.\n+\n \n ABI Changes\n -----------\n@@ -153,7 +157,7 @@ The libraries prepended with a plus sign were incremented in this version.\n librte_metrics.so.1\n librte_net.so.1\n librte_pci.so.1\n- librte_pdump.so.2\n+ + librte_pdump.so.3\n librte_pipeline.so.3\n librte_pmd_bnxt.so.2\n librte_pmd_bond.so.2\ndiff --git a/lib/librte_pdump/Makefile b/lib/librte_pdump/Makefile\nindex b241151dc..89593689a 100644\n--- a/lib/librte_pdump/Makefile\n+++ b/lib/librte_pdump/Makefile\n@@ -12,7 +12,7 @@ LDLIBS += -lrte_eal -lrte_mempool -lrte_mbuf -lrte_ethdev\n \n EXPORT_MAP := rte_pdump_version.map\n \n-LIBABIVER := 2\n+LIBABIVER := 3\n \n # all source are stored in SRCS-y\n SRCS-$(CONFIG_RTE_LIBRTE_PDUMP) := rte_pdump.c\ndiff --git a/lib/librte_pdump/meson.build b/lib/librte_pdump/meson.build\nindex be80904b9..b4b4f26c5 100644\n--- a/lib/librte_pdump/meson.build\n+++ b/lib/librte_pdump/meson.build\n@@ -1,7 +1,7 @@\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright(c) 2017 Intel Corporation\n \n-version = 2\n+version = 3\n sources = files('rte_pdump.c')\n headers = files('rte_pdump.h')\n allow_experimental_apis = true\ndiff --git a/lib/librte_pdump/rte_pdump.c b/lib/librte_pdump/rte_pdump.c\nindex 6c3a88581..4f38ac58b 100644\n--- a/lib/librte_pdump/rte_pdump.c\n+++ b/lib/librte_pdump/rte_pdump.c\n@@ -406,7 +406,7 @@ pdump_server(const struct rte_mp_msg *mp_msg, const void *peer)\n }\n \n int\n-rte_pdump_init(const char *path __rte_unused)\n+rte_pdump_init(void)\n {\n \treturn rte_mp_action_register(PDUMP_MP, pdump_server);\n }\n@@ -616,10 +616,3 @@ rte_pdump_disable_by_deviceid(char *device_id, uint16_t queue,\n \n \treturn ret;\n }\n-\n-int\n-rte_pdump_set_socket_dir(const char *path __rte_unused,\n-\t\t\t enum rte_pdump_socktype type __rte_unused)\n-{\n-\treturn 0;\n-}\ndiff --git a/lib/librte_pdump/rte_pdump.h b/lib/librte_pdump/rte_pdump.h\nindex 673a2b070..6b00fc17a 100644\n--- a/lib/librte_pdump/rte_pdump.h\n+++ b/lib/librte_pdump/rte_pdump.h\n@@ -29,25 +29,16 @@ enum {\n \tRTE_PDUMP_FLAG_RXTX = (RTE_PDUMP_FLAG_RX|RTE_PDUMP_FLAG_TX)\n };\n \n-enum rte_pdump_socktype {\n-\tRTE_PDUMP_SOCKET_SERVER = 1,\n-\tRTE_PDUMP_SOCKET_CLIENT = 2\n-};\n-\n /**\n * Initialize packet capturing handling\n *\n * Register the IPC action for communication with target (primary) process.\n *\n- * @param path\n- * This parameter is going to be deprecated; it was used for specifying the\n- * directory path for server socket.\n- *\n * @return\n * 0 on success, -1 on error\n */\n int\n-rte_pdump_init(const char *path);\n+rte_pdump_init(void);\n \n /**\n * Un initialize packet capturing handling\n@@ -162,29 +153,6 @@ int\n rte_pdump_disable_by_deviceid(char *device_id, uint16_t queue,\n \t\t\t\tuint32_t flags);\n \n-/**\n- * @deprecated\n- * Allows applications to set server and client socket paths.\n- * If specified path is null default path will be selected, i.e.\n- *\"/var/run/\" for root user and \"$HOME\" for non root user.\n- * Clients also need to call this API to set their server path if the\n- * server path is different from default path.\n- * This API is not thread-safe.\n- *\n- * @param path\n- * directory path for server or client socket.\n- * @param type\n- * specifies RTE_PDUMP_SOCKET_SERVER if socket path is for server.\n- * (or)\n- * specifies RTE_PDUMP_SOCKET_CLIENT if socket path is for client.\n- *\n- * @return\n- * 0 on success, -EINVAL on error\n- *\n- */\n-__rte_deprecated int\n-rte_pdump_set_socket_dir(const char *path, enum rte_pdump_socktype type);\n-\n #ifdef __cplusplus\n }\n #endif\ndiff --git a/lib/librte_pdump/rte_pdump_version.map b/lib/librte_pdump/rte_pdump_version.map\nindex edec99a41..3e744f301 100644\n--- a/lib/librte_pdump/rte_pdump_version.map\n+++ b/lib/librte_pdump/rte_pdump_version.map\n@@ -6,7 +6,6 @@ DPDK_16.07 {\n \trte_pdump_enable;\n \trte_pdump_enable_by_deviceid;\n \trte_pdump_init;\n-\trte_pdump_set_socket_dir;\n \trte_pdump_uninit;\n \n \tlocal: *;\n", "prefixes": [] }