Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/48455/?format=api
{ "id": 48455, "url": "http://patches.dpdk.org/api/patches/48455/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20181130202457.10888-1-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20181130202457.10888-1-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20181130202457.10888-1-stephen@networkplumber.org", "date": "2018-11-30T20:24:57", "name": "bus/vmbus: fix race in sub channel creation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "5e4a4f6612a8f8c5b671dd288e5fe40faa79f6ae", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20181130202457.10888-1-stephen@networkplumber.org/mbox/", "series": [ { "id": 2633, "url": "http://patches.dpdk.org/api/series/2633/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=2633", "date": "2018-11-30T20:24:57", "name": "bus/vmbus: fix race in sub channel creation", "version": 1, "mbox": "http://patches.dpdk.org/series/2633/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/48455/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/48455/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 57CB55B40;\n\tFri, 30 Nov 2018 21:25:03 +0100 (CET)", "from mail-pl1-f194.google.com (mail-pl1-f194.google.com\n\t[209.85.214.194]) by dpdk.org (Postfix) with ESMTP id 1F6EE29CB\n\tfor <dev@dpdk.org>; Fri, 30 Nov 2018 21:25:02 +0100 (CET)", "by mail-pl1-f194.google.com with SMTP id b5so3337581plr.4\n\tfor <dev@dpdk.org>; Fri, 30 Nov 2018 12:25:01 -0800 (PST)", "from xeon-e3.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\t62sm6966308pgc.61.2018.11.30.12.24.59\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 30 Nov 2018 12:25:00 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=TPL+D7cldn7h0mE+OQDNXlU78NXhib4kncWd5ogs038=;\n\tb=eGkX7QL2RgmnoUWspQ9b2v1+AZYdD0l7tKCg5eyFzCaqlGPo0+2YO2RlrqsjrZA+wk\n\trkhNufqhf8XasV5LPo8kIDANBL/oMnKFfOKJP7GSWSJsMzA7Hxc342uiuG9JR1U36z9p\n\tJeYsY3hlxH2muiLTc4pweNlo6c2mmQi1SDxP3tpo44ehQEXgk6gdmDxiNKxUfeu/uJ0W\n\tUj2zkH2KEYEh9eAlkDj7ACMB2z0Offi2BeM5Np4qB7IcjphJTPySuWqxlq7nOB70vXeI\n\tiUi5FQ7Dy5fMXLso1SunESG2joxkE9WrpMyCa6nOn9F5L7/E6A5lumDv4dSMcZOLQAaw\n\tlqhQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=TPL+D7cldn7h0mE+OQDNXlU78NXhib4kncWd5ogs038=;\n\tb=YYvX5c5t4Yy9gvrBfNKqSujpyF9BTkQ5RbiPUb3CyL/Y14hSApROOMAsFtsZMu7/BE\n\tHfR2GPgv7+qJgT0EI+BLwhoU00wUPuoiW+37GvhLDftd9HbOUhueQcvfXpK64k9B/3Ty\n\tXnOT5FfNXfarw9p36UtBUVQggTphYAfjZ15av7fkOhZiyGak8MZ8UdHTh9npz3sO99NT\n\tKDPYT/lj/Bif6WeL+zAQPK2SDv9wLC7Awcjnr+WOMU04szXB8Dp/flyxtikDLCmTaBm5\n\t9aqvVpczElmkW2zpNPjlwN6T8YwslciTbB/9JMU+QlitgBsVnJ6YkyLXwOXP1z5uSFny\n\t3eAw==", "X-Gm-Message-State": "AA+aEWaLOKl5eow4UP18Ws9IKERGrKQePjVEiSXbbvEn2w0SyGSUY8Ju\n\t8DMO5Jd8cZ/bkdIeud+AZ0cFgRZ0NTA=", "X-Google-Smtp-Source": "AFSGD/VQC+j8vrIY5A9Qvf62D3ddhxWjPJgPI4x7loar03HAL2Tx1lY2JRKtohRCdHvGGhxU33ApOQ==", "X-Received": "by 2002:a17:902:bd92:: with SMTP id\n\tq18mr7064293pls.167.1543609500799; \n\tFri, 30 Nov 2018 12:25:00 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "mgamal@redhat.com, Stephen Hemminger <stephen@networkplumber.org>,\n\tStephen Hemminger <sthemmin@microsoft.com>", "Date": "Fri, 30 Nov 2018 12:24:57 -0800", "Message-Id": "<20181130202457.10888-1-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.19.2", "In-Reply-To": "<1543575881.5400.33.camel@redhat.com>", "References": "<1543575881.5400.33.camel@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] bus/vmbus: fix race in sub channel creation", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When using multiple queues, there was a race with the kernel\nin setting up the second channel. This is do due to a kernel change\nwhiche does not allow accessing sysfs files for Hyper-V\nchannels that are not opened.\n\nThe fix is simple, just move the logic to detect not ready\nsub channels earlier in the existing loop.\n\nFixes: 831dba47bd36 (\"bus/vmbus: add Hyper-V virtual bus support\")\nReported-by:Mohammed Gamal <mgamal@redhat.com>\nSigned-off-by: Stephen Hemminger <sthemmin@microsoft.com>\n---\n drivers/bus/vmbus/linux/vmbus_uio.c | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/bus/vmbus/linux/vmbus_uio.c b/drivers/bus/vmbus/linux/vmbus_uio.c\nindex 12e97e3a420a..38df4d724ed5 100644\n--- a/drivers/bus/vmbus/linux/vmbus_uio.c\n+++ b/drivers/bus/vmbus/linux/vmbus_uio.c\n@@ -357,6 +357,12 @@ int vmbus_uio_get_subchan(struct vmbus_channel *primary,\n \t\t\tcontinue;\n \t\t}\n \n+\t\tif (!vmbus_isnew_subchannel(primary, relid))\n+\t\t\tcontinue;\t/* Already know about you */\n+\n+\t\tif (!vmbus_uio_ring_present(dev, relid))\n+\t\t\tcontinue;\t/* Ring may not be ready yet */\n+\n \t\tsnprintf(subchan_path, sizeof(subchan_path), \"%s/%lu\",\n \t\t\t chan_path, relid);\n \t\terr = vmbus_uio_sysfs_read(subchan_path, \"subchannel_id\",\n@@ -370,12 +376,6 @@ int vmbus_uio_get_subchan(struct vmbus_channel *primary,\n \t\tif (subid == 0)\n \t\t\tcontinue;\t/* skip primary channel */\n \n-\t\tif (!vmbus_isnew_subchannel(primary, relid))\n-\t\t\tcontinue;\n-\n-\t\tif (!vmbus_uio_ring_present(dev, relid))\n-\t\t\tcontinue;\t/* Ring may not be ready yet */\n-\n \t\terr = vmbus_uio_sysfs_read(subchan_path, \"monitor_id\",\n \t\t\t\t\t &monid, UINT8_MAX);\n \t\tif (err) {\n", "prefixes": [] }