Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/48200/?format=api
{ "id": 48200, "url": "http://patches.dpdk.org/api/patches/48200/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1542709592-215007-1-git-send-email-tiago.lam@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1542709592-215007-1-git-send-email-tiago.lam@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1542709592-215007-1-git-send-email-tiago.lam@intel.com", "date": "2018-11-20T10:26:29", "name": "[v2,1/3] net/af_packet: set_mtu() decrements sockaddr twice", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "1bfe35512fc7e1811dd4706e276ce49c66cadc87", "submitter": { "id": 1166, "url": "http://patches.dpdk.org/api/people/1166/?format=api", "name": "Lam, Tiago", "email": "tiago.lam@intel.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1542709592-215007-1-git-send-email-tiago.lam@intel.com/mbox/", "series": [ { "id": 2498, "url": "http://patches.dpdk.org/api/series/2498/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=2498", "date": "2018-11-20T10:26:29", "name": "[v2,1/3] net/af_packet: set_mtu() decrements sockaddr twice", "version": 2, "mbox": "http://patches.dpdk.org/series/2498/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/48200/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/48200/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 14BA72BD5;\n\tTue, 20 Nov 2018 11:26:50 +0100 (CET)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id C08AD1D7\n\tfor <dev@dpdk.org>; Tue, 20 Nov 2018 11:26:47 +0100 (CET)", "from orsmga007.jf.intel.com ([10.7.209.58])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t20 Nov 2018 02:26:46 -0800", "from silpixa00399125.ir.intel.com ([10.237.223.34])\n\tby orsmga007.jf.intel.com with ESMTP; 20 Nov 2018 02:26:44 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.56,256,1539673200\"; d=\"scan'208\";a=\"90712025\"", "From": "Tiago Lam <tiago.lam@intel.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, linville@tuxdriver.com,\n\tTiago Lam <tiago.lam@intel.com>", "Date": "Tue, 20 Nov 2018 10:26:29 +0000", "Message-Id": "<1542709592-215007-1-git-send-email-tiago.lam@intel.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1542707697-175836-1-git-send-email-tiago.lam@intel.com>", "References": "<1542707697-175836-1-git-send-email-tiago.lam@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 1/3] net/af_packet: set_mtu() decrements\n\tsockaddr twice", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When setting the MTU, eth_dev_mtu_set() is called to validate the\nprovided MTU. As part of that, it calculates the useful area to store\ndata and compares it against the MTU, to guarantee that there's enough\nspace to store the data. It calculates that as:\n \"tp_frame_size - TPACKET2_HDRLEN - sizeof(struct sockaddr_ll)\"\n\nHowever, the TPACKET2_HDRLEN macro already increaments sizeof(struct\nsockaddr_ll) internally, meaning the useuful area of data above will\nhave sizeof(struct sockaddr_ll) decremented twice.\n\nInstead, the useful area of data should be calculated as:\n \"tp_frame_size - TPACKET2_HDRLEN\"\n\nThis makes sure that there's enough useful area to fit the provided MTU\nafter excluding tpacket2_hdr and sockaddr_ll.\n\nFixes: cc68ac4 (\"net/af_packet: support MTU change\")\n\nSigned-off-by: Tiago Lam <tiago.lam@intel.com>\n---\n drivers/net/af_packet/rte_eth_af_packet.c | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c\nindex 95a98c6..264cfc0 100644\n--- a/drivers/net/af_packet/rte_eth_af_packet.c\n+++ b/drivers/net/af_packet/rte_eth_af_packet.c\n@@ -433,8 +433,7 @@ eth_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)\n \tint ret;\n \tint s;\n \tunsigned int data_size = internals->req.tp_frame_size -\n-\t\t\t\t TPACKET2_HDRLEN -\n-\t\t\t\t sizeof(struct sockaddr_ll);\n+\t\t\t\t TPACKET2_HDRLEN;\n \n \tif (mtu > data_size)\n \t\treturn -EINVAL;\n", "prefixes": [ "v2", "1/3" ] }