Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/48175/?format=api
http://patches.dpdk.org/api/patches/48175/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20181118212914.29280-1-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20181118212914.29280-1-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20181118212914.29280-1-thomas@monjalon.net", "date": "2018-11-18T21:29:14", "name": "vfio: fix build with Linux < 4.0", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "77d669805cddfa2cf1cf7006d97c676f4cc0049b", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20181118212914.29280-1-thomas@monjalon.net/mbox/", "series": [ { "id": 2478, "url": "http://patches.dpdk.org/api/series/2478/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=2478", "date": "2018-11-18T21:29:14", "name": "vfio: fix build with Linux < 4.0", "version": 1, "mbox": "http://patches.dpdk.org/series/2478/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/48175/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/48175/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 790424C8F;\n\tSun, 18 Nov 2018 22:29:22 +0100 (CET)", "from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com\n\t[66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 6C596322C\n\tfor <dev@dpdk.org>; Sun, 18 Nov 2018 22:29:20 +0100 (CET)", "from compute1.internal (compute1.nyi.internal [10.202.2.41])\n\tby mailout.nyi.internal (Postfix) with ESMTP id E9C79213CA;\n\tSun, 18 Nov 2018 16:29:19 -0500 (EST)", "from mailfrontend2 ([10.202.2.163])\n\tby compute1.internal (MEProxy); Sun, 18 Nov 2018 16:29:19 -0500", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id CEC02102F9;\n\tSun, 18 Nov 2018 16:29:18 -0500 (EST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n\tfrom:to:cc:subject:date:message-id:mime-version:content-type\n\t:content-transfer-encoding; s=mesmtp; bh=Dykm17wQzjx9dTwtmgjfp8+\n\tvaRbq5sy9vuYP6FiCpQQ=; b=q0fh05CqIglKQ1pVN7OfYPfTvpvn7U7DMZz1pca\n\tzVpmcq00yihKHI77jpbfK4Q3OpGVeGoCXpX50a89gKovFbVuI6pZ6MbaZHjd1Hq+\n\tVtNt+/LseAk3eT/L3FH9BC+193TEK71ywW5P/Qawbk+EGsJh7xcUS/C7OhFJhVd4\n\tjqlE=", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:content-transfer-encoding:content-type\n\t:date:from:message-id:mime-version:subject:to:x-me-proxy\n\t:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=Dykm17\n\twQzjx9dTwtmgjfp8+vaRbq5sy9vuYP6FiCpQQ=; b=JJr/7Bzek3UZYcifyYij8w\n\tzXabXCbmq7QtKJu+nGZswJr7xhCEslKscAeswab5KGrBr19YV3ve53f4Qsj90wvW\n\tQemrfKFvLt7UfqDyUII08Tti8cXyJq5cNWVcA+VgMvNWMS/KVWVWEFekOoX83yAV\n\tcye4LqjCqJb37XXthTKXOT2tekbtEEBEfNLRjaC3wiD122OTO32umfQP+E+TgtwW\n\txbRlXPDAjEdeBqt2KbaEd9beDOC8+vtJzoO2XNacRR8iCRlYEb+qpTPRKhdRYrjh\n\tOC8h3brTW5yLBcwjFiGdEfS5a4BQVBx82FgKbJ9eHjPVol8kJnavxQxgzTAxt9YA\n\t==" ], "X-ME-Sender": "<xms:r9nxWyrCh6B2NS0pWgWUbjnf2ixkvxzwUyRPR-PASy6AUIpssKHdIQ>", "X-ME-Proxy": "<xmx:r9nxWx9icFeoVFFn-zQpwWkVENw0IuEK9yHn4XsijeIQZjWO3SrwTw>\n\t<xmx:r9nxWw7flFmufUsftbGnTcUHWHJAe_ct3vFCxwzfr6EL5muarCbPAg>\n\t<xmx:r9nxWy0L6uXXphIy0WLGNlICrkE5gxsHZSsJvCM9wzMBsg6FK8rK3g>\n\t<xmx:r9nxW_w12lzo0qpDtJZS9j7jenyerxVrtBqVQ3Fu2YdnF_uhNg4MgQ>\n\t<xmx:r9nxWzkuO48ChPafo955_VQBNa2BV7Yb9QfbiKw-p4k_4-SaOAmNRA>\n\t<xmx:r9nxW2VoQwHW5HfMmrC3KI-Qv_RUsTciOVfQ8y1ZiV8Kcw99Prh0dA>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "anatoly.burakov@intel.com,\n\tjia.guo@intel.com", "Date": "Sun, 18 Nov 2018 22:29:14 +0100", "Message-Id": "<20181118212914.29280-1-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.19.0", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] vfio: fix build with Linux < 4.0", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "drivers/bus/pci/linux/pci_vfio.c:45:23: error:\n‘failure_handle_lock’ defined but not used\n\nFixes: 8ffe73865124 (\"vfio: add lock for hot-unplug failure handler\")\nCc: jia.guo@intel.com\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n\nApplied immediately.\n\n---\n drivers/bus/pci/linux/pci_vfio.c | 16 ++++++++--------\n 1 file changed, 8 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/bus/pci/linux/pci_vfio.c b/drivers/bus/pci/linux/pci_vfio.c\nindex d2c84106f..ffd26f195 100644\n--- a/drivers/bus/pci/linux/pci_vfio.c\n+++ b/drivers/bus/pci/linux/pci_vfio.c\n@@ -36,14 +36,6 @@\n * This file is only compiled if CONFIG_RTE_EAL_VFIO is set to \"y\".\n */\n \n-/*\n- * spinlock for device hot-unplug failure handling. If it try to access bus or\n- * device, such as handle sigbus on bus or handle memory failure for device\n- * just need to use this lock. It could protect the bus and the device to avoid\n- * race condition.\n- */\n-static rte_spinlock_t failure_handle_lock = RTE_SPINLOCK_INITIALIZER;\n-\n #ifdef VFIO_PRESENT\n \n #ifndef PAGE_SIZE\n@@ -291,6 +283,14 @@ pci_vfio_setup_interrupts(struct rte_pci_device *dev, int vfio_dev_fd)\n }\n \n #ifdef HAVE_VFIO_DEV_REQ_INTERFACE\n+/*\n+ * Spinlock for device hot-unplug failure handling.\n+ * If it tries to access bus or device, such as handle sigbus on bus\n+ * or handle memory failure for device, just need to use this lock.\n+ * It could protect the bus and the device to avoid race condition.\n+ */\n+static rte_spinlock_t failure_handle_lock = RTE_SPINLOCK_INITIALIZER;\n+\n static void\n pci_vfio_req_handler(void *param)\n {\n", "prefixes": [] }{ "id": 48175, "url": "