Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 48071,
    "url": "http://patches.dpdk.org/api/patches/48071/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20181114115859.160722-1-jasvinder.singh@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20181114115859.160722-1-jasvinder.singh@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20181114115859.160722-1-jasvinder.singh@intel.com",
    "date": "2018-11-14T11:58:59",
    "name": "testpmd: fix memory leak for dscp table",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "0b13203a476a61d9647b56735607792915b689ee",
    "submitter": {
        "id": 285,
        "url": "http://patches.dpdk.org/api/people/285/?format=api",
        "name": "Jasvinder Singh",
        "email": "jasvinder.singh@intel.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20181114115859.160722-1-jasvinder.singh@intel.com/mbox/",
    "series": [
        {
            "id": 2412,
            "url": "http://patches.dpdk.org/api/series/2412/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=2412",
            "date": "2018-11-14T11:58:59",
            "name": "testpmd: fix memory leak for dscp table",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/2412/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/48071/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/48071/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D6AE16904;\n\tWed, 14 Nov 2018 12:59:05 +0100 (CET)",
            "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id 439615F27;\n\tWed, 14 Nov 2018 12:59:02 +0100 (CET)",
            "from orsmga006.jf.intel.com ([10.7.209.51])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t14 Nov 2018 03:59:01 -0800",
            "from silpixa00381635.ir.intel.com (HELO\n\tsilpixa00381635.ger.corp.intel.com) ([10.237.222.149])\n\tby orsmga006.jf.intel.com with ESMTP; 14 Nov 2018 03:58:59 -0800"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.56,232,1539673200\"; d=\"scan'208\";a=\"91033549\"",
        "From": "Jasvinder Singh <jasvinder.singh@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "stable@dpdk.org, bernard.iremonger@intel.com, jingjing.wu@intel.com,\n\twenzhuo.lu@intel.com",
        "Date": "Wed, 14 Nov 2018 11:58:59 +0000",
        "Message-Id": "<20181114115859.160722-1-jasvinder.singh@intel.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "Subject": "[dpdk-dev] [PATCH] testpmd: fix memory leak for dscp table",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Fix memory leak for dscp table reported by coverity\n\nCoverity ID: 326961\nFixes: 281eeb8afc55 (\"app/testpmd: add commands for metering and policing\")\nCC: stable@dpdk.org\n\nSigned-off-by: Jasvinder Singh <jasvinder.singh@intel.com>\n---\n app/test-pmd/cmdline_mtr.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)",
    "diff": "diff --git a/app/test-pmd/cmdline_mtr.c b/app/test-pmd/cmdline_mtr.c\nindex 846de88db..c506d87ee 100644\n--- a/app/test-pmd/cmdline_mtr.c\n+++ b/app/test-pmd/cmdline_mtr.c\n@@ -1148,15 +1148,15 @@ static void cmd_set_port_meter_dscp_table_parsed(void *parsed_result,\n \t}\n \n \tif (port_id_is_invalid(port_id, ENABLED_WARN))\n-\t\treturn;\n+\t\tgoto free_table;\n \n \t/* Update Meter DSCP Table*/\n \tret = rte_mtr_meter_dscp_table_update(port_id, mtr_id,\n \t\tdscp_table, &error);\n-\tif (ret != 0) {\n+\tif (ret != 0)\n \t\tprint_err_msg(&error);\n-\t\treturn;\n-\t}\n+\n+free_table:\n \tfree(dscp_table);\n }\n \n",
    "prefixes": []
}