Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 4804,
    "url": "http://patches.dpdk.org/api/patches/4804/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1432031834-12042-1-git-send-email-thomas.monjalon@6wind.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1432031834-12042-1-git-send-email-thomas.monjalon@6wind.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1432031834-12042-1-git-send-email-thomas.monjalon@6wind.com",
    "date": "2015-05-19T10:37:14",
    "name": "[dpdk-dev] examples/ip_pipeline: fix build with clang 3.6",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "ce68041ed5274d5df144638c7ed84f53a4414f90",
    "submitter": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/people/1/?format=api",
        "name": "Thomas Monjalon",
        "email": "thomas.monjalon@6wind.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1432031834-12042-1-git-send-email-thomas.monjalon@6wind.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/4804/comments/",
    "check": "pending",
    "checks": "http://patches.dpdk.org/api/patches/4804/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id E22C4C324;\n\tTue, 19 May 2015 12:38:02 +0200 (CEST)",
            "from mail-wi0-f177.google.com (mail-wi0-f177.google.com\n\t[209.85.212.177]) by dpdk.org (Postfix) with ESMTP id AFDFEC320\n\tfor <dev@dpdk.org>; Tue, 19 May 2015 12:38:01 +0200 (CEST)",
            "by wizk4 with SMTP id k4so111858108wiz.1\n\tfor <dev@dpdk.org>; Tue, 19 May 2015 03:38:01 -0700 (PDT)",
            "from XPS13.nsn-net.net ([62.159.77.186])\n\tby mx.google.com with ESMTPSA id\n\tex2sm21148490wjd.28.2015.05.19.03.38.00 for <dev@dpdk.org>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tTue, 19 May 2015 03:38:00 -0700 (PDT)"
        ],
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:subject:date:message-id;\n\tbh=uCrnJQBizuhDb6ZfRpdpoiS7GBXddgsYK2Dw3cSbmFs=;\n\tb=UVQmnQxVOU7yWAL7P4a77Nsy9kRryFdnUvh5SqOAbaxoyvBl7T491qamE3+BW75M1s\n\t9gRPrWJqsVLtBq+ZhE5E7vGBiC5lZ7dyAAZttF2J/4iJic1FmU+mtqvH9uELHbcXcEfr\n\tR7iSXByZJMxiEvO53EM2ZSDSgdEajk4/Iuz/gGN4NrLPCtB6wNBhrv9dp0UX4apMa0Qx\n\tWTubrD6B8G55X8QpiWWOrYHRDJ4yyfOLe7mJSaI35aqQknwCfaCzj5h3lIAFm+XTj3j2\n\tnQEAaEm2XnqIjNsZ9/XZ8sOJ8AQol9TX/CvUpm/YpvEEKDyVPCawf0tB+XBoBEI0oOaB\n\tbKwA==",
        "X-Gm-Message-State": "ALoCoQlm611+ktfT+GAJ8urv9//QgiEyVNin/bWPIGv7BZ+4hGinSS82oQsntvstKoGjG0e59TrD",
        "X-Received": "by 10.180.73.230 with SMTP id o6mr30984962wiv.11.1432031881432; \n\tTue, 19 May 2015 03:38:01 -0700 (PDT)",
        "From": "Thomas Monjalon <thomas.monjalon@6wind.com>",
        "To": "dev@dpdk.org",
        "Date": "Tue, 19 May 2015 12:37:14 +0200",
        "Message-Id": "<1432031834-12042-1-git-send-email-thomas.monjalon@6wind.com>",
        "X-Mailer": "git-send-email 2.4.0",
        "Subject": "[dpdk-dev] [PATCH] examples/ip_pipeline: fix build with clang 3.6",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "This error is detected:\n    examples/ip_pipeline/cmdline.c:272:15: error: address of array\n          'params->file_path' will always evaluate to 'true'\n            if (!params->file_path) {\n                ~~~~~~~~~^~~~~~~~~\n\nfile_path is an array in a structure so it's unneeded to check it.\n\nSigned-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>\n---\n examples/ip_pipeline/cmdline.c | 6 ------\n 1 file changed, 6 deletions(-)",
    "diff": "diff --git a/examples/ip_pipeline/cmdline.c b/examples/ip_pipeline/cmdline.c\nindex 152acb5..3173fd0 100644\n--- a/examples/ip_pipeline/cmdline.c\n+++ b/examples/ip_pipeline/cmdline.c\n@@ -268,12 +268,6 @@ cmd_run_file_parsed(\n \tstruct cmdline *file_cl;\n \tint fd;\n \n-\t/* Check params */\n-\tif (!params->file_path) {\n-\t\tprintf(\"Illegal value for file path (%s)\\n\", params->file_path);\n-\t\treturn;\n-\t}\n-\n \tfd = open(params->file_path, O_RDONLY, 0);\n \tif (fd < 0) {\n \t\tprintf(\"Illegal value for file path (%s)\\n\", params->file_path);\n",
    "prefixes": [
        "dpdk-dev"
    ]
}