Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/47918/?format=api
{ "id": 47918, "url": "http://patches.dpdk.org/api/patches/47918/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20181107090102.9364-2-tiwei.bie@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20181107090102.9364-2-tiwei.bie@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20181107090102.9364-2-tiwei.bie@intel.com", "date": "2018-11-07T09:01:01", "name": "[1/2] net/virtio: fix unchecked return value", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d08e6610c1aefb534c7a52c526065912da6cc253", "submitter": { "id": 617, "url": "http://patches.dpdk.org/api/people/617/?format=api", "name": "Tiwei Bie", "email": "tiwei.bie@intel.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20181107090102.9364-2-tiwei.bie@intel.com/mbox/", "series": [ { "id": 2307, "url": "http://patches.dpdk.org/api/series/2307/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=2307", "date": "2018-11-07T09:01:00", "name": "Fix Coverity issues for virtio-pci and vhost-user msg", "version": 1, "mbox": "http://patches.dpdk.org/series/2307/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/47918/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/47918/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 76FC8378B;\n\tWed, 7 Nov 2018 10:02:45 +0100 (CET)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id 4FB1014EC\n\tfor <dev@dpdk.org>; Wed, 7 Nov 2018 10:02:42 +0100 (CET)", "from orsmga004.jf.intel.com ([10.7.209.38])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t07 Nov 2018 01:02:41 -0800", "from btwcube1.sh.intel.com ([10.67.104.173])\n\tby orsmga004.jf.intel.com with ESMTP; 07 Nov 2018 01:02:40 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.54,475,1534834800\"; d=\"scan'208\";a=\"247689878\"", "From": "Tiwei Bie <tiwei.bie@intel.com>", "To": "maxime.coquelin@redhat.com,\n\tzhihong.wang@intel.com,\n\tdev@dpdk.org", "Date": "Wed, 7 Nov 2018 17:01:01 +0800", "Message-Id": "<20181107090102.9364-2-tiwei.bie@intel.com>", "X-Mailer": "git-send-email 2.19.1", "In-Reply-To": "<20181107090102.9364-1-tiwei.bie@intel.com>", "References": "<20181107090102.9364-1-tiwei.bie@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 1/2] net/virtio: fix unchecked return value", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Coverity issue: 302861\nFixes: 6ba1f63b5ab0 (\"virtio: support specification 1.0\")\n\nSigned-off-by: Tiwei Bie <tiwei.bie@intel.com>\n---\nThis patch can't be backported because it depends on the\nAPI change introduced by below commit in this release.\n\ncommit e8d435f1f3a1 (\"bus/pci: harmonize return value of config read\")\n\n drivers/net/virtio/virtio_pci.c | 10 ++++++++--\n 1 file changed, 8 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/virtio/virtio_pci.c b/drivers/net/virtio/virtio_pci.c\nindex 21110cd69..c8883c32e 100644\n--- a/drivers/net/virtio/virtio_pci.c\n+++ b/drivers/net/virtio/virtio_pci.c\n@@ -614,9 +614,15 @@ virtio_read_caps(struct rte_pci_device *dev, struct virtio_hw *hw)\n \t\t\thw->common_cfg = get_cfg_addr(dev, &cap);\n \t\t\tbreak;\n \t\tcase VIRTIO_PCI_CAP_NOTIFY_CFG:\n-\t\t\trte_pci_read_config(dev, &hw->notify_off_multiplier,\n+\t\t\tret = rte_pci_read_config(dev,\n+\t\t\t\t\t&hw->notify_off_multiplier,\n \t\t\t\t\t4, pos + sizeof(cap));\n-\t\t\thw->notify_base = get_cfg_addr(dev, &cap);\n+\t\t\tif (ret != 4)\n+\t\t\t\tPMD_INIT_LOG(DEBUG,\n+\t\t\t\t\t\"failed to read notify_off_multiplier, ret %d\",\n+\t\t\t\t\tret);\n+\t\t\telse\n+\t\t\t\thw->notify_base = get_cfg_addr(dev, &cap);\n \t\t\tbreak;\n \t\tcase VIRTIO_PCI_CAP_DEVICE_CFG:\n \t\t\thw->dev_cfg = get_cfg_addr(dev, &cap);\n", "prefixes": [ "1/2" ] }