Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/47876/?format=api
{ "id": 47876, "url": "http://patches.dpdk.org/api/patches/47876/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1541484436-91320-4-git-send-email-jia.guo@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1541484436-91320-4-git-send-email-jia.guo@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1541484436-91320-4-git-send-email-jia.guo@intel.com", "date": "2018-11-06T06:07:15", "name": "[3/3] app/testpmd: fix callback issue for hot-unplug", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "15df840efa66a0ba76f67ff0daf67709f011e0f0", "submitter": { "id": 507, "url": "http://patches.dpdk.org/api/people/507/?format=api", "name": "Guo, Jia", "email": "jia.guo@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1541484436-91320-4-git-send-email-jia.guo@intel.com/mbox/", "series": [ { "id": 2286, "url": "http://patches.dpdk.org/api/series/2286/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=2286", "date": "2018-11-06T06:07:12", "name": "fix vfio hot-unplug issue", "version": 1, "mbox": "http://patches.dpdk.org/series/2286/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/47876/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/47876/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9A73E4CE4;\n\tTue, 6 Nov 2018 07:03:47 +0100 (CET)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id 367134CA5\n\tfor <dev@dpdk.org>; Tue, 6 Nov 2018 07:03:46 +0100 (CET)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t05 Nov 2018 22:03:45 -0800", "from jeffguo-s2600wt2.sh.intel.com (HELO localhost.localdomain)\n\t([10.67.110.10])\n\tby fmsmga005.fm.intel.com with ESMTP; 05 Nov 2018 22:03:43 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.54,470,1534834800\"; d=\"scan'208\";a=\"277430835\"", "From": "Jeff Guo <jia.guo@intel.com>", "To": "konstantin.ananyev@intel.com, anatoly.burakov@intel.com,\n\tthomas@monjalon.net, bernard.iremonger@intel.com, jingjing.wu@intel.com, \n\twenzhuo.lu@intel.com", "Cc": "ferruh.yigit@intel.com, dev@dpdk.org, jia.guo@intel.com,\n\thelin.zhang@intel.com, matan@mellanox.com, shaopeng.he@intel.com", "Date": "Tue, 6 Nov 2018 14:07:15 +0800", "Message-Id": "<1541484436-91320-4-git-send-email-jia.guo@intel.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1541484436-91320-1-git-send-email-jia.guo@intel.com>", "References": "<1541484436-91320-1-git-send-email-jia.guo@intel.com>", "Subject": "[dpdk-dev] [PATCH 3/3] app/testpmd: fix callback issue for\n\thot-unplug", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Before detach device when device be hot-unplugged, the failure process\nin user space and kernel space both need to be finished, such as eal\ninterrupt callback need to be inactive before the callback be unregistered\nwhen device is being cleaned. This patch add rte alarm for device\ndetaching, with that it could finish interrupt callback soon and\ngive time to let the failure process done before detaching.\n\nFixes: 2049c5113fe8 (\"app/testpmd: use hotplug failure handler\")\nSigned-off-by: Jeff Guo <jia.guo@intel.com>\n---\n app/test-pmd/testpmd.c | 13 ++++++++++++-\n 1 file changed, 12 insertions(+), 1 deletion(-)", "diff": "diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\nindex 9c0edca..9c673cf 100644\n--- a/app/test-pmd/testpmd.c\n+++ b/app/test-pmd/testpmd.c\n@@ -2620,7 +2620,18 @@ eth_dev_event_callback(const char *device_name, enum rte_dev_event_type type,\n \t\t\t\tdevice_name);\n \t\t\treturn;\n \t\t}\n-\t\trmv_event_callback((void *)(intptr_t)port_id);\n+\t\t/*\n+\t\t * Before detach device, the hot-unplug failure process in\n+\t\t * user space and kernel space both need to be finished,\n+\t\t * such as eal interrupt callback need to be inactive before\n+\t\t * the callback be unregistered when device is being cleaned.\n+\t\t * So finished interrupt callback soon here and give time to\n+\t\t * let the work done before detaching.\n+\t\t */\n+\t\tif (rte_eal_alarm_set(100000,\n+\t\t\t\trmv_event_callback, (void *)(intptr_t)port_id))\n+\t\t\tRTE_LOG(ERR, EAL,\n+\t\t\t\t\"Could not set up deferred device removal\\n\");\n \t\tbreak;\n \tcase RTE_DEV_EVENT_ADD:\n \t\tRTE_LOG(ERR, EAL, \"The device: %s has been added!\\n\",\n", "prefixes": [ "3/3" ] }