Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/47826/?format=api
{ "id": 47826, "url": "http://patches.dpdk.org/api/patches/47826/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20181105173913.61225-2-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20181105173913.61225-2-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20181105173913.61225-2-bruce.richardson@intel.com", "date": "2018-11-05T17:39:10", "name": "[1/4] hash: fix TSX aborts with newer gcc", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "09e4e70902468e5c76aa37682d9cd0e46401a009", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20181105173913.61225-2-bruce.richardson@intel.com/mbox/", "series": [ { "id": 2267, "url": "http://patches.dpdk.org/api/series/2267/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=2267", "date": "2018-11-05T17:39:09", "name": "fixes for rte_hash with TSX", "version": 1, "mbox": "http://patches.dpdk.org/series/2267/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/47826/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/47826/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4195A532C;\n\tMon, 5 Nov 2018 18:39:33 +0100 (CET)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id 1FA544CB5;\n\tMon, 5 Nov 2018 18:39:30 +0100 (CET)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t05 Nov 2018 09:39:30 -0800", "from silpixa00399126.ir.intel.com (HELO\n\tsilpixa00399126.ger.corp.intel.com) ([10.237.223.223])\n\tby fmsmga006.fm.intel.com with ESMTP; 05 Nov 2018 09:39:28 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.54,468,1534834800\"; d=\"scan'208\";a=\"278500695\"", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Yipeng Wang <yipeng1.wang@intel.com>, stable@dpdk.org,\n\tBruce Richardson <bruce.richardson@intel.com>", "Date": "Mon, 5 Nov 2018 17:39:10 +0000", "Message-Id": "<20181105173913.61225-2-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.19.1", "In-Reply-To": "<20181105173913.61225-1-bruce.richardson@intel.com>", "References": "<20181105173913.61225-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 1/4] hash: fix TSX aborts with newer gcc", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Yipeng Wang <yipeng1.wang@intel.com>\n\ngcc 7 and 8 with O3 will generate vzeroupper from rte_memcpy\ninto TSX region which may abort the TSX transaction.\n\nThis fix changes rte_memcpy to memcpy which will not insert\nextra vzeroupper into the library.\n\nFixes: f2e3001b53ec (\"hash: support read/write concurrency\")\nCc: stable@dpdk.org\n\nSigned-off-by: Yipeng Wang <yipeng1.wang@intel.com>\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n lib/librte_hash/rte_cmp_x86.h | 2 ++\n lib/librte_hash/rte_cuckoo_hash.c | 3 +--\n 2 files changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/librte_hash/rte_cmp_x86.h b/lib/librte_hash/rte_cmp_x86.h\nindex e82b4c0..13a5836 100644\n--- a/lib/librte_hash/rte_cmp_x86.h\n+++ b/lib/librte_hash/rte_cmp_x86.h\n@@ -2,6 +2,8 @@\n * Copyright(c) 2015 Intel Corporation\n */\n \n+#include <rte_vect.h>\n+\n /* Functions to compare multiple of 16 byte keys (up to 128 bytes) */\n static int\n rte_hash_k16_cmp_eq(const void *key1, const void *key2, size_t key_len __rte_unused)\ndiff --git a/lib/librte_hash/rte_cuckoo_hash.c b/lib/librte_hash/rte_cuckoo_hash.c\nindex 5ddcccd..76f5dc8 100644\n--- a/lib/librte_hash/rte_cuckoo_hash.c\n+++ b/lib/librte_hash/rte_cuckoo_hash.c\n@@ -13,7 +13,6 @@\n #include <rte_common.h>\n #include <rte_memory.h> /* for definition of RTE_CACHE_LINE_SIZE */\n #include <rte_log.h>\n-#include <rte_memcpy.h>\n #include <rte_prefetch.h>\n #include <rte_branch_prediction.h>\n #include <rte_malloc.h>\n@@ -982,7 +981,7 @@ struct rte_hash *\n \tnew_k = RTE_PTR_ADD(keys, (uintptr_t)slot_id * h->key_entry_size);\n \tnew_idx = (uint32_t)((uintptr_t) slot_id);\n \t/* Copy key */\n-\trte_memcpy(new_k->key, key, h->key_len);\n+\tmemcpy(new_k->key, key, h->key_len);\n \t/* Key can be of arbitrary length, so it is not possible to store\n \t * it atomically. Hence the new key element's memory stores\n \t * (key as well as data) should be complete before it is referenced.\n", "prefixes": [ "1/4" ] }