Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/47743/?format=api
{ "id": 47743, "url": "http://patches.dpdk.org/api/patches/47743/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1541158623-29742-9-git-send-email-cristian.dumitrescu@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1541158623-29742-9-git-send-email-cristian.dumitrescu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1541158623-29742-9-git-send-email-cristian.dumitrescu@intel.com", "date": "2018-11-02T11:37:00", "name": "[09/12] examples/ip_pipeline: support rule TTL stats read", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "0a291758f0df21d9973be42b703420580a1c9930", "submitter": { "id": 19, "url": "http://patches.dpdk.org/api/people/19/?format=api", "name": "Cristian Dumitrescu", "email": "cristian.dumitrescu@intel.com" }, "delegate": { "id": 10018, "url": "http://patches.dpdk.org/api/users/10018/?format=api", "username": "cristian_dumitrescu", "first_name": "Cristian", "last_name": "Dumitrescu", "email": "cristian.dumitrescu@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1541158623-29742-9-git-send-email-cristian.dumitrescu@intel.com/mbox/", "series": [ { "id": 2226, "url": "http://patches.dpdk.org/api/series/2226/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=2226", "date": "2018-11-02T11:36:52", "name": "[01/12] examples/ip_pipeline: add rule list per table", "version": 1, "mbox": "http://patches.dpdk.org/series/2226/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/47743/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/47743/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 896821B469;\n\tFri, 2 Nov 2018 12:37:21 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 250621B452\n\tfor <dev@dpdk.org>; Fri, 2 Nov 2018 12:37:15 +0100 (CET)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t02 Nov 2018 04:37:14 -0700", "from silpixa00382658.ir.intel.com ([10.237.223.29])\n\tby orsmga002.jf.intel.com with ESMTP; 02 Nov 2018 04:37:14 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.54,455,1534834800\"; d=\"scan'208\";a=\"105381806\"", "From": "Cristian Dumitrescu <cristian.dumitrescu@intel.com>", "To": "dev@dpdk.org", "Cc": "Jasvinder Singh <jasvinder.singh@intel.com>", "Date": "Fri, 2 Nov 2018 11:37:00 +0000", "Message-Id": "<1541158623-29742-9-git-send-email-cristian.dumitrescu@intel.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1541158623-29742-1-git-send-email-cristian.dumitrescu@intel.com>", "References": "<1541158623-29742-1-git-send-email-cristian.dumitrescu@intel.com>", "Subject": "[dpdk-dev] [PATCH 09/12] examples/ip_pipeline: support rule TTL\n\tstats read", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add support for the table rule TTL stats read operation.\n\nSigned-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>\nSigned-off-by: Jasvinder Singh <jasvinder.singh@intel.com>\n---\n examples/ip_pipeline/cli.c | 91 +++++++++++++++++++++++++++++++++++++++--\n examples/ip_pipeline/pipeline.h | 2 +-\n examples/ip_pipeline/thread.c | 27 ++++++++----\n 3 files changed, 107 insertions(+), 13 deletions(-)", "diff": "diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c\nindex 78539d1..6561152 100644\n--- a/examples/ip_pipeline/cli.c\n+++ b/examples/ip_pipeline/cli.c\n@@ -5311,15 +5311,100 @@ cmd_pipeline_table_dscp(char **tokens,\n \n \n static const char cmd_pipeline_table_rule_ttl_read_help[] =\n-\"pipeline <pipeline_name> table <table_id> rule read ttl [clear]\\n\";\n+\"pipeline <pipeline_name> table <table_id> rule read ttl [clear]\\n\"\n+\" match <match>\\n\";\n \n static void\n cmd_pipeline_table_rule_ttl_read(char **tokens,\n-\tuint32_t n_tokens __rte_unused,\n+\tuint32_t n_tokens,\n \tchar *out,\n \tsize_t out_size)\n {\n-\tsnprintf(out, out_size, MSG_CMD_UNIMPLEM, tokens[0]);\n+\tstruct table_rule_match m;\n+\tstruct rte_table_action_ttl_counters stats;\n+\tchar *pipeline_name;\n+\tuint32_t table_id, n_tokens_parsed;\n+\tint clear = 0, status;\n+\n+\tif (n_tokens < 7) {\n+\t\tsnprintf(out, out_size, MSG_ARG_MISMATCH, tokens[0]);\n+\t\treturn;\n+\t}\n+\n+\tpipeline_name = tokens[1];\n+\n+\tif (strcmp(tokens[2], \"table\") != 0) {\n+\t\tsnprintf(out, out_size, MSG_ARG_NOT_FOUND, \"table\");\n+\t\treturn;\n+\t}\n+\n+\tif (parser_read_uint32(&table_id, tokens[3]) != 0) {\n+\t\tsnprintf(out, out_size, MSG_ARG_INVALID, \"table_id\");\n+\t\treturn;\n+\t}\n+\n+\tif (strcmp(tokens[4], \"rule\") != 0) {\n+\t\tsnprintf(out, out_size, MSG_ARG_NOT_FOUND, \"rule\");\n+\t\treturn;\n+\t}\n+\n+\tif (strcmp(tokens[5], \"read\") != 0) {\n+\t\tsnprintf(out, out_size, MSG_ARG_NOT_FOUND, \"read\");\n+\t\treturn;\n+\t}\n+\n+\tif (strcmp(tokens[6], \"ttl\") != 0) {\n+\t\tsnprintf(out, out_size, MSG_ARG_NOT_FOUND, \"ttl\");\n+\t\treturn;\n+\t}\n+\n+\tn_tokens -= 7;\n+\ttokens += 7;\n+\n+\t/* clear */\n+\tif (n_tokens && (strcmp(tokens[0], \"clear\") == 0)) {\n+\t\tclear = 1;\n+\n+\t\tn_tokens--;\n+\t\ttokens++;\n+\t}\n+\n+\t/* match */\n+\tif ((n_tokens == 0) || strcmp(tokens[0], \"match\")) {\n+\t\tsnprintf(out, out_size, MSG_ARG_NOT_FOUND, \"match\");\n+\t\treturn;\n+\t}\n+\n+\tn_tokens_parsed = parse_match(tokens,\n+\t\tn_tokens,\n+\t\tout,\n+\t\tout_size,\n+\t\t&m);\n+\tif (n_tokens_parsed == 0)\n+\t\treturn;\n+\tn_tokens -= n_tokens_parsed;\n+\ttokens += n_tokens_parsed;\n+\n+\t/* end */\n+\tif (n_tokens) {\n+\t\tsnprintf(out, out_size, MSG_ARG_INVALID, tokens[0]);\n+\t\treturn;\n+\t}\n+\n+\t/* Read table rule TTL stats. */\n+\tstatus = pipeline_table_rule_ttl_read(pipeline_name,\n+\t\ttable_id,\n+\t\t&m,\n+\t\t&stats,\n+\t\tclear);\n+\tif (status) {\n+\t\tsnprintf(out, out_size, MSG_CMD_FAIL, tokens[0]);\n+\t\treturn;\n+\t}\n+\n+\t/* Print stats. */\n+\tsnprintf(out, out_size, \"Packets: %\" PRIu64 \"\\n\",\n+\t\tstats.n_packets);\n }\n \n \ndiff --git a/examples/ip_pipeline/pipeline.h b/examples/ip_pipeline/pipeline.h\nindex 57553bd..4e2d328 100644\n--- a/examples/ip_pipeline/pipeline.h\n+++ b/examples/ip_pipeline/pipeline.h\n@@ -386,7 +386,7 @@ pipeline_table_dscp_table_update(const char *pipeline_name,\n int\n pipeline_table_rule_ttl_read(const char *pipeline_name,\n \tuint32_t table_id,\n-\tvoid *data,\n+\tstruct table_rule_match *match,\n \tstruct rte_table_action_ttl_counters *stats,\n \tint clear);\n struct table_rule *\ndiff --git a/examples/ip_pipeline/thread.c b/examples/ip_pipeline/thread.c\nindex 0252db9..e1142d9 100644\n--- a/examples/ip_pipeline/thread.c\n+++ b/examples/ip_pipeline/thread.c\n@@ -2100,31 +2100,40 @@ pipeline_table_dscp_table_update(const char *pipeline_name,\n int\n pipeline_table_rule_ttl_read(const char *pipeline_name,\n \tuint32_t table_id,\n-\tvoid *data,\n+\tstruct table_rule_match *match,\n \tstruct rte_table_action_ttl_counters *stats,\n \tint clear)\n {\n \tstruct pipeline *p;\n+\tstruct table *table;\n \tstruct pipeline_msg_req *req;\n \tstruct pipeline_msg_rsp *rsp;\n+\tstruct table_rule *rule;\n \tint status;\n \n \t/* Check input params */\n \tif ((pipeline_name == NULL) ||\n-\t\t(data == NULL) ||\n+\t\t(match == NULL) ||\n \t\t(stats == NULL))\n \t\treturn -1;\n \n \tp = pipeline_find(pipeline_name);\n \tif ((p == NULL) ||\n-\t\t(table_id >= p->n_tables))\n+\t\t(table_id >= p->n_tables) ||\n+\t\tmatch_check(match, p, table_id))\n \t\treturn -1;\n \n-\tif (!pipeline_is_running(p)) {\n-\t\tstruct rte_table_action *a = p->table[table_id].a;\n+\ttable = &p->table[table_id];\n+\tif (!table->ap->params.ttl.n_packets_enabled)\n+\t\treturn -1;\n+\n+\trule = table_rule_find(table, match);\n+\tif (rule == NULL)\n+\t\treturn -1;\n \n-\t\tstatus = rte_table_action_ttl_read(a,\n-\t\t\t\tdata,\n+\tif (!pipeline_is_running(p)) {\n+\t\tstatus = rte_table_action_ttl_read(table->a,\n+\t\t\t\trule->data,\n \t\t\t\tstats,\n \t\t\t\tclear);\n \n@@ -2139,7 +2148,7 @@ pipeline_table_rule_ttl_read(const char *pipeline_name,\n \t/* Write request */\n \treq->type = PIPELINE_REQ_TABLE_RULE_TTL_READ;\n \treq->id = table_id;\n-\treq->table_rule_ttl_read.data = data;\n+\treq->table_rule_ttl_read.data = rule->data;\n \treq->table_rule_ttl_read.clear = clear;\n \n \t/* Send request and wait for response */\n@@ -2149,7 +2158,7 @@ pipeline_table_rule_ttl_read(const char *pipeline_name,\n \n \t/* Read response */\n \tstatus = rsp->status;\n-\tif (status)\n+\tif (status == 0)\n \t\tmemcpy(stats, &rsp->table_rule_ttl_read.stats, sizeof(*stats));\n \n \t/* Free response */\n", "prefixes": [ "09/12" ] }