Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 47538,
    "url": "http://patches.dpdk.org/api/patches/47538/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20181028014650.84308-1-ferruh.yigit@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20181028014650.84308-1-ferruh.yigit@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20181028014650.84308-1-ferruh.yigit@intel.com",
    "date": "2018-10-28T01:46:50",
    "name": "ethdev: fix redundant function pointer check",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "8ff37cf763e90f9087fa28eeb85071c8e621bd7d",
    "submitter": {
        "id": 324,
        "url": "http://patches.dpdk.org/api/people/324/?format=api",
        "name": "Ferruh Yigit",
        "email": "ferruh.yigit@intel.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20181028014650.84308-1-ferruh.yigit@intel.com/mbox/",
    "series": [
        {
            "id": 2139,
            "url": "http://patches.dpdk.org/api/series/2139/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=2139",
            "date": "2018-10-28T01:46:50",
            "name": "ethdev: fix redundant function pointer check",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/2139/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/47538/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/47538/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9B2062C60;\n\tSun, 28 Oct 2018 02:47:10 +0200 (CEST)",
            "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id C1D242B94;\n\tSun, 28 Oct 2018 02:47:08 +0200 (CEST)",
            "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t27 Oct 2018 17:47:07 -0700",
            "from silpixa00399752.ir.intel.com (HELO\n\tsilpixa00399752.ger.corp.intel.com) ([10.237.222.212])\n\tby orsmga003.jf.intel.com with ESMTP; 27 Oct 2018 17:47:05 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.54,434,1534834800\"; d=\"scan'208\";a=\"95580261\"",
        "From": "Ferruh Yigit <ferruh.yigit@intel.com>",
        "To": "Thomas Monjalon <thomas@monjalon.net>,\n\tAndrew Rybchenko <arybchenko@solarflare.com>",
        "Cc": "dev@dpdk.org,\n\tFerruh Yigit <ferruh.yigit@intel.com>,\n\tstable@dpdk.org",
        "Date": "Sun, 28 Oct 2018 01:46:50 +0000",
        "Message-Id": "<20181028014650.84308-1-ferruh.yigit@intel.com>",
        "X-Mailer": "git-send-email 2.17.2",
        "Subject": "[dpdk-dev] [PATCH] ethdev: fix redundant function pointer check",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "RTE_FUNC_PTR_OR_ERR_RET() already does the `ethdev_uninit` NULL check.\n\nFixes: e489007a411c (\"ethdev: add generic create/destroy ethdev APIs\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ferruh Yigit <ferruh.yigit@intel.com>\n---\n lib/librte_ethdev/rte_ethdev.c | 9 ++++-----\n 1 file changed, 4 insertions(+), 5 deletions(-)",
    "diff": "diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c\nindex b2ac590ae..219795e41 100644\n--- a/lib/librte_ethdev/rte_ethdev.c\n+++ b/lib/librte_ethdev/rte_ethdev.c\n@@ -3647,11 +3647,10 @@ rte_eth_dev_destroy(struct rte_eth_dev *ethdev,\n \t\treturn -ENODEV;\n \n \tRTE_FUNC_PTR_OR_ERR_RET(*ethdev_uninit, -EINVAL);\n-\tif (ethdev_uninit) {\n-\t\tret = ethdev_uninit(ethdev);\n-\t\tif (ret)\n-\t\t\treturn ret;\n-\t}\n+\n+\tret = ethdev_uninit(ethdev);\n+\tif (ret)\n+\t\treturn ret;\n \n \treturn rte_eth_dev_release_port(ethdev);\n }\n",
    "prefixes": []
}