Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/47254/?format=api
{ "id": 47254, "url": "http://patches.dpdk.org/api/patches/47254/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20181023162915.7222-1-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20181023162915.7222-1-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20181023162915.7222-1-stephen@networkplumber.org", "date": "2018-10-23T16:29:15", "name": "eal: don't double space init alert messages", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "f38e295bc2a502c984828c430c715c2ebda06099", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20181023162915.7222-1-stephen@networkplumber.org/mbox/", "series": [ { "id": 2038, "url": "http://patches.dpdk.org/api/series/2038/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=2038", "date": "2018-10-23T16:29:15", "name": "eal: don't double space init alert messages", "version": 1, "mbox": "http://patches.dpdk.org/series/2038/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/47254/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/47254/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 784E11B3EE;\n\tTue, 23 Oct 2018 18:29:20 +0200 (CEST)", "from mail-pg1-f195.google.com (mail-pg1-f195.google.com\n\t[209.85.215.195]) by dpdk.org (Postfix) with ESMTP id 470D11B3EA\n\tfor <dev@dpdk.org>; Tue, 23 Oct 2018 18:29:19 +0200 (CEST)", "by mail-pg1-f195.google.com with SMTP id a5-v6so12135pgt.13\n\tfor <dev@dpdk.org>; Tue, 23 Oct 2018 09:29:19 -0700 (PDT)", "from xeon-e3.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\ta79-v6sm2868652pfa.124.2018.10.23.09.29.16\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 23 Oct 2018 09:29:16 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=O5PSDn50RsnKenHRaFDCwAWA8uqTE9tpxZ8BVOb+AUw=;\n\tb=OWDVEgQ6baA+Y88Zg3NXwvVxW9/2KT1wq+8Xowgfj3FBuhBA2ONW0HiyLRsf454uD+\n\trbLAWTg7NIP+0DY5ECVVz2I2HmDt/cUjtw7vdm70Xi3NMuKWRd3BAKfjvsMreHMmv/jW\n\t0RGvigH4roLXAqfsOS7E2a+xAs+2vAt1YZxMrvAQ6o71eCGXe40KiY1Tk7vcEnseAudC\n\thvVkgOW9CrVXtSs6z0AGNjxbWV68Kl8r8rKrkER9b0EJS3KYzdov3NS7bzyheBD4XvxW\n\t7eujYk9lueEXDflil/LRBlpA0ryH/b0NNVoMSRI593AjSG4/ehi7mUbzFc4NOBZj+SlW\n\tFiZQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=O5PSDn50RsnKenHRaFDCwAWA8uqTE9tpxZ8BVOb+AUw=;\n\tb=UArW0tHppDyvXgZa2eNCEiK2yhv/8Fzg1qwkt/7J/A9M8g58hlaWTYhrSVqDtaSd12\n\ttvxebP+bGH3i/KyOjnqCRbK9QNIPf4k2dMYuFDEbTVCLI0Xs1Tjiji8NxW+SAugXzXJu\n\tCbnvUU9hcOBf+LgI2XqTPLfCcCTujNDsIQxV3Kk7ilFCkhblCkZH+1pjkAvjBK3zVIZD\n\tTnKqw/FKM+wXqlGmCA9jzcw89W20wHJ5cMXKOUkupwG6xrYuUyr3c3uammvtGIfUmSPp\n\tYMEf6O6dhTMDWjBD3Dd0s7uYaNGex+7Gce2Ff3dtVAgadqMTMV2BhTRozx+REIcNVsUn\n\t9r8g==", "X-Gm-Message-State": "AGRZ1gKCaViMIk7jhVP4c0rqNPHUKE1M+NBK/Q9OY9ItRUGR6+y+TIZ5\n\tLlwsXYv4FMZfAUFDmetcDTpzGgb4bbs=", "X-Google-Smtp-Source": "AJdET5dcAUdxyU05pbOuSu9PH3Uv+iJ3y0haGal+6888lEKLROA2mEbyE6qDcHJwBoO/wp7hR1s9DQ==", "X-Received": "by 2002:a62:e048:: with SMTP id\n\tf69-v6mr1988404pfh.208.1540312157980; \n\tTue, 23 Oct 2018 09:29:17 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Tue, 23 Oct 2018 09:29:15 -0700", "Message-Id": "<20181023162915.7222-1-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.19.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] eal: don't double space init alert messages", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "rte_init_alert already adds a newline, don't do it twice.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/librte_eal/bsdapp/eal/eal.c | 24 ++++++++++++------------\n lib/librte_eal/linuxapp/eal/eal.c | 28 ++++++++++++++--------------\n 2 files changed, 26 insertions(+), 26 deletions(-)", "diff": "diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/eal.c\nindex 7735194a35bf..f94c5c5f4c58 100644\n--- a/lib/librte_eal/bsdapp/eal/eal.c\n+++ b/lib/librte_eal/bsdapp/eal/eal.c\n@@ -610,7 +610,7 @@ rte_eal_init(int argc, char **argv)\n \tinternal_config.legacy_mem = true;\n \n \tif (eal_plugins_init() < 0) {\n-\t\trte_eal_init_alert(\"Cannot init plugins\\n\");\n+\t\trte_eal_init_alert(\"Cannot init plugins\");\n \t\trte_errno = EINVAL;\n \t\trte_atomic32_clear(&run_once);\n \t\treturn -1;\n@@ -625,7 +625,7 @@ rte_eal_init(int argc, char **argv)\n \trte_config_init();\n \n \tif (rte_eal_intr_init() < 0) {\n-\t\trte_eal_init_alert(\"Cannot init interrupt-handling thread\\n\");\n+\t\trte_eal_init_alert(\"Cannot init interrupt-handling thread\");\n \t\treturn -1;\n \t}\n \n@@ -633,7 +633,7 @@ rte_eal_init(int argc, char **argv)\n \t * bus through mp channel in the secondary process before the bus scan.\n \t */\n \tif (rte_mp_channel_init() < 0) {\n-\t\trte_eal_init_alert(\"failed to init mp channel\\n\");\n+\t\trte_eal_init_alert(\"failed to init mp channel\");\n \t\tif (rte_eal_process_type() == RTE_PROC_PRIMARY) {\n \t\t\trte_errno = EFAULT;\n \t\t\treturn -1;\n@@ -641,7 +641,7 @@ rte_eal_init(int argc, char **argv)\n \t}\n \n \tif (rte_bus_scan()) {\n-\t\trte_eal_init_alert(\"Cannot scan the buses for devices\\n\");\n+\t\trte_eal_init_alert(\"Cannot scan the buses for devices\");\n \t\trte_errno = ENODEV;\n \t\trte_atomic32_clear(&run_once);\n \t\treturn -1;\n@@ -688,37 +688,37 @@ rte_eal_init(int argc, char **argv)\n \t * initialize memzones first.\n \t */\n \tif (rte_eal_memzone_init() < 0) {\n-\t\trte_eal_init_alert(\"Cannot init memzone\\n\");\n+\t\trte_eal_init_alert(\"Cannot init memzone\");\n \t\trte_errno = ENODEV;\n \t\treturn -1;\n \t}\n \n \tif (rte_eal_memory_init() < 0) {\n-\t\trte_eal_init_alert(\"Cannot init memory\\n\");\n+\t\trte_eal_init_alert(\"Cannot init memory\");\n \t\trte_errno = ENOMEM;\n \t\treturn -1;\n \t}\n \n \tif (rte_eal_malloc_heap_init() < 0) {\n-\t\trte_eal_init_alert(\"Cannot init malloc heap\\n\");\n+\t\trte_eal_init_alert(\"Cannot init malloc heap\");\n \t\trte_errno = ENODEV;\n \t\treturn -1;\n \t}\n \n \tif (rte_eal_tailqs_init() < 0) {\n-\t\trte_eal_init_alert(\"Cannot init tail queues for objects\\n\");\n+\t\trte_eal_init_alert(\"Cannot init tail queues for objects\");\n \t\trte_errno = EFAULT;\n \t\treturn -1;\n \t}\n \n \tif (rte_eal_alarm_init() < 0) {\n-\t\trte_eal_init_alert(\"Cannot init interrupt-handling thread\\n\");\n+\t\trte_eal_init_alert(\"Cannot init interrupt-handling thread\");\n \t\t/* rte_eal_alarm_init sets rte_errno on failure. */\n \t\treturn -1;\n \t}\n \n \tif (rte_eal_timer_init() < 0) {\n-\t\trte_eal_init_alert(\"Cannot init HPET or TSC timers\\n\");\n+\t\trte_eal_init_alert(\"Cannot init HPET or TSC timers\");\n \t\trte_errno = ENOTSUP;\n \t\treturn -1;\n \t}\n@@ -768,14 +768,14 @@ rte_eal_init(int argc, char **argv)\n \t/* initialize services so vdevs register service during bus_probe. */\n \tret = rte_service_init();\n \tif (ret) {\n-\t\trte_eal_init_alert(\"rte_service_init() failed\\n\");\n+\t\trte_eal_init_alert(\"rte_service_init() failed\");\n \t\trte_errno = ENOEXEC;\n \t\treturn -1;\n \t}\n \n \t/* Probe all the buses and devices/drivers on them */\n \tif (rte_bus_probe()) {\n-\t\trte_eal_init_alert(\"Cannot probe devices\\n\");\n+\t\trte_eal_init_alert(\"Cannot probe devices\");\n \t\trte_errno = ENOTSUP;\n \t\treturn -1;\n \t}\ndiff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c\nindex a00cebf5c60d..76536bae296d 100644\n--- a/lib/librte_eal/linuxapp/eal/eal.c\n+++ b/lib/librte_eal/linuxapp/eal/eal.c\n@@ -858,7 +858,7 @@ rte_eal_init(int argc, char **argv)\n \t}\n \n \tif (eal_plugins_init() < 0) {\n-\t\trte_eal_init_alert(\"Cannot init plugins\\n\");\n+\t\trte_eal_init_alert(\"Cannot init plugins\");\n \t\trte_errno = EINVAL;\n \t\trte_atomic32_clear(&run_once);\n \t\treturn -1;\n@@ -873,7 +873,7 @@ rte_eal_init(int argc, char **argv)\n \trte_config_init();\n \n \tif (rte_eal_intr_init() < 0) {\n-\t\trte_eal_init_alert(\"Cannot init interrupt-handling thread\\n\");\n+\t\trte_eal_init_alert(\"Cannot init interrupt-handling thread\");\n \t\treturn -1;\n \t}\n \n@@ -881,7 +881,7 @@ rte_eal_init(int argc, char **argv)\n \t * bus through mp channel in the secondary process before the bus scan.\n \t */\n \tif (rte_mp_channel_init() < 0) {\n-\t\trte_eal_init_alert(\"failed to init mp channel\\n\");\n+\t\trte_eal_init_alert(\"failed to init mp channel\");\n \t\tif (rte_eal_process_type() == RTE_PROC_PRIMARY) {\n \t\t\trte_errno = EFAULT;\n \t\t\treturn -1;\n@@ -890,12 +890,12 @@ rte_eal_init(int argc, char **argv)\n \n \t/* register multi-process action callbacks for hotplug */\n \tif (rte_mp_dev_hotplug_init() < 0) {\n-\t\trte_eal_init_alert(\"failed to register mp callback for hotplug\\n\");\n+\t\trte_eal_init_alert(\"failed to register mp callback for hotplug\");\n \t\treturn -1;\n \t}\n \n \tif (rte_bus_scan()) {\n-\t\trte_eal_init_alert(\"Cannot scan the buses for devices\\n\");\n+\t\trte_eal_init_alert(\"Cannot scan the buses for devices\");\n \t\trte_errno = ENODEV;\n \t\trte_atomic32_clear(&run_once);\n \t\treturn -1;\n@@ -953,7 +953,7 @@ rte_eal_init(int argc, char **argv)\n \n #ifdef VFIO_PRESENT\n \tif (rte_eal_vfio_setup() < 0) {\n-\t\trte_eal_init_alert(\"Cannot init VFIO\\n\");\n+\t\trte_eal_init_alert(\"Cannot init VFIO\");\n \t\trte_errno = EAGAIN;\n \t\trte_atomic32_clear(&run_once);\n \t\treturn -1;\n@@ -964,13 +964,13 @@ rte_eal_init(int argc, char **argv)\n \t * initialize memzones first.\n \t */\n \tif (rte_eal_memzone_init() < 0) {\n-\t\trte_eal_init_alert(\"Cannot init memzone\\n\");\n+\t\trte_eal_init_alert(\"Cannot init memzone\");\n \t\trte_errno = ENODEV;\n \t\treturn -1;\n \t}\n \n \tif (rte_eal_memory_init() < 0) {\n-\t\trte_eal_init_alert(\"Cannot init memory\\n\");\n+\t\trte_eal_init_alert(\"Cannot init memory\");\n \t\trte_errno = ENOMEM;\n \t\treturn -1;\n \t}\n@@ -979,25 +979,25 @@ rte_eal_init(int argc, char **argv)\n \teal_hugedirs_unlock();\n \n \tif (rte_eal_malloc_heap_init() < 0) {\n-\t\trte_eal_init_alert(\"Cannot init malloc heap\\n\");\n+\t\trte_eal_init_alert(\"Cannot init malloc heap\");\n \t\trte_errno = ENODEV;\n \t\treturn -1;\n \t}\n \n \tif (rte_eal_tailqs_init() < 0) {\n-\t\trte_eal_init_alert(\"Cannot init tail queues for objects\\n\");\n+\t\trte_eal_init_alert(\"Cannot init tail queues for objects\");\n \t\trte_errno = EFAULT;\n \t\treturn -1;\n \t}\n \n \tif (rte_eal_alarm_init() < 0) {\n-\t\trte_eal_init_alert(\"Cannot init interrupt-handling thread\\n\");\n+\t\trte_eal_init_alert(\"Cannot init interrupt-handling thread\");\n \t\t/* rte_eal_alarm_init sets rte_errno on failure. */\n \t\treturn -1;\n \t}\n \n \tif (rte_eal_timer_init() < 0) {\n-\t\trte_eal_init_alert(\"Cannot init HPET or TSC timers\\n\");\n+\t\trte_eal_init_alert(\"Cannot init HPET or TSC timers\");\n \t\trte_errno = ENOTSUP;\n \t\treturn -1;\n \t}\n@@ -1051,14 +1051,14 @@ rte_eal_init(int argc, char **argv)\n \t/* initialize services so vdevs register service during bus_probe. */\n \tret = rte_service_init();\n \tif (ret) {\n-\t\trte_eal_init_alert(\"rte_service_init() failed\\n\");\n+\t\trte_eal_init_alert(\"rte_service_init() failed\");\n \t\trte_errno = ENOEXEC;\n \t\treturn -1;\n \t}\n \n \t/* Probe all the buses and devices/drivers on them */\n \tif (rte_bus_probe()) {\n-\t\trte_eal_init_alert(\"Cannot probe devices\\n\");\n+\t\trte_eal_init_alert(\"Cannot probe devices\");\n \t\trte_errno = ENOTSUP;\n \t\treturn -1;\n \t}\n", "prefixes": [] }