Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/47227/?format=api
{ "id": 47227, "url": "http://patches.dpdk.org/api/patches/47227/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1540289032-29628-5-git-send-email-viacheslavo@mellanox.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1540289032-29628-5-git-send-email-viacheslavo@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1540289032-29628-5-git-send-email-viacheslavo@mellanox.com", "date": "2018-10-23T10:04:13", "name": "[v4,4/8] net/mlx5: simplify flow counters support check", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "cb8041381fb02419603e3ccb5283b8ce4084a634", "submitter": { "id": 1102, "url": "http://patches.dpdk.org/api/people/1102/?format=api", "name": "Slava Ovsiienko", "email": "viacheslavo@mellanox.com" }, "delegate": { "id": 6624, "url": "http://patches.dpdk.org/api/users/6624/?format=api", "username": "shahafs", "first_name": "Shahaf", "last_name": "Shuler", "email": "shahafs@mellanox.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1540289032-29628-5-git-send-email-viacheslavo@mellanox.com/mbox/", "series": [ { "id": 2029, "url": "http://patches.dpdk.org/api/series/2029/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=2029", "date": "2018-10-23T10:04:10", "name": "[v4,1/8] net/mlx5: fix flow counters creation", "version": 4, "mbox": "http://patches.dpdk.org/series/2029/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/47227/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/47227/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 898341B471;\n\tTue, 23 Oct 2018 12:04:30 +0200 (CEST)", "from EUR04-DB3-obe.outbound.protection.outlook.com\n\t(mail-eopbgr60087.outbound.protection.outlook.com [40.107.6.87])\n\tby dpdk.org (Postfix) with ESMTP id 28F731B19A\n\tfor <dev@dpdk.org>; Tue, 23 Oct 2018 12:04:14 +0200 (CEST)", "from AM4PR05MB3265.eurprd05.prod.outlook.com (10.171.186.150) by\n\tAM4PR05MB3380.eurprd05.prod.outlook.com (10.171.187.29) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1250.30; Tue, 23 Oct 2018 10:04:13 +0000", "from AM4PR05MB3265.eurprd05.prod.outlook.com\n\t([fe80::477:2091:24b4:439f]) by\n\tAM4PR05MB3265.eurprd05.prod.outlook.com\n\t([fe80::477:2091:24b4:439f%4]) with mapi id 15.20.1250.028;\n\tTue, 23 Oct 2018 10:04:13 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n\ts=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=vXPwAkIkqPRucQ2IlWHVbcv6Te2FtielwA3TQyknt7I=;\n\tb=HiEqUaNVNqe3wvzB1EYOgAEgTTryyFprtns40EfF0LeKSVeZ5veV/532schje4YEkAk2dLf+H+mBF/VAucxPSdFk8hhXKptbPeL3d5n6GxC3cUrIujQtWpXC0BVYVS/Mm+jEZhkUVdrk7flBa2/B9sX63/EQCB/G00yez43ppws=", "From": "Slava Ovsiienko <viacheslavo@mellanox.com>", "To": "Slava Ovsiienko <viacheslavo@mellanox.com>", "CC": "\"dev@dpdk.org\" <dev@dpdk.org>", "Thread-Topic": "[PATCH v4 4/8] net/mlx5: simplify flow counters support check", "Thread-Index": "AQHUare/O2tIo9kmKkK88sd3BetAyQ==", "Date": "Tue, 23 Oct 2018 10:04:13 +0000", "Message-ID": "<1540289032-29628-5-git-send-email-viacheslavo@mellanox.com>", "References": "<1539962470-10950-1-git-send-email-viacheslavo@mellanox.com>\n\t<1540289032-29628-1-git-send-email-viacheslavo@mellanox.com>", "In-Reply-To": "<1540289032-29628-1-git-send-email-viacheslavo@mellanox.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-clientproxiedby": "LO2P265CA0442.GBRP265.PROD.OUTLOOK.COM\n\t(2603:10a6:600:e::22) To AM4PR05MB3265.eurprd05.prod.outlook.com\n\t(2603:10a6:205:4::22)", "authentication-results": "spf=none (sender IP is )\n\tsmtp.mailfrom=viacheslavo@mellanox.com; ", "x-ms-exchange-messagesentrepresentingtype": "1", "x-originating-ip": "[37.142.13.130]", "x-ms-publictraffictype": "Email", "x-microsoft-exchange-diagnostics": "1; AM4PR05MB3380;\n\t6:59NPa8EpNVJLZuiLFnakF/g6KrMKoDiQXu+CjjtCuNW0TUG8Am6w3nMAylVxKC4KyCcEUfS6nmrTQmmuUJvNqAhSaZS9vDimwHQ2Lk0QAOe1kd1Qa7A5AFGj/+GC4GGYGVdNd1G7YY4QsqWqkrthee74gD5e3WH8eXnttM8tdiyWh28M4SR5f822PXL48CQVeX5+1KVdi7x+QUmZ4VrYdKgz2E4/VUHU5eQMtI3XEQmPxgIRw6xGb64EXvF4zk8LG0aoVsJv3GL1uOZDM9WOkPZyaokRoZ8aPjB1Rc5Ge+m8VANYKXc4eMEh3kQrjRVZCUSjcttY/Fco1LwfYOP8UD3LNpKu5i3BTrez2Vip8tOPG9I6FY+hFBV9Lr0EwRDVzNyvv+ffhQFKlXoJGKE/o2b+yCWeYXNMqF4b7U6in2MXHUWU9rweJHSmpjyjkzr4zl5DXAvKZB1rAPtmJb7PVA==;\n\t5:grtQ/muVMBSe+7mQx0yQuruKLT/bYW+VhuWes10ptqXYOmtr0UZTeRe4QIUY5lOjqVDFHwxUQYkDd4fF1SJCMurNkLxyjEwqc3bSatNdyGODosGkz8aKjQygJigoWiXQxxJqlz2GHMaDylid1TLQlpBi5NDdCjonyiKErv5YzpU=;\n\t7:YoR6MKDIjyPePaYu4IVL0EQcekPd0jvOqKM/wh0rkyR76QHQIiqfQ4wFowgwvHzb5/CsdlUxg8+7q4rxqr2FU3k5u+cMO+b6VvOEkBYakAHn1SN3y1F2Y4azaOrf4bT72ItVJo2UOPxSc/DhBFHlzipLBXs/cx/zgznVH+5cmq5ezYDOQt5yPYiclBwUgCY/d1qwh4M182MSsQ76bWzYPUyEc7uQuP8RZcHQxVZjW7IBxcJMZF6cYMS8Puts84zX", "x-ms-office365-filtering-correlation-id": "dd6656a2-bc27-4a50-ddd0-08d638cee20f", "x-ms-office365-filtering-ht": "Tenant", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020);\n\tSRVR:AM4PR05MB3380; ", "x-ms-traffictypediagnostic": "AM4PR05MB3380:", "x-microsoft-antispam-prvs": "<AM4PR05MB338042AB6A1AD16253AA4EB8D2F50@AM4PR05MB3380.eurprd05.prod.outlook.com>", "x-exchange-antispam-report-test": "UriScan:;", "x-ms-exchange-senderadcheck": "1", "x-exchange-antispam-report-cfa-test": "BCL:0; PCL:0;\n\tRULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3231355)(944501410)(52105095)(3002001)(6055026)(148016)(149066)(150057)(6041310)(20161123564045)(20161123562045)(20161123558120)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051)(76991095);\n\tSRVR:AM4PR05MB3380; BCL:0; PCL:0; RULEID:; SRVR:AM4PR05MB3380; ", "x-forefront-prvs": "0834BAF534", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(396003)(136003)(346002)(39860400002)(376002)(366004)(199004)(189003)(71200400001)(6512007)(2906002)(478600001)(5660300001)(446003)(2616005)(14454004)(53936002)(6436002)(37006003)(3846002)(81156014)(6862004)(86362001)(36756003)(2900100001)(5250100002)(7736002)(305945005)(14444005)(6116002)(6486002)(105586002)(7049001)(316002)(97736004)(68736007)(71190400001)(52116002)(102836004)(4326008)(476003)(25786009)(99286004)(66066001)(106356001)(8676002)(81166006)(256004)(76176011)(6506007)(386003)(486006)(11346002)(6200100001)(26005)(186003)(8936002)(309714004);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3380;\n\tH:AM4PR05MB3265.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en;\n\tPTR:InfoNoRecords; A:1; MX:1; ", "received-spf": "None (protection.outlook.com: mellanox.com does not designate\n\tpermitted sender hosts)", "x-microsoft-antispam-message-info": "rR+KHAXiq7yM2v5l3WQhJy2xHTeITLse056Y93hUxv3aDgWUZCsKfa7QsBtPXMSssp0qC6Q1uFIICnbaZRiKwZKvn945cDGJ2gGB7RrJ+IlhkTqQ8mIHK1zWyRXcSapYFF7ySTur/uKs8EAjybePgNHqa28/CUfl/ttL5ap8kMp9l71wtQd7wHkOj+MRBUFgwkZ8p1qk5IigsexAG2ceR3c+30lwCdzeVBCOR1V2t0RacgFEx3UjkzzBP2Vk4vJaMn2ARKA1UN2E8c01Shj7g1knOuahlwN8M+Ph0s/VaMpcA0KqcOdu5ubowC2oNnXCKWDtBrwYbZGnwNeJU3HDbGRk3qpGCZ+NiJO/9mivE2k=", "spamdiagnosticoutput": "1:99", "spamdiagnosticmetadata": "NSPM", "Content-Type": "text/plain; charset=\"iso-8859-1\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-OriginatorOrg": "Mellanox.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "dd6656a2-bc27-4a50-ddd0-08d638cee20f", "X-MS-Exchange-CrossTenant-originalarrivaltime": "23 Oct 2018 10:04:13.0935\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "a652971c-7d2e-4d9b-a6a4-d149256f461b", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM4PR05MB3380", "Subject": "[dpdk-dev] [PATCH v4 4/8] net/mlx5: simplify flow counters support\n\tcheck", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The redundant check of Flow counters support in runtime is removed.\nThe flag flow_counter_en is eliminated from the code. The Verbs\ncreate counter function just returns an error if no counter\nsupport presented in the system.\n\nIf there is no any of Flow counters configuration macro defined\nthe log message is emited, indicating the missing counter support.\n\nmlx5_flow_validate_action_count() fuctnion is also updated due to\nflow_counter_en flag removal.\n\nSigned-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>\n---\n drivers/net/mlx5/mlx5.c | 12 +++---------\n drivers/net/mlx5/mlx5.h | 1 -\n drivers/net/mlx5/mlx5_flow.c | 8 +-------\n 3 files changed, 4 insertions(+), 17 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c\nindex cb86a69..a6cae69 100644\n--- a/drivers/net/mlx5/mlx5.c\n+++ b/drivers/net/mlx5/mlx5.c\n@@ -739,9 +739,6 @@\n \tunsigned int mprq_max_stride_size_n = 0;\n \tunsigned int mprq_min_stride_num_n = 0;\n \tunsigned int mprq_max_stride_num_n = 0;\n-#ifdef HAVE_IBV_DEVICE_COUNTERS_SET_V42\n-\tstruct ibv_counter_set_description cs_desc = { .counter_type = 0 };\n-#endif\n \tstruct ether_addr mac;\n \tchar name[RTE_ETH_NAME_MAX_LEN];\n \tint own_domain_id = 0;\n@@ -1009,12 +1006,9 @@\n \tconfig.hw_csum = !!(attr.device_cap_flags_ex & IBV_DEVICE_RAW_IP_CSUM);\n \tDRV_LOG(DEBUG, \"checksum offloading is %ssupported\",\n \t\t(config.hw_csum ? \"\" : \"not \"));\n-#ifdef HAVE_IBV_DEVICE_COUNTERS_SET_V42\n-\tconfig.flow_counter_en = !!attr.max_counter_sets;\n-\tmlx5_glue->describe_counter_set(ctx, 0, &cs_desc);\n-\tDRV_LOG(DEBUG, \"counter type = %d, num of cs = %ld, attributes = %d\",\n-\t\tcs_desc.counter_type, cs_desc.num_of_cs,\n-\t\tcs_desc.attributes);\n+#if !defined(HAVE_IBV_DEVICE_COUNTERS_SET_V42) && \\\n+\t!defined(HAVE_IBV_DEVICE_COUNTERS_SET_V45)\n+\tDRV_LOG(DEBUG, \"counters are not supported\");\n #endif\n \tconfig.ind_table_max_size =\n \t\tattr.rss_caps.max_rwq_indirection_table_size;\ndiff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h\nindex d14239c..74d87c0 100644\n--- a/drivers/net/mlx5/mlx5.h\n+++ b/drivers/net/mlx5/mlx5.h\n@@ -114,7 +114,6 @@ struct mlx5_dev_config {\n \tunsigned int tunnel_en:1;\n \t/* Whether tunnel stateless offloads are supported. */\n \tunsigned int mpls_en:1; /* MPLS over GRE/UDP is enabled. */\n-\tunsigned int flow_counter_en:1; /* Whether flow counter is supported. */\n \tunsigned int cqe_comp:1; /* CQE compression is enabled. */\n \tunsigned int tso:1; /* Whether TSO is supported. */\n \tunsigned int tx_vec_en:1; /* Tx vector is enabled. */\ndiff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c\nindex fcabab0..14288e4 100644\n--- a/drivers/net/mlx5/mlx5_flow.c\n+++ b/drivers/net/mlx5/mlx5_flow.c\n@@ -921,16 +921,10 @@ uint32_t mlx5_flow_adjust_priority(struct rte_eth_dev *dev, int32_t priority,\n * 0 on success, a negative errno value otherwise and rte_ernno is set.\n */\n int\n-mlx5_flow_validate_action_count(struct rte_eth_dev *dev,\n+mlx5_flow_validate_action_count(struct rte_eth_dev *dev __rte_unused,\n \t\t\t\tconst struct rte_flow_attr *attr,\n \t\t\t\tstruct rte_flow_error *error)\n {\n-\tstruct priv *priv = dev->data->dev_private;\n-\n-\tif (!priv->config.flow_counter_en)\n-\t\treturn rte_flow_error_set(error, ENOTSUP,\n-\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION, NULL,\n-\t\t\t\t\t \"flow counters are not supported.\");\n \tif (attr->egress)\n \t\treturn rte_flow_error_set(error, ENOTSUP,\n \t\t\t\t\t RTE_FLOW_ERROR_TYPE_ATTR_EGRESS, NULL,\n", "prefixes": [ "v4", "4/8" ] }