Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/47224/?format=api
{ "id": 47224, "url": "http://patches.dpdk.org/api/patches/47224/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1540289032-29628-2-git-send-email-viacheslavo@mellanox.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1540289032-29628-2-git-send-email-viacheslavo@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1540289032-29628-2-git-send-email-viacheslavo@mellanox.com", "date": "2018-10-23T10:04:10", "name": "[v4,1/8] net/mlx5: fix flow counters creation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b5396f8e49f0b01627d539d41d3a7557c3d0c6d0", "submitter": { "id": 1102, "url": "http://patches.dpdk.org/api/people/1102/?format=api", "name": "Slava Ovsiienko", "email": "viacheslavo@mellanox.com" }, "delegate": { "id": 6624, "url": "http://patches.dpdk.org/api/users/6624/?format=api", "username": "shahafs", "first_name": "Shahaf", "last_name": "Shuler", "email": "shahafs@mellanox.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1540289032-29628-2-git-send-email-viacheslavo@mellanox.com/mbox/", "series": [ { "id": 2029, "url": "http://patches.dpdk.org/api/series/2029/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=2029", "date": "2018-10-23T10:04:10", "name": "[v4,1/8] net/mlx5: fix flow counters creation", "version": 4, "mbox": "http://patches.dpdk.org/series/2029/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/47224/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/47224/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 425071B1FC;\n\tTue, 23 Oct 2018 12:04:15 +0200 (CEST)", "from EUR04-HE1-obe.outbound.protection.outlook.com\n\t(mail-eopbgr70055.outbound.protection.outlook.com [40.107.7.55])\n\tby dpdk.org (Postfix) with ESMTP id 60D6D1B119;\n\tTue, 23 Oct 2018 12:04:11 +0200 (CEST)", "from AM4PR05MB3265.eurprd05.prod.outlook.com (10.171.186.150) by\n\tAM4PR05MB3380.eurprd05.prod.outlook.com (10.171.187.29) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1250.30; Tue, 23 Oct 2018 10:04:10 +0000", "from AM4PR05MB3265.eurprd05.prod.outlook.com\n\t([fe80::477:2091:24b4:439f]) by\n\tAM4PR05MB3265.eurprd05.prod.outlook.com\n\t([fe80::477:2091:24b4:439f%4]) with mapi id 15.20.1250.028;\n\tTue, 23 Oct 2018 10:04:10 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n\ts=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=1I1/gp05ITbNWr48u+k9oHhwW+5T/VNpGR7M5Gogq30=;\n\tb=iDXqLPUPqEeNGg5ibELbVLj8lt27Rmuum0yWQJhJygtHAuT8xY51sEDJbvE0bu2e1z4aVT/3d+kktwgFQH/J5fMOwQmGJ8v0WirSo7KCJP9PQBJYQv70+4oSAzxoQKGUJ69V+zfHjkdssctj8BhrBmbGYRBlBy+NBv1wnOkgMqc=", "From": "Slava Ovsiienko <viacheslavo@mellanox.com>", "To": "Slava Ovsiienko <viacheslavo@mellanox.com>", "CC": "\"dev@dpdk.org\" <dev@dpdk.org>, \"stable@dpdk.org\" <stable@dpdk.org>", "Thread-Topic": "[PATCH v4 1/8] net/mlx5: fix flow counters creation", "Thread-Index": "AQHUare+Bhz3uSeTjE63OIOzOnUQOA==", "Date": "Tue, 23 Oct 2018 10:04:10 +0000", "Message-ID": "<1540289032-29628-2-git-send-email-viacheslavo@mellanox.com>", "References": "<1539962470-10950-1-git-send-email-viacheslavo@mellanox.com>\n\t<1540289032-29628-1-git-send-email-viacheslavo@mellanox.com>", "In-Reply-To": "<1540289032-29628-1-git-send-email-viacheslavo@mellanox.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-clientproxiedby": "LO2P265CA0442.GBRP265.PROD.OUTLOOK.COM\n\t(2603:10a6:600:e::22) To AM4PR05MB3265.eurprd05.prod.outlook.com\n\t(2603:10a6:205:4::22)", "authentication-results": "spf=none (sender IP is )\n\tsmtp.mailfrom=viacheslavo@mellanox.com; ", "x-ms-exchange-messagesentrepresentingtype": "1", "x-originating-ip": "[37.142.13.130]", "x-ms-publictraffictype": "Email", "x-microsoft-exchange-diagnostics": "1; AM4PR05MB3380;\n\t6:RLnGhODNSn2S2gWPexSmMwJ6s00xvjiFd+fCJ/Ot4c3lZAKIffEN1bdzy4PU0i9BXtFnUGmImq4A3Tw6ForDIlRn+uD77W1fuM9L4DlA8RxHMYxRZC0Y0LI5u+khWWLtiWFAk4K2t016d449yTlRBIDjxmiXLZmavYyZVx2VywIvhAXYKsiLDnQFtTBf6Fw9uUKnrRQxq+balgsr33wd1BYz/TyNoO0KJglFoe14Pd4tSkvnOnysvUR4RNd/SnknxDqq7JoWxntkFcctBex0nax0HNinG1ezdcpMhTGRtc/yXcFJNE2zzrKOlP4uCyW3rUu2f2+bXLYhurFIFWb35XcwlI7Tw8X47eQ4QzcZoXFcPrzP0dGQu7xCcNciQ51jl3wWK7+HoGdHRW2m4e4WcQ232mcRZSpcINiBBtCRfm4S80lUAa8NV1SKIEOBU8agEXGLxnzT8/XXbCCAWSmYcg==;\n\t5:YnqYTGOaRiQhKtwI5Kl+fk2K8SZQ52Fmgi3+Ky+oBqIRjE/Dddr4MBgAaOVeXaQ5mbmVqd3tWv0C5vPaphdakOQU9KwxMHPWtZvHlHFkGdnnumg+1izhIsKHOMpTXcAe/fmCJNfGvNKXvijfYCbDHCfl/COm5gJjzfXqiO2zr7A=;\n\t7:u0C+8fT7WwhLc8V094c5IZGTIKg54ztJ2fIYdbltx4Cno0m3l3czIlRaHkMEghzVQ+otFKw9wF1BaRab+wsrdQy5c+uKWczF+jVaCuVpUf/tgJPBd9I/jwi04vmsKV3SQLX7KSxU9wylA8iqvZKlCO8L+IYcUfy6wwRnk0CLLlbWIEjI9FlSDQn1nzYLtK5OkWqsskPOJEiUzY4ZF2DBbCCMR3g6KtAmmxhUJrw7vfoKzfN13LxZugV5PBsU7v0K", "x-ms-office365-filtering-correlation-id": "5fe7f83a-467b-4f56-6359-08d638cee098", "x-ms-office365-filtering-ht": "Tenant", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020);\n\tSRVR:AM4PR05MB3380; ", "x-ms-traffictypediagnostic": "AM4PR05MB3380:", "x-microsoft-antispam-prvs": "<AM4PR05MB3380C4DFEF74DA2FB4F3D3C4D2F50@AM4PR05MB3380.eurprd05.prod.outlook.com>", "x-exchange-antispam-report-test": "UriScan:;", "x-ms-exchange-senderadcheck": "1", "x-exchange-antispam-report-cfa-test": "BCL:0; PCL:0;\n\tRULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3231355)(944501410)(52105095)(3002001)(6055026)(148016)(149066)(150057)(6041310)(20161123564045)(20161123562045)(20161123558120)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051)(76991095);\n\tSRVR:AM4PR05MB3380; BCL:0; PCL:0; RULEID:; SRVR:AM4PR05MB3380; ", "x-forefront-prvs": "0834BAF534", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(396003)(136003)(346002)(39860400002)(376002)(366004)(199004)(189003)(71200400001)(6512007)(2906002)(478600001)(5660300001)(446003)(2616005)(14454004)(53936002)(6436002)(37006003)(3846002)(81156014)(6862004)(54906003)(86362001)(36756003)(2900100001)(5250100002)(7736002)(305945005)(14444005)(6116002)(6486002)(105586002)(7049001)(316002)(97736004)(68736007)(71190400001)(52116002)(102836004)(4326008)(476003)(25786009)(450100002)(99286004)(66066001)(106356001)(8676002)(81166006)(256004)(76176011)(6506007)(386003)(486006)(11346002)(6200100001)(26005)(186003)(8936002);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3380;\n\tH:AM4PR05MB3265.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en;\n\tPTR:InfoNoRecords; A:1; MX:1; ", "received-spf": "None (protection.outlook.com: mellanox.com does not designate\n\tpermitted sender hosts)", "x-microsoft-antispam-message-info": "y6Wx3pHDwivVkcfle6ZJZfF2Tooyp644nQqFIwHPfTFzIWYM7cHgNHmcsP5IoexWUslTxqSXxMuvhZufhmHfRK9CdGEd6x+RskvD/aP4TRflB2JOOdOAMtXfgFFRCNUhd1B/dnm2FGTgQd21AjWvzw5mFe3BYcpmAYs1Cdi5u1qvkvzoYRMoMoV4JGSr/Iutfs7GiufOMZj9vH5OeeudjrupAPZOqzheZRxyDuc/qqcx78XiIMPXrTgpXwqXz4+NMeWYzRX3aQn14OafzNgcJJA0SSrVx7ZWXWd2phzOM6YmjgvytgfsZc/nT9kyewn2dOJ01NKU/Plx35WyOXWieWyOwajFh8RmG8F0CGQk6mM=", "spamdiagnosticoutput": "1:99", "spamdiagnosticmetadata": "NSPM", "Content-Type": "text/plain; charset=\"iso-8859-1\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-OriginatorOrg": "Mellanox.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "5fe7f83a-467b-4f56-6359-08d638cee098", "X-MS-Exchange-CrossTenant-originalarrivaltime": "23 Oct 2018 10:04:10.5468\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "a652971c-7d2e-4d9b-a6a4-d149256f461b", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM4PR05MB3380", "Subject": "[dpdk-dev] [PATCH v4 1/8] net/mlx5: fix flow counters creation", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The Flow counter creation function contains two problems:\n\n - Flow counter object in Verbs is not freed in case of memory\n allocation error. The call of counter Verbs object deallocating\n function is added to fix.\n\n - The initial value of reference counter is set to one in order\n to provide the correct counter object freeing in the\n flow_verbs_counter_release() function. The reference counter\n field should be initialized to one.\n\nFixes: 60bd8c9747e8 (\"net/mlx5: add count flow action\")\nCc: stable@dpdk.org\n\nSigned-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>\n---\n drivers/net/mlx5/mlx5_flow_verbs.c | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow_verbs.c b/drivers/net/mlx5/mlx5_flow_verbs.c\nindex 4ae974b..6ddb13b 100644\n--- a/drivers/net/mlx5/mlx5_flow_verbs.c\n+++ b/drivers/net/mlx5/mlx5_flow_verbs.c\n@@ -72,6 +72,7 @@\n \t\t\t }),\n \t\t.hits = 0,\n \t\t.bytes = 0,\n+\t\t.ref_cnt = 1,\n \t};\n \n \tif (!tmpl.cs) {\n@@ -80,6 +81,7 @@\n \t}\n \tcnt = rte_calloc(__func__, 1, sizeof(*cnt), 0);\n \tif (!cnt) {\n+\t\tclaim_zero(mlx5_glue->destroy_counter_set(tmpl.cs));\n \t\trte_errno = ENOMEM;\n \t\treturn NULL;\n \t}\n", "prefixes": [ "v4", "1/8" ] }