Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/47217/?format=api
{ "id": 47217, "url": "http://patches.dpdk.org/api/patches/47217/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20181023082842.7963-4-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20181023082842.7963-4-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20181023082842.7963-4-thomas@monjalon.net", "date": "2018-10-23T08:28:38", "name": "[v7,3/7] ethdev: allow iterating with pure class filter", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "f8a1fae07a9a7bbee2bb1bcba2bf74def87567d6", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20181023082842.7963-4-thomas@monjalon.net/mbox/", "series": [ { "id": 2026, "url": "http://patches.dpdk.org/api/series/2026/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=2026", "date": "2018-10-23T08:28:35", "name": "replace attach/detach functions", "version": 7, "mbox": "http://patches.dpdk.org/series/2026/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/47217/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/47217/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9D07F1B3B5;\n\tTue, 23 Oct 2018 10:28:56 +0200 (CEST)", "from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com\n\t[66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 3B7381B2B3\n\tfor <dev@dpdk.org>; Tue, 23 Oct 2018 10:28:50 +0200 (CEST)", "from compute1.internal (compute1.nyi.internal [10.202.2.41])\n\tby mailout.nyi.internal (Postfix) with ESMTP id DAFC1220D0;\n\tTue, 23 Oct 2018 04:28:49 -0400 (EDT)", "from mailfrontend1 ([10.202.2.162])\n\tby compute1.internal (MEProxy); Tue, 23 Oct 2018 04:28:49 -0400", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id AA6E7E491F;\n\tTue, 23 Oct 2018 04:28:48 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n\tfrom:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding; s=mesmtp; bh=q8OBrmkxEp\n\tPYPsmucZdkzY0KCYQwxRICq3gEgLXMeBc=; b=FSMwYjf6RFwoy5MANC7yqZB4Ic\n\t/V6DLYBpDLTw+juVOSsS5MReKL3VtnW1iQKvSnHd+01K5Msmazq/m1amwomtbrdp\n\tOV5onODybAzTsyqcuBv3CM0cRmN3nnbam1RQqtbK8FKdTNWHa6kTSBcM4VoOsiYk\n\tWAPS5WcMNNXqYKPc8=", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:content-transfer-encoding:date:from\n\t:in-reply-to:message-id:mime-version:references:subject:to\n\t:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n\tfm1; bh=q8OBrmkxEpPYPsmucZdkzY0KCYQwxRICq3gEgLXMeBc=; b=btzrTZ+c\n\tnpSpSTBtCLbYQP1vb3XfwpgSNFU5hXCiCcV1dbgcUTlTcurfaNVg7DTrtNxOYPbl\n\tsQV3SME+Fp3IYjXEgorSxUB5VK3zQPF5O1aa1FLHw8vOcMz83yCLBbBfyLDyDJ/F\n\tMPM9L0OFCzVfHqURSIAZgmosW6Wi/aPNaqzQ/i75ZGDEYa2fcRP3rTr559vw1g9j\n\t5Y9EyrqoYduvihPnxTKo0DrvXfydHLm/783KORQW9BrO+DAmCyVH/dy0GNHiYAb1\n\tx5L5WFsLv+vCYkjKLYFZm+BDXO/nA1PtepJ5OdwpLrRqWqOZVDrbC25Rc1olvUT1\n\t3bXHSAn8Mb1L5g==" ], "X-ME-Sender": "<xms:wdvOW3jV6IAa36m4ECrum9_ufQpTS_sFryGE--u08wQ_zGd3vzFcDQ>", "X-ME-Proxy": "<xmx:wdvOW201knv5EXCN3E-7jAwidqw9XXAOdmf7nlL5jxEvXet4KBp6IA>\n\t<xmx:wdvOW6sMzAON4UIx8f6vS2YDB4ZFRGPeEhIilXyArtm3FresDImL5g>\n\t<xmx:wdvOW9mw2IwlQnH4D2PzzhyejEw45ugTr-WmoxkID2JjkMTVo1N6xg>\n\t<xmx:wdvOWwWaKZWDOfSN9seiXaFNnI9uonSH5qxGIcXQmkeD5KO_EmqMAg>\n\t<xmx:wdvOW5soV7-K_4ZLMkKVp8k3QqwhdDexRzBbxgwRIYINSNWxIRA3qw>\n\t<xmx:wdvOWxUNw0V6XBENTVxhm6fxWKXvRa3ci9wJAlPFuSXQ-xCl0nB-yA>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "gaetan.rivet@6wind.com, ophirmu@mellanox.com, wisamm@mellanox.com,\n\tferruh.yigit@intel.com, arybchenko@solarflare.com,\n\tbernard.iremonger@intel.com", "Date": "Tue, 23 Oct 2018 10:28:38 +0200", "Message-Id": "<20181023082842.7963-4-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.19.0", "In-Reply-To": "<20181023082842.7963-1-thomas@monjalon.net>", "References": "<20181007222554.4886-1-thomas@monjalon.net>\n\t<20181023082842.7963-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v7 3/7] ethdev: allow iterating with pure class\n\tfilter", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "If no rte_device is given in the iterator,\neth_dev_match() is looking at all ports without any restriction,\nexcept the ethdev kvargs filter.\n\nIt allows to iterate with a devargs filter referencing only\nsome ethdev parameters. The format (from the new devargs syntax) is:\n\tclass=eth,paramY=Y\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\nReviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n lib/librte_ethdev/rte_class_eth.c | 2 +-\n lib/librte_ethdev/rte_ethdev.c | 25 ++++++++++++++++++++++---\n 2 files changed, 23 insertions(+), 4 deletions(-)", "diff": "diff --git a/lib/librte_ethdev/rte_class_eth.c b/lib/librte_ethdev/rte_class_eth.c\nindex c04279ec6..58fed694b 100644\n--- a/lib/librte_ethdev/rte_class_eth.c\n+++ b/lib/librte_ethdev/rte_class_eth.c\n@@ -42,7 +42,7 @@ eth_dev_match(const struct rte_eth_dev *edev,\n \n \tif (edev->state == RTE_ETH_DEV_UNUSED)\n \t\treturn -1;\n-\tif (edev->device != arg->device)\n+\tif (arg->device != NULL && arg->device != edev->device)\n \t\treturn -1;\n \tif (kvlist == NULL)\n \t\t/* Empty string matches everything. */\ndiff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c\nindex 3550aa696..7ed71744c 100644\n--- a/lib/librte_ethdev/rte_ethdev.c\n+++ b/lib/librte_ethdev/rte_ethdev.c\n@@ -202,10 +202,24 @@ rte_eth_iterator_init(struct rte_dev_iterator *iter, const char *devargs_str)\n \t * The devargs string may use various syntaxes:\n \t * - 0000:08:00.0,representor=[1-3]\n \t * - pci:0000:06:00.0,representor=[0,5]\n+\t * - class=eth,mac=00:11:22:33:44:55\n \t * A new syntax is in development (not yet supported):\n \t * - bus=X,paramX=x/class=Y,paramY=y/driver=Z,paramZ=z\n \t */\n \n+\t/*\n+\t * Handle pure class filter (i.e. without any bus-level argument),\n+\t * from future new syntax.\n+\t * rte_devargs_parse() is not yet supporting the new syntax,\n+\t * that's why this simple case is temporarily parsed here.\n+\t */\n+#define iter_anybus_str \"class=eth,\"\n+\tif (strncmp(devargs_str, iter_anybus_str,\n+\t\t\tstrlen(iter_anybus_str)) == 0) {\n+\t\titer->cls_str = devargs_str + strlen(iter_anybus_str);\n+\t\tgoto end;\n+\t}\n+\n \t/* Split bus, device and parameters. */\n \tret = rte_devargs_parse(&devargs, devargs_str);\n \tif (ret != 0)\n@@ -259,6 +273,7 @@ rte_eth_iterator_init(struct rte_dev_iterator *iter, const char *devargs_str)\n \t}\n \titer->bus_str = bus_str;\n \n+end:\n \titer->cls = rte_class_find_by_name(\"eth\");\n \treturn 0;\n \n@@ -279,8 +294,10 @@ rte_eth_iterator_next(struct rte_dev_iterator *iter)\n \t\treturn RTE_MAX_ETHPORTS;\n \n \tdo { /* loop to try all matching rte_device */\n-\t\t/* If not in middle of rte_eth_dev iteration, */\n-\t\tif (iter->class_device == NULL) {\n+\t\t/* If not pure ethdev filter and */\n+\t\tif (iter->bus != NULL &&\n+\t\t\t\t/* not in middle of rte_eth_dev iteration, */\n+\t\t\t\titer->class_device == NULL) {\n \t\t\t/* get next rte_device to try. */\n \t\t\titer->device = iter->bus->dev_iterate(\n \t\t\t\t\titer->device, iter->bus_str, iter);\n@@ -292,7 +309,7 @@ rte_eth_iterator_next(struct rte_dev_iterator *iter)\n \t\t\t\titer->class_device, iter->cls_str, iter);\n \t\tif (iter->class_device != NULL)\n \t\t\treturn eth_dev_to_id(iter->class_device); /* match */\n-\t} while (1); /* need to try next rte_device */\n+\t} while (iter->bus != NULL); /* need to try next rte_device */\n \n \t/* No more ethdev port to iterate. */\n \trte_eth_iterator_cleanup(iter);\n@@ -302,6 +319,8 @@ rte_eth_iterator_next(struct rte_dev_iterator *iter)\n void __rte_experimental\n rte_eth_iterator_cleanup(struct rte_dev_iterator *iter)\n {\n+\tif (iter->bus_str == NULL)\n+\t\treturn; /* nothing to free in pure class filter */\n \tfree(RTE_CAST_FIELD(iter, bus_str, char *)); /* workaround const */\n \tfree(RTE_CAST_FIELD(iter, cls_str, char *)); /* workaround const */\n \tmemset(iter, 0, sizeof(*iter));\n", "prefixes": [ "v7", "3/7" ] }