Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/47211/?format=api
{ "id": 47211, "url": "http://patches.dpdk.org/api/patches/47211/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20181023073535.16441-1-alialnu@mellanox.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20181023073535.16441-1-alialnu@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20181023073535.16441-1-alialnu@mellanox.com", "date": "2018-10-23T07:35:50", "name": "test/test_external_mem: fix loop initialization", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "19199d3f7025f897887fb413f53676a0b37ea510", "submitter": { "id": 969, "url": "http://patches.dpdk.org/api/people/969/?format=api", "name": "Ali Alnubani", "email": "alialnu@mellanox.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20181023073535.16441-1-alialnu@mellanox.com/mbox/", "series": [ { "id": 2024, "url": "http://patches.dpdk.org/api/series/2024/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=2024", "date": "2018-10-23T07:35:50", "name": "test/test_external_mem: fix loop initialization", "version": 1, "mbox": "http://patches.dpdk.org/series/2024/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/47211/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/47211/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id AC6B71B1F6;\n\tTue, 23 Oct 2018 09:35:53 +0200 (CEST)", "from EUR03-VE1-obe.outbound.protection.outlook.com\n\t(mail-eopbgr50049.outbound.protection.outlook.com [40.107.5.49])\n\tby dpdk.org (Postfix) with ESMTP id 3B2381B1F5\n\tfor <dev@dpdk.org>; Tue, 23 Oct 2018 09:35:52 +0200 (CEST)", "from VI1PR05MB4269.eurprd05.prod.outlook.com (52.133.12.22) by\n\tVI1PR05MB5007.eurprd05.prod.outlook.com (20.177.52.28) with Microsoft\n\tSMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1250.30; Tue, 23 Oct 2018 07:35:50 +0000", "from VI1PR05MB4269.eurprd05.prod.outlook.com\n\t([fe80::68d6:1233:5e0c:143a]) by\n\tVI1PR05MB4269.eurprd05.prod.outlook.com\n\t([fe80::68d6:1233:5e0c:143a%4]) with mapi id 15.20.1250.028;\n\tTue, 23 Oct 2018 07:35:50 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n\ts=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=fr6/6X5popOAUriPlmM4OncT0WS5ORIWEOlifhoXf/A=;\n\tb=V4mQKEd+EqMkxjyRN1ld/7nB3BCxPlYPLKHoHJ9kTt5E/+deDX2mA6xfc4IG7kws7s5SGIwzAs7y5401MIgvdsVS8Pml81kNmkFD/yPVjFl2FAopezaml5VyYImyNEZMPzf1Jw5merudEBWVCgiEVa4FPv126PouabLDr5h/Jpc=", "From": "Ali Alnubani <alialnu@mellanox.com>", "To": "\"dev@dpdk.org\" <dev@dpdk.org>", "CC": "Thomas Monjalon <thomas@monjalon.net>, \"anatoly.burakov@intel.com\"\n\t<anatoly.burakov@intel.com>", "Thread-Topic": "[PATCH] test/test_external_mem: fix loop initialization", "Thread-Index": "AQHUaqMFnMrASqvy+Uu5r4dNpGC8Zw==", "Date": "Tue, 23 Oct 2018 07:35:50 +0000", "Message-ID": "<20181023073535.16441-1-alialnu@mellanox.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-mailer": "git-send-email 2.19.1", "x-clientproxiedby": "CWLP265CA0305.GBRP265.PROD.OUTLOOK.COM\n\t(2603:10a6:401:5d::29) To VI1PR05MB4269.eurprd05.prod.outlook.com\n\t(2603:10a6:803:40::22)", "authentication-results": "spf=none (sender IP is )\n\tsmtp.mailfrom=alialnu@mellanox.com; ", "x-ms-exchange-messagesentrepresentingtype": "1", "x-originating-ip": "[37.142.13.130]", "x-ms-publictraffictype": "Email", "x-microsoft-exchange-diagnostics": "1; VI1PR05MB5007;\n\t6:jhety/W72TEOQHSYJ0f916iT6j+pr7twzfIFQ+b2MspZVJQDr+86952O220W7w8J35gZVE7rNp5b2DDS3YlrkiFquT72gco7tXVLNL6MlqMDzeYw04QrT8iM3t5OyLiIWnqWn206WT5jpBLj5r+a20DvouVn9jy+PYjgwQksi4Z8ISts7rq2ek/0dN8rcI6hzFzITrzSLdJ0PsW89+vGvPumG7LCtzI/zRG2OZcyZmUz28LMJQge66EAxLG2nJSHfcDKXvaoS1DMKAdwf5sS9a3M0iXuE6QvSGXNtEUUXGxWcElrSEJbCAY7hP0YoVqx93IzW1TvyW5wW3Mj/RFdXo5Obb+hh+mF1DRFEdGsElHJArAIKNMOJ3qYKu/AJ2vce+Eiclne5qRITug0ZK0Hm7NlkIkoMPy6Y0d5phS5kmEegJSytKLb1aVnQ08OVixJs04RS2Kglr0gH4a/NfF28A==;\n\t5:FmMc8PiKuXNcrNhYB942ieGzzG4Nmhhf6bfT1aSzGH0SqCiFKo+uzhdSZqf+VB8nEUblm7Wlw0D8+UAaX1Kae8fxceJNTeksa/TBarCUG7HokUpLDU/d7q/5t2jL3Dbjm7+o/fcP0t4PoA/zmmT84SKP1+aoRGsNUYwr4OJ8YgM=;\n\t7:LrFWSC3fYHzsTV9f+u/IiUSbWW5DCyuPmnOJJcDU20Q0D5KTTGKah5t7yvWKl+GemnjBDR9qaDdR6+QW/4Cy64bDCCl0ky46IZa4Wz25giCCcLrsAN7YBgg2ZznmdhuXEAF5zXpW+EgkbaEe9Kwd1dyxs4VIcf2qbscgnub09AjHDvpO6ZILxzXwGEJwaQD/rHXcRXecv9HwmEsmcPt1G+fedM6EogiUEwAZEozpI2xZyXxvcMPecNKhl7XT4ROC", "x-ms-office365-filtering-correlation-id": "2f3174c8-f6b8-4c67-6bd8-08d638ba27a1", "x-ms-office365-filtering-ht": "Tenant", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020);\n\tSRVR:VI1PR05MB5007; ", "x-ms-traffictypediagnostic": "VI1PR05MB5007:", "x-ld-processed": "a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr", "x-microsoft-antispam-prvs": "<VI1PR05MB5007E583F2638B0CDD37040FD7F50@VI1PR05MB5007.eurprd05.prod.outlook.com>", "x-exchange-antispam-report-test": "UriScan:(228905959029699);", "x-ms-exchange-senderadcheck": "1", "x-exchange-antispam-report-cfa-test": "BCL:0; PCL:0;\n\tRULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3002001)(3231355)(944501410)(52105095)(6055026)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123560045)(20161123562045)(201708071742011)(7699051)(76991095);\n\tSRVR:VI1PR05MB5007; BCL:0; PCL:0; RULEID:; SRVR:VI1PR05MB5007; ", "x-forefront-prvs": "0834BAF534", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(396003)(136003)(376002)(39860400002)(346002)(366004)(199004)(189003)(54906003)(186003)(5250100002)(50226002)(316002)(8936002)(53936002)(2906002)(14444005)(256004)(105586002)(5660300001)(97736004)(25786009)(478600001)(4326008)(66066001)(2501003)(6116002)(305945005)(3846002)(7736002)(1076002)(14454004)(102836004)(6506007)(476003)(2616005)(5640700003)(2351001)(86362001)(486006)(6436002)(36756003)(52116002)(386003)(106356001)(1730700003)(26005)(8676002)(71200400001)(6916009)(6486002)(6512007)(1857600001)(71190400001)(2900100001)(81166006)(68736007)(99286004)(81156014);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB5007;\n\tH:VI1PR05MB4269.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en;\n\tPTR:InfoNoRecords; A:1; MX:1; ", "received-spf": "None (protection.outlook.com: mellanox.com does not designate\n\tpermitted sender hosts)", "x-microsoft-antispam-message-info": "1bALz3E5IlWdymnzLi08X0jqD8okQZ5IX53zqTM6Hq71YyevM8aaj+SFx00p4vHCFO22r1PcJDhWbc/8fRqtaqwcLHY4AzCqr+APAKLCZtgEzd1IVbBnIqDVcHvQU/a3fKVg0eiluWXBH/xcm3UI0Xfl+Y3vjTnTmbR1ymcEjW/5uAUGtVMT9BKHURjMFV+Lb98HnwmqCWOXlieEx7GHjaDgPoKXyiT3Q9fYXAIsXQ979UfFWRmF8d2J9SBPUdaQWyG1x8sWEapHHlYaTeFUCG55dp+QIVszVeCiTH3nmpJwWqH8wM8f9T0OaMKL/UyqF/xS6Jx9hWQU8TWFObS8hEMTEGmq7yBYgaRiyDUlYos=", "spamdiagnosticoutput": "1:99", "spamdiagnosticmetadata": "NSPM", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-ID": "<21A27D0F2926C346AF6065DB13626717@eurprd05.prod.outlook.com>", "Content-Transfer-Encoding": "base64", "MIME-Version": "1.0", "X-OriginatorOrg": "Mellanox.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "2f3174c8-f6b8-4c67-6bd8-08d638ba27a1", "X-MS-Exchange-CrossTenant-originalarrivaltime": "23 Oct 2018 07:35:50.6498\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "a652971c-7d2e-4d9b-a6a4-d149256f461b", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "VI1PR05MB5007", "Subject": "[dpdk-dev] [PATCH] test/test_external_mem: fix loop initialization", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Loop initial declarations are only allowed in C99 mode,\nwhich causes a compilation failure on non C99 compliant systems:\n\ntest/test/test_external_mem.c: In function ‘test_external_mem’:\ntest/test/test_external_mem.c:375:2: error: ‘for’\nloop initial declarations are only allowed in C99 mode\n for (int i = 0; i < n_pages; i++) {\n ^\n\nReproduces on RHEL 7.4 with GCC 4.8.5 20150623 (Red Hat 4.8.5-16).\n\nFixes: b270daa43b3d (\"test: support external memory\")\nCc: anatoly.burakov@intel.com\n\nSigned-off-by: Ali Alnubani <alialnu@mellanox.com>\n---\n test/test/test_external_mem.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/test/test/test_external_mem.c b/test/test/test_external_mem.c\r\nindex d0837aa35..d740960ce 100644\r\n--- a/test/test/test_external_mem.c\r\n+++ b/test/test/test_external_mem.c\r\n@@ -361,7 +361,7 @@ test_external_mem(void)\r\n \tsize_t pgsz = RTE_PGSIZE_4K;\r\n \trte_iova_t iova[len / pgsz];\r\n \tvoid *addr;\r\n-\tint ret, n_pages;\r\n+\tint ret, n_pages, i;\r\n \r\n \t/* create external memory area */\r\n \tn_pages = RTE_DIM(iova);\r\n@@ -372,7 +372,7 @@ test_external_mem(void)\r\n \t\t\t__func__, __LINE__);\r\n \t\treturn -1;\r\n \t}\r\n-\tfor (int i = 0; i < n_pages; i++) {\r\n+\tfor (i = 0; i < n_pages; i++) {\r\n \t\t/* arbitrary IOVA */\r\n \t\trte_iova_t tmp = 0x100000000 + i * pgsz;\r\n \t\tiova[i] = tmp;\r\n", "prefixes": [] }