Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 47194,
    "url": "http://patches.dpdk.org/api/patches/47194/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20181023005428.44547-1-xiaolong.ye@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20181023005428.44547-1-xiaolong.ye@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20181023005428.44547-1-xiaolong.ye@intel.com",
    "date": "2018-10-23T00:54:28",
    "name": "net/i40e: cancel alarm handler at the end of device closure",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "a5e6fe30c73e89c6fa3050c840943e7d725ec762",
    "submitter": {
        "id": 1120,
        "url": "http://patches.dpdk.org/api/people/1120/?format=api",
        "name": "Xiaolong Ye",
        "email": "xiaolong.ye@intel.com"
    },
    "delegate": {
        "id": 1540,
        "url": "http://patches.dpdk.org/api/users/1540/?format=api",
        "username": "qzhan15",
        "first_name": "Qi",
        "last_name": "Zhang",
        "email": "qi.z.zhang@intel.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20181023005428.44547-1-xiaolong.ye@intel.com/mbox/",
    "series": [
        {
            "id": 2016,
            "url": "http://patches.dpdk.org/api/series/2016/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=2016",
            "date": "2018-10-23T00:54:28",
            "name": "net/i40e: cancel alarm handler at the end of device closure",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/2016/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/47194/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/47194/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 972A01B12D;\n\tTue, 23 Oct 2018 02:54:35 +0200 (CEST)",
            "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id E3E135681;\n\tTue, 23 Oct 2018 02:54:32 +0200 (CEST)",
            "from fmsmga005.fm.intel.com ([10.253.24.32])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t22 Oct 2018 17:54:31 -0700",
            "from yexl-server.sh.intel.com ([10.67.110.207])\n\tby fmsmga005.fm.intel.com with ESMTP; 22 Oct 2018 17:54:30 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.54,414,1534834800\"; d=\"scan'208\";a=\"273583271\"",
        "From": "Xiaolong Ye <xiaolong.ye@intel.com>",
        "To": "Qi Zhang <qi.z.zhang@intel.com>,\n\tBeilei Xing <beilei.xing@intel.com>",
        "Cc": "dev@dpdk.org,\n\tXiaolong Ye <xiaolong.ye@intel.com>,\n\tstable@dpdk.org",
        "Date": "Tue, 23 Oct 2018 08:54:28 +0800",
        "Message-Id": "<20181023005428.44547-1-xiaolong.ye@intel.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "Subject": "[dpdk-dev] [PATCH] net/i40e: cancel alarm handler at the end of\n\tdevice closure",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Some operations in i40evf_dev_close like i40evf_dev_promiscuous_disable\nstill need alarm handler to clear the pending cmd, if alarm handler is\ncanceled in early stage of i40evf_dev_close, i40evf_dev_promiscuous_disable\nwill result in failure.\n\nFixes: 864a800d706d (\"net/i40e: remove VF interrupt handler\")\n\nCc: stable@dpdk.org\nSigned-off-by: Xiaolong Ye <xiaolong.ye@intel.com>\n---\n drivers/net/i40e/i40e_ethdev_vf.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)",
    "diff": "diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c\nindex baa6cc58f..52ae578d6 100644\n--- a/drivers/net/i40e/i40e_ethdev_vf.c\n+++ b/drivers/net/i40e/i40e_ethdev_vf.c\n@@ -2249,7 +2249,6 @@ i40evf_dev_close(struct rte_eth_dev *dev)\n {\n \tstruct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n \n-\trte_eal_alarm_cancel(i40evf_dev_alarm_handler, dev);\n \ti40evf_dev_stop(dev);\n \ti40e_dev_free_queues(dev);\n \t/*\n@@ -2263,6 +2262,7 @@ i40evf_dev_close(struct rte_eth_dev *dev)\n \ti40evf_reset_vf(hw);\n \ti40e_shutdown_adminq(hw);\n \ti40evf_disable_irq0(hw);\n+\trte_eal_alarm_cancel(i40evf_dev_alarm_handler, dev);\n }\n \n /*\n",
    "prefixes": []
}