Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/47064/?format=api
{ "id": 47064, "url": "http://patches.dpdk.org/api/patches/47064/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20181019020757.27698-3-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20181019020757.27698-3-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20181019020757.27698-3-thomas@monjalon.net", "date": "2018-10-19T02:07:53", "name": "[v6,2/6] app/testpmd: allow detaching a port not closed", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "a9868fb9b254506a52d791088dc487092e036392", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20181019020757.27698-3-thomas@monjalon.net/mbox/", "series": [ { "id": 1984, "url": "http://patches.dpdk.org/api/series/1984/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1984", "date": "2018-10-19T02:07:51", "name": "ethdev port freeing", "version": 6, "mbox": "http://patches.dpdk.org/series/1984/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/47064/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/47064/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B6B631B143;\n\tFri, 19 Oct 2018 04:08:10 +0200 (CEST)", "from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com\n\t[66.111.4.27]) by dpdk.org (Postfix) with ESMTP id CD6941B11A\n\tfor <dev@dpdk.org>; Fri, 19 Oct 2018 04:08:04 +0200 (CEST)", "from compute1.internal (compute1.nyi.internal [10.202.2.41])\n\tby mailout.nyi.internal (Postfix) with ESMTP id 5689122986;\n\tThu, 18 Oct 2018 22:08:03 -0400 (EDT)", "from mailfrontend2 ([10.202.2.163])\n\tby compute1.internal (MEProxy); Thu, 18 Oct 2018 22:08:03 -0400", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id 3E034102EE;\n\tThu, 18 Oct 2018 22:08:02 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n\tfrom:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding; s=mesmtp; bh=bzB+PY+TZI\n\t6TPHtbB+ZwWviAIhspa5uJEchh+O3t4xk=; b=KCECbVqKlRO9bzkmYDrNGYZoM2\n\tG+4DEq6uIVDhV2ZlJCldlu1YNpLa+35p+jZ3ybfWryQmcVUxMaY8EMlc1zM1mOTC\n\tNWKBU7CYtSAqyNt9xfvP38V7pEkW9f5AISxUGFBSBBUKe19BdF0uyNZ+M8/ZQ9+g\n\ta46enJNyvsaPYV1fE=", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:content-transfer-encoding:date:from\n\t:in-reply-to:message-id:mime-version:references:subject:to\n\t:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n\tfm1; bh=bzB+PY+TZI6TPHtbB+ZwWviAIhspa5uJEchh+O3t4xk=; b=Gh64Pcwl\n\tZBVs+ZgCjb4e2qoLNUe71pO0aeBK+mU0fOIDFXlIIOEQdhqt3uvkN09kvZPNGrUy\n\t8XYmK/0tqysFJ+bSX6LQxew2A99p/rh+9aHKCr/oFbAgsBekNduzNu6jZ0ZQZtIE\n\tcf35q5pkIPbii5buixlCfIV8hrVAgidjnvcO1hsvhUwhOr5J1metiq2ENbFq2g6n\n\tZXBchNAjPnoXbQ+wV0UJiT+h9Qn5COUosWc7vDFVDQVPQOEF3o/yMXDan4bY/FDV\n\tmmphEXGVnKGYqA3RwwGWLgVfivog4CHCxKlMnnTD/nBuRi+g+GxsIZRzdE+SMMoF\n\tozgFta6fwySjdw==" ], "X-ME-Sender": "<xms:gzzJW2DU6YHIxpIBLiuEE_-f4k6cjabXaf6RgnF1OXtu__On8Mzi0g>", "X-ME-Proxy": "<xmx:gzzJWyfo2VqpQ3Aun24gNHN6GUlTfl6aixQS3bYf1_JDDrzVEmXqJg>\n\t<xmx:gzzJW67ffmU-3OKCicoVzrrUM0qurq_-SLBqt-dY6Eq-3xjD1wcMtg>\n\t<xmx:gzzJW2emaZtHwrFH_9AQHrNb4c_vAacOnWN6F1DoEuqGFrD6MDPCpw>\n\t<xmx:gzzJWwkrzxq2Yz7_emqHVJmB2tDqYzWuM67sBU3d8JNA8MbmjEjb_Q>\n\t<xmx:gzzJW_YuHARm9oFcAtWdd2TD80VpRgEQWaVCnZaLIBRcYF9He27EGw>\n\t<xmx:gzzJWw5H2U-0RuO9zJ0qNZO0IxJp00dqMOx4IOWarc1_zrKQUsiWCg>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "ferruh.yigit@intel.com,\n\tarybchenko@solarflare.com", "Cc": "dev@dpdk.org, ophirmu@mellanox.com, bernard.iremonger@intel.com,\n\trahul.lakkireddy@chelsio.com", "Date": "Fri, 19 Oct 2018 04:07:53 +0200", "Message-Id": "<20181019020757.27698-3-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.19.0", "In-Reply-To": "<20181019020757.27698-1-thomas@monjalon.net>", "References": "<20180907233929.21950-1-thomas@monjalon.net>\n\t<20181019020757.27698-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v6 2/6] app/testpmd: allow detaching a port not\n\tclosed", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The testpmd application aim is for testing;\nso order of operations should not be enforced.\n\nThere was a test to forbid detaching before closing a port.\nHowever, it may interesting to test what happens in such case.\nIt is possible for a PMD to automatically close the port when detaching.\n\nin order to avoid a crash, it is checked that the port must be stopped\nbefore detaching (as for closing).\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n app/test-pmd/testpmd.c | 12 +++++++-----\n 1 file changed, 7 insertions(+), 5 deletions(-)", "diff": "diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\nindex 2c0b4a021..d5a8a14af 100644\n--- a/app/test-pmd/testpmd.c\n+++ b/app/test-pmd/testpmd.c\n@@ -2344,13 +2344,15 @@ detach_port(portid_t port_id)\n \tprintf(\"Detaching a port...\\n\");\n \n \tif (!port_is_closed(port_id)) {\n-\t\tprintf(\"Please close port first\\n\");\n-\t\treturn;\n+\t\tif (ports[port_id].port_status != RTE_PORT_STOPPED) {\n+\t\t\tprintf(\"Port not stopped\\n\");\n+\t\t\treturn;\n+\t\t}\n+\t\tprintf(\"Port was not closed\\n\");\n+\t\tif (ports[port_id].flow_list)\n+\t\t\tport_flow_flush(port_id);\n \t}\n \n-\tif (ports[port_id].flow_list)\n-\t\tport_flow_flush(port_id);\n-\n \tif (rte_eth_dev_detach(port_id, name)) {\n \t\tTESTPMD_LOG(ERR, \"Failed to detach port %u\\n\", port_id);\n \t\treturn;\n", "prefixes": [ "v6", "2/6" ] }