Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 47028,
    "url": "http://patches.dpdk.org/api/patches/47028/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1539844035-11524-1-git-send-email-jia.guo@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1539844035-11524-1-git-send-email-jia.guo@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1539844035-11524-1-git-send-email-jia.guo@intel.com",
    "date": "2018-10-18T06:27:15",
    "name": "[v1] igb_uio: fix unexpected removal for hot-unplug",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "b7a5943623da36accc3bf950f17da8ed0980895c",
    "submitter": {
        "id": 507,
        "url": "http://patches.dpdk.org/api/people/507/?format=api",
        "name": "Guo, Jia",
        "email": "jia.guo@intel.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1539844035-11524-1-git-send-email-jia.guo@intel.com/mbox/",
    "series": [
        {
            "id": 1968,
            "url": "http://patches.dpdk.org/api/series/1968/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1968",
            "date": "2018-10-18T06:27:15",
            "name": "[v1] igb_uio: fix unexpected removal for hot-unplug",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/1968/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/47028/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/47028/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0BBC65F28;\n\tThu, 18 Oct 2018 08:30:30 +0200 (CEST)",
            "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n\tby dpdk.org (Postfix) with ESMTP id 39C125F27\n\tfor <dev@dpdk.org>; Thu, 18 Oct 2018 08:30:28 +0200 (CEST)",
            "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t17 Oct 2018 23:30:27 -0700",
            "from jeffguo-z170x-ud5.sh.intel.com ([10.67.104.10])\n\tby fmsmga001.fm.intel.com with ESMTP; 17 Oct 2018 23:30:25 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.54,395,1534834800\"; d=\"scan'208\";a=\"100227717\"",
        "From": "Jeff Guo <jia.guo@intel.com>",
        "To": "stephen@networkplumber.org, bruce.richardson@intel.com,\n\tferruh.yigit@intel.com, konstantin.ananyev@intel.com,\n\tthomas@monjalon.net, shaopeng.he@intel.com",
        "Cc": "dev@dpdk.org,\n\tjia.guo@intel.com,\n\thelin.zhang@intel.com",
        "Date": "Thu, 18 Oct 2018 14:27:15 +0800",
        "Message-Id": "<1539844035-11524-1-git-send-email-jia.guo@intel.com>",
        "X-Mailer": "git-send-email 2.7.4",
        "In-Reply-To": "<1534502916-31636-9-git-send-email-jia.guo@intel.com>",
        "References": "<1534502916-31636-9-git-send-email-jia.guo@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v1] igb_uio: fix unexpected removal for hot-unplug",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "When a device is hot-unplugged, pci_remove will be invoked unexpectedly\nbefore pci_release, it will caused kernel hung issue which will throw the\nerror info of \"Trying to free already-free IRQ XXX\". And on the other hand,\nif pci_remove before pci_release, the interrupt will not got chance to be\ndisabled. So this patch aim to fix this issue by adding pci_release call\nin pci_remove, it will gurranty that all pci clean up will be done before\npci removal.\n\nSigned-off-by: Jeff Guo <jia.guo@intel.com>\n---\n kernel/linux/igb_uio/igb_uio.c | 2 ++\n 1 file changed, 2 insertions(+)",
    "diff": "diff --git a/kernel/linux/igb_uio/igb_uio.c b/kernel/linux/igb_uio/igb_uio.c\nindex fede66c..3cf394b 100644\n--- a/kernel/linux/igb_uio/igb_uio.c\n+++ b/kernel/linux/igb_uio/igb_uio.c\n@@ -570,6 +570,8 @@ igbuio_pci_remove(struct pci_dev *dev)\n {\n \tstruct rte_uio_pci_dev *udev = pci_get_drvdata(dev);\n \n+\tigbuio_pci_release(&udev->info, NULL);\n+\n \tsysfs_remove_group(&dev->dev.kobj, &dev_attr_grp);\n \tuio_unregister_device(&udev->info);\n \tigbuio_pci_release_iomem(&udev->info);\n",
    "prefixes": [
        "v1"
    ]
}