Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 46884,
    "url": "http://patches.dpdk.org/api/patches/46884/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1539684892-19831-1-git-send-email-phil.yang@arm.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1539684892-19831-1-git-send-email-phil.yang@arm.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1539684892-19831-1-git-send-email-phil.yang@arm.com",
    "date": "2018-10-16T10:14:52",
    "name": "app/testpmd: fix physic port socket initialization",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "df02925358f693f2d966fc31bd4e71364ccee2f9",
    "submitter": {
        "id": 833,
        "url": "http://patches.dpdk.org/api/people/833/?format=api",
        "name": "Phil Yang",
        "email": "phil.yang@arm.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1539684892-19831-1-git-send-email-phil.yang@arm.com/mbox/",
    "series": [
        {
            "id": 1918,
            "url": "http://patches.dpdk.org/api/series/1918/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1918",
            "date": "2018-10-16T10:14:52",
            "name": "app/testpmd: fix physic port socket initialization",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/1918/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/46884/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/46884/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DA119239;\n\tTue, 16 Oct 2018 12:15:06 +0200 (CEST)",
            "from foss.arm.com (foss.arm.com [217.140.101.70])\n\tby dpdk.org (Postfix) with ESMTP id 98C92160\n\tfor <dev@dpdk.org>; Tue, 16 Oct 2018 12:15:05 +0200 (CEST)",
            "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249])\n\tby usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CFD76341;\n\tTue, 16 Oct 2018 03:15:04 -0700 (PDT)",
            "from phil-VirtualBox.shanghai.arm.com (unknown [10.169.107.186])\n\tby usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id\n\t2D1053F59C; Tue, 16 Oct 2018 03:15:04 -0700 (PDT)"
        ],
        "From": "Phil Yang <phil.yang@arm.com>",
        "To": "dev@dpdk.org",
        "Cc": "ferruh.yigit@intel.com,\n\tnd@arm.com",
        "Date": "Tue, 16 Oct 2018 18:14:52 +0800",
        "Message-Id": "<1539684892-19831-1-git-send-email-phil.yang@arm.com>",
        "X-Mailer": "git-send-email 2.7.4",
        "Subject": "[dpdk-dev] [PATCH] app/testpmd: fix physic port socket\n\tinitialization",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Once the lcore list setting excluded the socket which physic device\nattached, it will cause failure. Meanwhile, it will disable Testpmd\ncross NUMA scenario.\n\nFixes: dbfb8ec (\"app/testpmd: optimize mbuf pool allocation\")\n\nSigned-off-by: Phil Yang <phil.yang@arm.com>\nReviewed-by: Gavin Hu <Gavin.Hu@arm.com>\n---\n app/test-pmd/testpmd.c | 14 +++++++++++++-\n 1 file changed, 13 insertions(+), 1 deletion(-)",
    "diff": "diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\nindex 5dbbf78..4739ddb 100644\n--- a/app/test-pmd/testpmd.c\n+++ b/app/test-pmd/testpmd.c\n@@ -565,9 +565,21 @@ set_default_fwd_ports_config(void)\n \tportid_t pt_id;\n \tint i = 0;\n \n-\tRTE_ETH_FOREACH_DEV(pt_id)\n+\tRTE_ETH_FOREACH_DEV(pt_id) {\n \t\tfwd_ports_ids[i++] = pt_id;\n \n+\t\t/* Update sockets info according to the attached device */\n+\t\tint socket_id = rte_eth_dev_socket_id(pt_id);\n+\t\tif (socket_id >= 0 && new_socket_id(pt_id)) {\n+\t\t\tif (num_sockets >= RTE_MAX_NUMA_NODES) {\n+\t\t\t\trte_exit(EXIT_FAILURE,\n+\t\t\t\t\t \"Total sockets greater than %u\\n\",\n+\t\t\t\t\t RTE_MAX_NUMA_NODES);\n+\t\t\t}\n+\t\t\tsocket_ids[num_sockets++] = socket_id;\n+\t\t}\n+\t}\n+\n \tnb_cfg_ports = nb_ports;\n \tnb_fwd_ports = nb_ports;\n }\n",
    "prefixes": []
}