Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/46780/?format=api
{ "id": 46780, "url": "http://patches.dpdk.org/api/patches/46780/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20181012234252.29049-4-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20181012234252.29049-4-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20181012234252.29049-4-stephen@networkplumber.org", "date": "2018-10-12T23:42:52", "name": "[3/3] qede: remove #ifdef for INIT_DEBUG", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "40796998c8f0974490ec47d0691c4c9de1444559", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20181012234252.29049-4-stephen@networkplumber.org/mbox/", "series": [ { "id": 1881, "url": "http://patches.dpdk.org/api/series/1881/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1881", "date": "2018-10-12T23:42:49", "name": "leftover INIT_DEBUG stuff", "version": 1, "mbox": "http://patches.dpdk.org/series/1881/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/46780/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/46780/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 165A91B3FD;\n\tSat, 13 Oct 2018 01:43:10 +0200 (CEST)", "from mail-pf1-f195.google.com (mail-pf1-f195.google.com\n\t[209.85.210.195]) by dpdk.org (Postfix) with ESMTP id 8A71B1B17E\n\tfor <dev@dpdk.org>; Sat, 13 Oct 2018 01:43:04 +0200 (CEST)", "by mail-pf1-f195.google.com with SMTP id p24-v6so6910014pff.10\n\tfor <dev@dpdk.org>; Fri, 12 Oct 2018 16:43:04 -0700 (PDT)", "from xeon-e3.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tq76-v6sm7099938pfa.18.2018.10.12.16.43.02\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 12 Oct 2018 16:43:02 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=RjRnEkNk6CC/EUTVBxwdJeLEdKN48L6xVBkeJioxMGw=;\n\tb=dnkoM3lt10TOumypvZ0Utnc/o+XLbwJ83mCVlxFYbX97pw484ns268+SXLmJqTshne\n\tDb0HA4J9rybXPY99ldqb+wxTOiQS71kng8rMH9w6Aw0PBkXox2DSnuXj6AhgOeN3G7kH\n\tdcFVhAGj5ID49WxRODUaoHsTC/PNqnbPam6B/jewL8vk9+gPzBpOP2akc74qbqB+TBh9\n\tl/Y454orIaTXxyYQW88ibe07DIxgrklANSXOrFPVaQvyxseTGiKb8Y/oZ47iapLf/59F\n\tanaQnwqZiKnkX0hHaWP/S+l34SRVDARYMnpIDkn1ISnl4Z7SC7h2VBmNdneiWxMsRwK6\n\tqzug==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=RjRnEkNk6CC/EUTVBxwdJeLEdKN48L6xVBkeJioxMGw=;\n\tb=mr07om8X5tLWChdtJV3mvrMSARyrKt/0pUZl9WbofAO/N2X7Mn8b2GVU0nNuMRWc7n\n\tfz0pvXrZ1BDTxwlNWwEKgc45kbeSB5Uv0aNArl/FA8fToTyue4E/D9aDdffjXfDbigMQ\n\tXrote/D6naPJAXWhpEYVgYNUcJBbnyxgrx+Jj3SVNIIx4vGx/9CfcxV79BCpa+YImBiG\n\tGHTZHhrW4IklRjZPINZGuH0aJ7+XL0obxWBVSbHejKuie62RQOGbuCGEa1MmVxC+QBwC\n\tioEcjzueM6zaOKMOmysbraCuudpxy9PiiozRkd20O2uK0LT+X99IwSyQYiW7sdVTYcfn\n\t5pxA==", "X-Gm-Message-State": "ABuFfojEE5QWIkBmL6+vhQLQp9maI64ovExikbvoEpPYZlgNbQpRTDia\n\tfdWEp29NwC1hqOAyKFGWjl6BN5AppK8=", "X-Google-Smtp-Source": "ACcGV6323OExwnovEtq3n0rql0hgk4SWyi6xCIkw+qOQTHs2bsq1Ylp4x3+CZiYAxgHWh0Ejt2F6NQ==", "X-Received": "by 2002:a63:ea07:: with SMTP id\n\tc7-v6mr6964926pgi.361.1539387783232; \n\tFri, 12 Oct 2018 16:43:03 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Fri, 12 Oct 2018 16:42:52 -0700", "Message-Id": "<20181012234252.29049-4-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.19.1", "In-Reply-To": "<20181012234252.29049-1-stephen@networkplumber.org>", "References": "<20181012234252.29049-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 3/3] qede: remove #ifdef for INIT_DEBUG", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Now that logging of initialization is controlled by dynamic debug\nlevel, remove the #ifdef for RTE_LIBRTE_QEDE_DEBUG_INIT since that\nconfig option does not exist in common_base and is not documented.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/qede/qede_ethdev.c | 9 +--------\n 1 file changed, 1 insertion(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c\nindex 18d244a9367c..5745832b98a3 100644\n--- a/drivers/net/qede/qede_ethdev.c\n+++ b/drivers/net/qede/qede_ethdev.c\n@@ -1380,14 +1380,11 @@ qede_link_update(struct rte_eth_dev *eth_dev, __rte_unused int wait_to_complete)\n \n static void qede_promiscuous_enable(struct rte_eth_dev *eth_dev)\n {\n-#ifdef RTE_LIBRTE_QEDE_DEBUG_INIT\n \tstruct qede_dev *qdev = eth_dev->data->dev_private;\n \tstruct ecore_dev *edev = &qdev->edev;\n+\tenum qed_filter_rx_mode_type type = QED_FILTER_RX_MODE_TYPE_PROMISC;\n \n \tPMD_INIT_FUNC_TRACE(edev);\n-#endif\n-\n-\tenum qed_filter_rx_mode_type type = QED_FILTER_RX_MODE_TYPE_PROMISC;\n \n \tif (rte_eth_allmulticast_get(eth_dev->data->port_id) == 1)\n \t\ttype |= QED_FILTER_RX_MODE_TYPE_MULTI_PROMISC;\n@@ -1397,12 +1394,10 @@ static void qede_promiscuous_enable(struct rte_eth_dev *eth_dev)\n \n static void qede_promiscuous_disable(struct rte_eth_dev *eth_dev)\n {\n-#ifdef RTE_LIBRTE_QEDE_DEBUG_INIT\n \tstruct qede_dev *qdev = eth_dev->data->dev_private;\n \tstruct ecore_dev *edev = &qdev->edev;\n \n \tPMD_INIT_FUNC_TRACE(edev);\n-#endif\n \n \tif (rte_eth_allmulticast_get(eth_dev->data->port_id) == 1)\n \t\tqed_configure_filter_rx_mode(eth_dev,\n@@ -2648,12 +2643,10 @@ static int qede_eth_dev_init(struct rte_eth_dev *eth_dev)\n \n static int qede_dev_common_uninit(struct rte_eth_dev *eth_dev)\n {\n-#ifdef RTE_LIBRTE_QEDE_DEBUG_INIT\n \tstruct qede_dev *qdev = eth_dev->data->dev_private;\n \tstruct ecore_dev *edev = &qdev->edev;\n \n \tPMD_INIT_FUNC_TRACE(edev);\n-#endif\n \n \t/* only uninitialize in the primary process */\n \tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n", "prefixes": [ "3/3" ] }