Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/46610/?format=api
http://patches.dpdk.org/api/patches/46610/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1539258078-85906-3-git-send-email-cristian.dumitrescu@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1539258078-85906-3-git-send-email-cristian.dumitrescu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1539258078-85906-3-git-send-email-cristian.dumitrescu@intel.com", "date": "2018-10-11T11:41:13", "name": "[v4,3/8] net/softnic: add support for packet tag table action", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "cf96a09b046db503456884bb53b40b7d299802fa", "submitter": { "id": 19, "url": "http://patches.dpdk.org/api/people/19/?format=api", "name": "Cristian Dumitrescu", "email": "cristian.dumitrescu@intel.com" }, "delegate": { "id": 10018, "url": "http://patches.dpdk.org/api/users/10018/?format=api", "username": "cristian_dumitrescu", "first_name": "Cristian", "last_name": "Dumitrescu", "email": "cristian.dumitrescu@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1539258078-85906-3-git-send-email-cristian.dumitrescu@intel.com/mbox/", "series": [ { "id": 1834, "url": "http://patches.dpdk.org/api/series/1834/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1834", "date": "2018-10-11T11:41:12", "name": "[v4,1/8] pipeline: add table action for packet tag", "version": 4, "mbox": "http://patches.dpdk.org/series/1834/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/46610/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/46610/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2CF671B585;\n\tThu, 11 Oct 2018 13:42:00 +0200 (CEST)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n\tby dpdk.org (Postfix) with ESMTP id EC3F81B544\n\tfor <dev@dpdk.org>; Thu, 11 Oct 2018 13:41:47 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t11 Oct 2018 04:41:44 -0700", "from silpixa00382658.ir.intel.com ([10.237.223.29])\n\tby fmsmga002.fm.intel.com with ESMTP; 11 Oct 2018 04:41:36 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.54,368,1534834800\"; d=\"scan'208\";a=\"94289058\"", "From": "Cristian Dumitrescu <cristian.dumitrescu@intel.com>", "To": "dev@dpdk.org", "Date": "Thu, 11 Oct 2018 12:41:13 +0100", "Message-Id": "<1539258078-85906-3-git-send-email-cristian.dumitrescu@intel.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1539258078-85906-1-git-send-email-cristian.dumitrescu@intel.com>", "References": "<1539258078-85906-1-git-send-email-cristian.dumitrescu@intel.com>", "Subject": "[dpdk-dev] [PATCH v4 3/8] net/softnic: add support for packet tag\n\ttable action", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add support for packet tag table action.\n\nSigned-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>\n---\n drivers/net/softnic/rte_eth_softnic_action.c | 11 +++++++\n drivers/net/softnic/rte_eth_softnic_cli.c | 38 +++++++++++++++++++++++++\n drivers/net/softnic/rte_eth_softnic_internals.h | 1 +\n drivers/net/softnic/rte_eth_softnic_thread.c | 10 +++++++\n 4 files changed, 60 insertions(+)", "diff": "diff --git a/drivers/net/softnic/rte_eth_softnic_action.c b/drivers/net/softnic/rte_eth_softnic_action.c\nindex c542688..133dd06 100644\n--- a/drivers/net/softnic/rte_eth_softnic_action.c\n+++ b/drivers/net/softnic/rte_eth_softnic_action.c\n@@ -364,6 +364,17 @@ softnic_table_action_profile_create(struct pmd_internals *p,\n \t\t}\n \t}\n \n+\tif (params->action_mask & (1LLU << RTE_TABLE_ACTION_TAG)) {\n+\t\tstatus = rte_table_action_profile_action_register(ap,\n+\t\t\tRTE_TABLE_ACTION_TAG,\n+\t\t\tNULL);\n+\n+\t\tif (status) {\n+\t\t\trte_table_action_profile_free(ap);\n+\t\t\treturn NULL;\n+\t\t}\n+\t}\n+\n \tstatus = rte_table_action_profile_freeze(ap);\n \tif (status) {\n \t\trte_table_action_profile_free(ap);\ndiff --git a/drivers/net/softnic/rte_eth_softnic_cli.c b/drivers/net/softnic/rte_eth_softnic_cli.c\nindex dc8ccdc..31c37da 100644\n--- a/drivers/net/softnic/rte_eth_softnic_cli.c\n+++ b/drivers/net/softnic/rte_eth_softnic_cli.c\n@@ -1279,6 +1279,7 @@ cmd_port_in_action_profile(struct pmd_internals *softnic,\n * stats none | pkts]\n * [stats pkts | bytes | both]\n * [time]\n+ * [tag]\n */\n static void\n cmd_table_action_profile(struct pmd_internals *softnic,\n@@ -1610,6 +1611,12 @@ cmd_table_action_profile(struct pmd_internals *softnic,\n \t\tt0 += 1;\n \t} /* time */\n \n+\tif (t0 < n_tokens &&\n+\t\t(strcmp(tokens[t0], \"tag\") == 0)) {\n+\t\tp.action_mask |= 1LLU << RTE_TABLE_ACTION_TAG;\n+\t\tt0 += 1;\n+\t} /* tag */\n+\n \tif (t0 < n_tokens) {\n \t\tsnprintf(out, out_size, MSG_ARG_MISMATCH, tokens[0]);\n \t\treturn;\n@@ -3176,6 +3183,7 @@ parse_match(char **tokens,\n * [ttl dec | keep]\n * [stats]\n * [time]\n+ * [tag <tag>]\n *\n * where:\n * <pa> ::= g | y | r | drop\n@@ -3666,6 +3674,22 @@ parse_table_action_time(char **tokens,\n }\n \n static uint32_t\n+parse_table_action_tag(char **tokens,\n+\tuint32_t n_tokens,\n+\tstruct softnic_table_rule_action *a)\n+{\n+\tif (n_tokens < 2 ||\n+\t\tstrcmp(tokens[0], \"tag\"))\n+\t\treturn 0;\n+\n+\tif (softnic_parser_read_uint32(&a->tag.tag, tokens[1]))\n+\t\treturn 0;\n+\n+\ta->action_mask |= 1 << RTE_TABLE_ACTION_TAG;\n+\treturn 2;\n+}\n+\n+static uint32_t\n parse_table_action(char **tokens,\n \tuint32_t n_tokens,\n \tchar *out,\n@@ -3809,6 +3833,20 @@ parse_table_action(char **tokens,\n \t\tn_tokens -= n;\n \t}\n \n+\tif (n_tokens && (strcmp(tokens[0], \"tag\") == 0)) {\n+\t\tuint32_t n;\n+\n+\t\tn = parse_table_action_tag(tokens, n_tokens, a);\n+\t\tif (n == 0) {\n+\t\t\tsnprintf(out, out_size, MSG_ARG_INVALID,\n+\t\t\t\t\"action tag\");\n+\t\t\treturn 0;\n+\t\t}\n+\n+\t\ttokens += n;\n+\t\tn_tokens -= n;\n+\t}\n+\n \tif (n_tokens0 - n_tokens == 1) {\n \t\tsnprintf(out, out_size, MSG_ARG_INVALID, \"action\");\n \t\treturn 0;\ndiff --git a/drivers/net/softnic/rte_eth_softnic_internals.h b/drivers/net/softnic/rte_eth_softnic_internals.h\nindex 78864e7..1623ff8 100644\n--- a/drivers/net/softnic/rte_eth_softnic_internals.h\n+++ b/drivers/net/softnic/rte_eth_softnic_internals.h\n@@ -897,6 +897,7 @@ struct softnic_table_rule_action {\n \tstruct rte_table_action_ttl_params ttl;\n \tstruct rte_table_action_stats_params stats;\n \tstruct rte_table_action_time_params time;\n+\tstruct rte_table_action_tag_params tag;\n };\n \n struct rte_flow {\ndiff --git a/drivers/net/softnic/rte_eth_softnic_thread.c b/drivers/net/softnic/rte_eth_softnic_thread.c\nindex 87b5592..e1d002e 100644\n--- a/drivers/net/softnic/rte_eth_softnic_thread.c\n+++ b/drivers/net/softnic/rte_eth_softnic_thread.c\n@@ -2478,6 +2478,16 @@ action_convert(struct rte_table_action *a,\n \t\t\treturn status;\n \t}\n \n+\tif (action->action_mask & (1LLU << RTE_TABLE_ACTION_TAG)) {\n+\t\tstatus = rte_table_action_apply(a,\n+\t\t\tdata,\n+\t\t\tRTE_TABLE_ACTION_TAG,\n+\t\t\t&action->tag);\n+\n+\t\tif (status)\n+\t\t\treturn status;\n+\t}\n+\n \treturn 0;\n }\n \n", "prefixes": [ "v4", "3/8" ] }{ "id": 46610, "url": "