Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/46401/?format=api
{ "id": 46401, "url": "http://patches.dpdk.org/api/patches/46401/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20181009173838.60369-1-ferruh.yigit@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20181009173838.60369-1-ferruh.yigit@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20181009173838.60369-1-ferruh.yigit@intel.com", "date": "2018-10-09T17:38:37", "name": "[v2] drivers/net: fix log type string", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "19e6b98ee14362947fc98e9f4b3e1d3017dba4f9", "submitter": { "id": 324, "url": "http://patches.dpdk.org/api/people/324/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@intel.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20181009173838.60369-1-ferruh.yigit@intel.com/mbox/", "series": [ { "id": 1783, "url": "http://patches.dpdk.org/api/series/1783/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1783", "date": "2018-10-09T17:38:37", "name": "[v2] drivers/net: fix log type string", "version": 2, "mbox": "http://patches.dpdk.org/series/1783/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/46401/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/46401/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id EE7811B5F3;\n\tTue, 9 Oct 2018 18:39:05 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id 365E91B5F2;\n\tTue, 9 Oct 2018 18:39:03 +0200 (CEST)", "from orsmga004.jf.intel.com ([10.7.209.38])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t09 Oct 2018 09:39:03 -0700", "from silpixa00399752.ir.intel.com (HELO\n\tsilpixa00399752.ger.corp.intel.com) ([10.237.222.212])\n\tby orsmga004.jf.intel.com with ESMTP; 09 Oct 2018 09:38:52 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.54,360,1534834800\"; d=\"scan'208\";a=\"239864287\"", "From": "Ferruh Yigit <ferruh.yigit@intel.com>", "To": "John McNamara <john.mcnamara@intel.com>,\n\tMarko Kovacevic <marko.kovacevic@intel.com>,\n\tHemant Agrawal <hemant.agrawal@nxp.com>,\n\tShreyansh Jain <shreyansh.jain@nxp.com>,\n\tAjit Khaparde <ajit.khaparde@broadcom.com>,\n\tSomnath Kotur <somnath.kotur@broadcom.com>,\n\tDeclan Doherty <declan.doherty@intel.com>,\n\tChas Williams <chas3@att.com>, Matan Azrad <matan@mellanox.com>", "Cc": "dev@dpdk.org,\n\tFerruh Yigit <ferruh.yigit@intel.com>,\n\tstable@dpdk.org", "Date": "Tue, 9 Oct 2018 18:38:37 +0100", "Message-Id": "<20181009173838.60369-1-ferruh.yigit@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20181009115238.91288-1-ferruh.yigit@intel.com>", "References": "<20181009115238.91288-1-ferruh.yigit@intel.com>", "Subject": "[dpdk-dev] [PATCH v2] drivers/net: fix log type string", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Syntax for log type string is \"pmd.<subsystem>.<driver>[.<pmd_local>]\"\n\nFixes: 3e92fd4e4ec0 (\"net/bnxt: use dynamic log type\")\nFixes: d7f4562ab10a (\"net/bonding: convert to dynamic logging\")\nFixes: 6086ab3bb3d2 (\"net/vdev_netvsc: introduce Hyper-V platform driver\")\nFixes: 7db274b9ada2 (\"doc: describe dynamic logging format\")\nFixes: a10a988a0ba6 (\"net/dpaa2: support dynamic logging\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ferruh Yigit <ferruh.yigit@intel.com>\nAcked-by: Stephen Hemminger <stephen@networkplumber.org>\n---\nv2:\n* update doc too\n---\n doc/guides/contributing/coding_style.rst | 4 ++--\n doc/guides/nics/dpaa2.rst | 2 +-\n drivers/net/bnxt/bnxt_ethdev.c | 2 +-\n drivers/net/bonding/rte_eth_bond_pmd.c | 2 +-\n drivers/net/vdev_netvsc/vdev_netvsc.c | 2 +-\n 5 files changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/doc/guides/contributing/coding_style.rst b/doc/guides/contributing/coding_style.rst\nindex b1bf0d15c..19445c113 100644\n--- a/doc/guides/contributing/coding_style.rst\n+++ b/doc/guides/contributing/coding_style.rst\n@@ -741,8 +741,8 @@ A specialization looks like this:\n * PF/VF mailbox output: ``type.section.name.mbox``\n \n A real world example is the i40e poll mode driver which exposes two\n-specializations, one for initialization ``pmd.i40e.init`` and the other for\n-the remaining driver logs ``pmd.i40e.driver``.\n+specializations, one for initialization ``pmd.net.i40e.init`` and the other for\n+the remaining driver logs ``pmd.net.i40e.driver``.\n \n Note that specializations have no formatting rules, but please follow\n a precedent if one exists. In order to see all current log topics and\ndiff --git a/doc/guides/nics/dpaa2.rst b/doc/guides/nics/dpaa2.rst\nindex 66c03e103..e2f385d42 100644\n--- a/doc/guides/nics/dpaa2.rst\n+++ b/doc/guides/nics/dpaa2.rst\n@@ -558,7 +558,7 @@ which are lower than logging ``level``.\n \n <dpdk app> <EAL args> --log-level=pmd.net.dpaa2:<level> -- ...\n \n-Using ``pmd.dpaa2`` as log matching criteria, all PMD logs can be enabled\n+Using ``pmd.net.dpaa2`` as log matching criteria, all PMD logs can be enabled\n which are lower than logging ``level``.\n \n Whitelisting & Blacklisting\ndiff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 88e026c7d..858e65d00 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -3569,7 +3569,7 @@ bool is_bnxt_supported(struct rte_eth_dev *dev)\n \n RTE_INIT(bnxt_init_log)\n {\n-\tbnxt_logtype_driver = rte_log_register(\"pmd.bnxt.driver\");\n+\tbnxt_logtype_driver = rte_log_register(\"pmd.net.bnxt.driver\");\n \tif (bnxt_logtype_driver >= 0)\n \t\trte_log_set_level(bnxt_logtype_driver, RTE_LOG_INFO);\n }\ndiff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c\nindex a7b592eed..544e0cde4 100644\n--- a/drivers/net/bonding/rte_eth_bond_pmd.c\n+++ b/drivers/net/bonding/rte_eth_bond_pmd.c\n@@ -3598,7 +3598,7 @@ int bond_logtype;\n \n RTE_INIT(bond_init_log)\n {\n-\tbond_logtype = rte_log_register(\"pmd.net.bon\");\n+\tbond_logtype = rte_log_register(\"pmd.net.bond\");\n \tif (bond_logtype >= 0)\n \t\trte_log_set_level(bond_logtype, RTE_LOG_NOTICE);\n }\ndiff --git a/drivers/net/vdev_netvsc/vdev_netvsc.c b/drivers/net/vdev_netvsc/vdev_netvsc.c\nindex 48717f2f0..16303ef5e 100644\n--- a/drivers/net/vdev_netvsc/vdev_netvsc.c\n+++ b/drivers/net/vdev_netvsc/vdev_netvsc.c\n@@ -789,7 +789,7 @@ RTE_PMD_REGISTER_PARAM_STRING(net_vdev_netvsc,\n /** Initialize driver log type. */\n RTE_INIT(vdev_netvsc_init_log)\n {\n-\tvdev_netvsc_logtype = rte_log_register(\"pmd.vdev_netvsc\");\n+\tvdev_netvsc_logtype = rte_log_register(\"pmd.net.vdev_netvsc\");\n \tif (vdev_netvsc_logtype >= 0)\n \t\trte_log_set_level(vdev_netvsc_logtype, RTE_LOG_NOTICE);\n }\n", "prefixes": [ "v2" ] }