Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/46312/?format=api
{ "id": 46312, "url": "http://patches.dpdk.org/api/patches/46312/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20181009021858.19216-4-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20181009021858.19216-4-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20181009021858.19216-4-thomas@monjalon.net", "date": "2018-10-09T02:18:57", "name": "[3/4] ethdev: move representor parsing functions", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "0266161df83f9a716ede9b0a73c9eb99b4f8e44a", "submitter": { "id": 685, "url": "http://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20181009021858.19216-4-thomas@monjalon.net/mbox/", "series": [ { "id": 1767, "url": "http://patches.dpdk.org/api/series/1767/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1767", "date": "2018-10-09T02:18:54", "name": "support more ethdev iterator filters", "version": 1, "mbox": "http://patches.dpdk.org/series/1767/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/46312/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/46312/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5F9D91B1C3;\n\tTue, 9 Oct 2018 04:19:12 +0200 (CEST)", "from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com\n\t[66.111.4.27]) by dpdk.org (Postfix) with ESMTP id A72FC1B152\n\tfor <dev@dpdk.org>; Tue, 9 Oct 2018 04:19:07 +0200 (CEST)", "from compute1.internal (compute1.nyi.internal [10.202.2.41])\n\tby mailout.nyi.internal (Postfix) with ESMTP id 4B4E22210E;\n\tMon, 8 Oct 2018 22:19:07 -0400 (EDT)", "from mailfrontend2 ([10.202.2.163])\n\tby compute1.internal (MEProxy); Mon, 08 Oct 2018 22:19:07 -0400", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id 1B0B6102ED;\n\tMon, 8 Oct 2018 22:19:06 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n\tfrom:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding; s=mesmtp; bh=sBFu624hED\n\t8Qtm7lkrfMwBEOfeF0SwR9u9NscwptKzA=; b=Z5fJ7CkfBvZsJim8E/Ftk5kD7S\n\t02m7GMKsmzW/O9+ZW4+JQhinc6gqY7m+IDrsVjej2X47xpzd+zpREL6ZOu38catW\n\tvQ/x27VNfw5mwDA4cAYAQh1hyUDZYQAtCG09FUH4jtbheQkRewGr1q4cQxTk7JNp\n\t5xd9ky/yAG9+veUIU=", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:content-transfer-encoding:date:from\n\t:in-reply-to:message-id:mime-version:references:subject:to\n\t:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n\tfm3; bh=sBFu624hED8Qtm7lkrfMwBEOfeF0SwR9u9NscwptKzA=; b=FXYW9cUw\n\t5+Evfxnqs1G+1SPufREB0NSXiEsJHEfedxny8K0HdkvG2JSd9ROYQ+2pixIpC+cC\n\tNGxGUoy9PXrtbuBFlWo1qY+1m3s4p0KZqTBUr73NldJjQZChaVUEGUwmdcMX/rr1\n\tN+TCsOH8aI04OBghtCp34GhRyDlRCnEbD0VIDeaIHhaFqynwzVO25Yzy6/YdskrY\n\tviJDYi7t6UAUrrd5SoolgvVo9iiySii7PraY6rqkOuE38TjbdD6MmU6yYB2j40w8\n\ts2kqNBW4qM+/oPUnQZLY1trrmQTkaMRJahQH1MnPO9+5vClqnepFe0q4FsJwnDdr\n\ttfShmNLdd2oRug==" ], "X-ME-Sender": "<xms:GxC8W29xPw2W8pz5EFU9sKHoRkcMmgTwziR6_2CLxZLsyQ5KMXJr7w>", "X-ME-Proxy": "<xmx:GxC8W5OMms7mjkWgNGQ8Sc7BXOKFrSnRvFtcCR6kDo9sce6496_VqA>\n\t<xmx:GxC8W0G-nA6oASjKcNnJGxahHanW1VXZsxVNQoLK8X83yB6UGOyY5A>\n\t<xmx:GxC8W3x1MJeO5Q4yg09C8SNlWc9e5Nu4ZnyJgXK0Mt2RVXzvMT-8hA>\n\t<xmx:GxC8W1rs6RHfX-V9shl8VljZigJkQ_TLUc7SUV4AxmTsFDDMqEC7Sg>\n\t<xmx:GxC8W9mf2jaiUXXfKmOVk67SqQEVeMmULk8kQFdOOQ1dZa-tf-c7mQ>\n\t<xmx:GxC8WxH__T3sQ5PbS_xSwZ7x5nfY9mC7S7j8JGt3VJr9bZRDGZkRfg>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "gaetan.rivet@6wind.com, ophirmu@mellanox.com, ferruh.yigit@intel.com,\n\tarybchenko@solarflare.com, olivier.matz@6wind.com, remy.horton@intel.com", "Date": "Tue, 9 Oct 2018 04:18:57 +0200", "Message-Id": "<20181009021858.19216-4-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.19.0", "In-Reply-To": "<20181009021858.19216-1-thomas@monjalon.net>", "References": "<20181009021858.19216-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 3/4] ethdev: move representor parsing functions", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The functions for representor devargs parsing were static\nin the file rte_ethdev.c.\nIn order to reuse them in the file rte_class_eth.c,\nthey are moved to the files ethdev_private.c/.h.\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n lib/librte_ethdev/ethdev_private.c | 82 ++++++++++++++++++++++++++++\n lib/librte_ethdev/ethdev_private.h | 6 +++\n lib/librte_ethdev/rte_ethdev.c | 85 ------------------------------\n 3 files changed, 88 insertions(+), 85 deletions(-)", "diff": "diff --git a/lib/librte_ethdev/ethdev_private.c b/lib/librte_ethdev/ethdev_private.c\nindex acc787dba..c34f3ce99 100644\n--- a/lib/librte_ethdev/ethdev_private.c\n+++ b/lib/librte_ethdev/ethdev_private.c\n@@ -3,6 +3,7 @@\n */\n \n #include \"rte_ethdev.h\"\n+#include \"rte_ethdev_driver.h\"\n #include \"ethdev_private.h\"\n \n uint16_t\n@@ -37,3 +38,84 @@ eth_find_device(const struct rte_eth_dev *start, rte_eth_cmp_t cmp,\n \treturn NULL;\n }\n \n+int\n+rte_eth_devargs_parse_list(char *str, rte_eth_devargs_callback_t callback,\n+\tvoid *data)\n+{\n+\tchar *str_start;\n+\tint state;\n+\tint result;\n+\n+\tif (*str != '[')\n+\t\t/* Single element, not a list */\n+\t\treturn callback(str, data);\n+\n+\t/* Sanity check, then strip the brackets */\n+\tstr_start = &str[strlen(str) - 1];\n+\tif (*str_start != ']') {\n+\t\tRTE_LOG(ERR, EAL, \"(%s): List does not end with ']'\", str);\n+\t\treturn -EINVAL;\n+\t}\n+\tstr++;\n+\t*str_start = '\\0';\n+\n+\t/* Process list elements */\n+\tstate = 0;\n+\twhile (1) {\n+\t\tif (state == 0) {\n+\t\t\tif (*str == '\\0')\n+\t\t\t\tbreak;\n+\t\t\tif (*str != ',') {\n+\t\t\t\tstr_start = str;\n+\t\t\t\tstate = 1;\n+\t\t\t}\n+\t\t} else if (state == 1) {\n+\t\t\tif (*str == ',' || *str == '\\0') {\n+\t\t\t\tif (str > str_start) {\n+\t\t\t\t\t/* Non-empty string fragment */\n+\t\t\t\t\t*str = '\\0';\n+\t\t\t\t\tresult = callback(str_start, data);\n+\t\t\t\t\tif (result < 0)\n+\t\t\t\t\t\treturn result;\n+\t\t\t\t}\n+\t\t\t\tstate = 0;\n+\t\t\t}\n+\t\t}\n+\t\tstr++;\n+\t}\n+\treturn 0;\n+}\n+\n+static int\n+rte_eth_devargs_process_range(char *str, uint16_t *list, uint16_t *len_list,\n+\tconst uint16_t max_list)\n+{\n+\tuint16_t lo, hi, val;\n+\tint result;\n+\n+\tresult = sscanf(str, \"%hu-%hu\", &lo, &hi);\n+\tif (result == 1) {\n+\t\tif (*len_list >= max_list)\n+\t\t\treturn -ENOMEM;\n+\t\tlist[(*len_list)++] = lo;\n+\t} else if (result == 2) {\n+\t\tif (lo >= hi || lo > RTE_MAX_ETHPORTS || hi > RTE_MAX_ETHPORTS)\n+\t\t\treturn -EINVAL;\n+\t\tfor (val = lo; val <= hi; val++) {\n+\t\t\tif (*len_list >= max_list)\n+\t\t\t\treturn -ENOMEM;\n+\t\t\tlist[(*len_list)++] = val;\n+\t\t}\n+\t} else\n+\t\treturn -EINVAL;\n+\treturn 0;\n+}\n+\n+int\n+rte_eth_devargs_parse_representor_ports(char *str, void *data)\n+{\n+\tstruct rte_eth_devargs *eth_da = data;\n+\n+\treturn rte_eth_devargs_process_range(str, eth_da->representor_ports,\n+\t\tð_da->nb_representor_ports, RTE_MAX_ETHPORTS);\n+}\ndiff --git a/lib/librte_ethdev/ethdev_private.h b/lib/librte_ethdev/ethdev_private.h\nindex e67cf6831..7b787bf97 100644\n--- a/lib/librte_ethdev/ethdev_private.h\n+++ b/lib/librte_ethdev/ethdev_private.h\n@@ -25,6 +25,12 @@ struct rte_eth_dev *\n eth_find_device(const struct rte_eth_dev *_start, rte_eth_cmp_t cmp,\n \t\tconst void *data);\n \n+/* Parse devargs value for representor parameter. */\n+typedef int (*rte_eth_devargs_callback_t)(char *str, void *data);\n+int rte_eth_devargs_parse_list(char *str, rte_eth_devargs_callback_t callback,\n+\tvoid *data);\n+int rte_eth_devargs_parse_representor_ports(char *str, void *data);\n+\n #ifdef __cplusplus\n }\n #endif\ndiff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c\nindex 9aef0a943..b20082b54 100644\n--- a/lib/librte_ethdev/rte_ethdev.c\n+++ b/lib/librte_ethdev/rte_ethdev.c\n@@ -4304,8 +4304,6 @@ rte_eth_switch_domain_free(uint16_t domain_id)\n \treturn 0;\n }\n \n-typedef int (*rte_eth_devargs_callback_t)(char *str, void *data);\n-\n static int\n rte_eth_devargs_tokenise(struct rte_kvargs *arglist, const char *str_in)\n {\n@@ -4370,89 +4368,6 @@ rte_eth_devargs_tokenise(struct rte_kvargs *arglist, const char *str_in)\n \t}\n }\n \n-static int\n-rte_eth_devargs_parse_list(char *str, rte_eth_devargs_callback_t callback,\n-\tvoid *data)\n-{\n-\tchar *str_start;\n-\tint state;\n-\tint result;\n-\n-\tif (*str != '[')\n-\t\t/* Single element, not a list */\n-\t\treturn callback(str, data);\n-\n-\t/* Sanity check, then strip the brackets */\n-\tstr_start = &str[strlen(str) - 1];\n-\tif (*str_start != ']') {\n-\t\tRTE_LOG(ERR, EAL, \"(%s): List does not end with ']'\", str);\n-\t\treturn -EINVAL;\n-\t}\n-\tstr++;\n-\t*str_start = '\\0';\n-\n-\t/* Process list elements */\n-\tstate = 0;\n-\twhile (1) {\n-\t\tif (state == 0) {\n-\t\t\tif (*str == '\\0')\n-\t\t\t\tbreak;\n-\t\t\tif (*str != ',') {\n-\t\t\t\tstr_start = str;\n-\t\t\t\tstate = 1;\n-\t\t\t}\n-\t\t} else if (state == 1) {\n-\t\t\tif (*str == ',' || *str == '\\0') {\n-\t\t\t\tif (str > str_start) {\n-\t\t\t\t\t/* Non-empty string fragment */\n-\t\t\t\t\t*str = '\\0';\n-\t\t\t\t\tresult = callback(str_start, data);\n-\t\t\t\t\tif (result < 0)\n-\t\t\t\t\t\treturn result;\n-\t\t\t\t}\n-\t\t\t\tstate = 0;\n-\t\t\t}\n-\t\t}\n-\t\tstr++;\n-\t}\n-\treturn 0;\n-}\n-\n-static int\n-rte_eth_devargs_process_range(char *str, uint16_t *list, uint16_t *len_list,\n-\tconst uint16_t max_list)\n-{\n-\tuint16_t lo, hi, val;\n-\tint result;\n-\n-\tresult = sscanf(str, \"%hu-%hu\", &lo, &hi);\n-\tif (result == 1) {\n-\t\tif (*len_list >= max_list)\n-\t\t\treturn -ENOMEM;\n-\t\tlist[(*len_list)++] = lo;\n-\t} else if (result == 2) {\n-\t\tif (lo >= hi || lo > RTE_MAX_ETHPORTS || hi > RTE_MAX_ETHPORTS)\n-\t\t\treturn -EINVAL;\n-\t\tfor (val = lo; val <= hi; val++) {\n-\t\t\tif (*len_list >= max_list)\n-\t\t\t\treturn -ENOMEM;\n-\t\t\tlist[(*len_list)++] = val;\n-\t\t}\n-\t} else\n-\t\treturn -EINVAL;\n-\treturn 0;\n-}\n-\n-\n-static int\n-rte_eth_devargs_parse_representor_ports(char *str, void *data)\n-{\n-\tstruct rte_eth_devargs *eth_da = data;\n-\n-\treturn rte_eth_devargs_process_range(str, eth_da->representor_ports,\n-\t\tð_da->nb_representor_ports, RTE_MAX_ETHPORTS);\n-}\n-\n int __rte_experimental\n rte_eth_devargs_parse(const char *dargs, struct rte_eth_devargs *eth_da)\n {\n", "prefixes": [ "3/4" ] }