Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/46132/?format=api
{ "id": 46132, "url": "http://patches.dpdk.org/api/patches/46132/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1538743527-8285-5-git-send-email-alejandro.lucero@netronome.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1538743527-8285-5-git-send-email-alejandro.lucero@netronome.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1538743527-8285-5-git-send-email-alejandro.lucero@netronome.com", "date": "2018-10-05T12:45:25", "name": "[v3,4/6] bus/pci: use IOVAs dmak mask check when setting IOVA mode", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "89bd8e99d21b57aba805c51267c5e8696f96c085", "submitter": { "id": 270, "url": "http://patches.dpdk.org/api/people/270/?format=api", "name": "Alejandro Lucero", "email": "alejandro.lucero@netronome.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1538743527-8285-5-git-send-email-alejandro.lucero@netronome.com/mbox/", "series": [ { "id": 1717, "url": "http://patches.dpdk.org/api/series/1717/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1717", "date": "2018-10-05T12:45:21", "name": "use IOVAs check based on DMA mask", "version": 3, "mbox": "http://patches.dpdk.org/series/1717/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/46132/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/46132/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 55FD54D3A;\n\tFri, 5 Oct 2018 14:46:59 +0200 (CEST)", "from netronome.com (host-79-78-33-110.static.as9105.net\n\t[79.78.33.110]) by dpdk.org (Postfix) with ESMTP id 86A283195\n\tfor <dev@dpdk.org>; Fri, 5 Oct 2018 14:46:51 +0200 (CEST)", "from netronome.com (localhost [127.0.0.1])\n\tby netronome.com (8.14.4/8.14.4/Debian-4.1ubuntu1) with ESMTP id\n\tw95CjVje008382 for <dev@dpdk.org>; Fri, 5 Oct 2018 13:45:31 +0100", "(from alucero@localhost)\n\tby netronome.com (8.14.4/8.14.4/Submit) id w95CjURF008381\n\tfor dev@dpdk.org; Fri, 5 Oct 2018 13:45:30 +0100" ], "From": "Alejandro Lucero <alejandro.lucero@netronome.com>", "To": "dev@dpdk.org", "Date": "Fri, 5 Oct 2018 13:45:25 +0100", "Message-Id": "<1538743527-8285-5-git-send-email-alejandro.lucero@netronome.com>", "X-Mailer": "git-send-email 1.9.1", "In-Reply-To": "<1538743527-8285-1-git-send-email-alejandro.lucero@netronome.com>", "References": "<1538743527-8285-1-git-send-email-alejandro.lucero@netronome.com>", "Subject": "[dpdk-dev] [PATCH v3 4/6] bus/pci: use IOVAs dmak mask check when\n\tsetting IOVA mode", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Currently the code precludes IOVA mode if IOMMU hardware reports\nless addressing bits than necessary for full virtual memory range.\n\nAlthough VT-d emulation currently only supports 39 bits, it could\nbe iovas for allocated memlory being within that supported range.\nThis patch allows IOVA mode in such a case adding a call to\nrte_eal_check_dma_mask using the reported addressing bits by the\nIOMMU hardware.\n\nIndeed, memory initialization code has been modified for using lower\nvirtual addresses than those used by the kernel for 64 bits processes\nby default, and therefore memsegs iovas can use 39 bits or less for\nmost systems. And this is likely 100% true for VMs.\n\nSigned-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>\nAcked-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n drivers/bus/pci/linux/pci.c | 4 +---\n 1 file changed, 1 insertion(+), 3 deletions(-)", "diff": "diff --git a/drivers/bus/pci/linux/pci.c b/drivers/bus/pci/linux/pci.c\nindex a871549..5cf78d7 100644\n--- a/drivers/bus/pci/linux/pci.c\n+++ b/drivers/bus/pci/linux/pci.c\n@@ -588,10 +588,8 @@\n \tfclose(fp);\n \n \tmgaw = ((vtd_cap_reg & VTD_CAP_MGAW_MASK) >> VTD_CAP_MGAW_SHIFT) + 1;\n-\tif (mgaw < X86_VA_WIDTH)\n-\t\treturn false;\n \n-\treturn true;\n+\treturn rte_eal_check_dma_mask(mgaw) == 0 ? true : false;\n }\n #elif defined(RTE_ARCH_PPC_64)\n static bool\n", "prefixes": [ "v3", "4/6" ] }