Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/46029/?format=api
http://patches.dpdk.org/api/patches/46029/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20181004081403.8039-9-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20181004081403.8039-9-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20181004081403.8039-9-maxime.coquelin@redhat.com", "date": "2018-10-04T08:13:52", "name": "[v3,08/19] vhost: pass socket fd to message handling callbacks", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d99312bcd2b91c91c4689c334d248a643ded76ff", "submitter": { "id": 512, "url": "http://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20181004081403.8039-9-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 1685, "url": "http://patches.dpdk.org/api/series/1685/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1685", "date": "2018-10-04T08:13:44", "name": "vhost: add postcopy live-migration support", "version": 3, "mbox": "http://patches.dpdk.org/series/1685/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/46029/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/46029/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 69F2E1B136;\n\tThu, 4 Oct 2018 10:15:05 +0200 (CEST)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id 5A11C1B123;\n\tThu, 4 Oct 2018 10:15:03 +0200 (CEST)", "from smtp.corp.redhat.com\n\t(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.26])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 98A5B308212A;\n\tThu, 4 Oct 2018 08:15:02 +0000 (UTC)", "from localhost.localdomain (unknown [10.36.112.13])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 7898D3091322;\n\tThu, 4 Oct 2018 08:14:56 +0000 (UTC)" ], "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, tiwei.bie@intel.com, zhihong.wang@intel.com,\n\tjfreimann@redhat.com, nicknickolaev@gmail.com, i.maximets@samsung.com,\n\tbruce.richardson@intel.com, alejandro.lucero@netronome.com", "Cc": "dgilbert@redhat.com, stable@dpdk.org,\n\tMaxime Coquelin <maxime.coquelin@redhat.com>", "Date": "Thu, 4 Oct 2018 10:13:52 +0200", "Message-Id": "<20181004081403.8039-9-maxime.coquelin@redhat.com>", "In-Reply-To": "<20181004081403.8039-1-maxime.coquelin@redhat.com>", "References": "<20181004081403.8039-1-maxime.coquelin@redhat.com>", "X-Scanned-By": "MIMEDefang 2.84 on 10.5.11.26", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.42]); Thu, 04 Oct 2018 08:15:02 +0000 (UTC)", "Subject": "[dpdk-dev] [PATCH v3 08/19] vhost: pass socket fd to message\n\thandling callbacks", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This is not used for now, but will be needed for the\nspecial handling of VHOST_USER_SET_MEM_TABLE message\nonce postcopy will be supported.\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n lib/librte_vhost/vhost_user.c | 71 +++++++++++++++++++++++------------\n 1 file changed, 47 insertions(+), 24 deletions(-)", "diff": "diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c\nindex ad69a267e..c5c4c41b9 100644\n--- a/lib/librte_vhost/vhost_user.c\n+++ b/lib/librte_vhost/vhost_user.c\n@@ -138,14 +138,16 @@ vhost_backend_cleanup(struct virtio_net *dev)\n */\n static int\n vhost_user_set_owner(struct virtio_net **pdev __rte_unused,\n-\t\tstruct VhostUserMsg *msg __rte_unused)\n+\t\t\tstruct VhostUserMsg *msg __rte_unused,\n+\t\t\tint main_fd __rte_unused)\n {\n \treturn VH_RESULT_OK;\n }\n \n static int\n vhost_user_reset_owner(struct virtio_net **pdev,\n-\t\tstruct VhostUserMsg *msg __rte_unused)\n+\t\t\tstruct VhostUserMsg *msg __rte_unused,\n+\t\t\tint main_fd __rte_unused)\n {\n \tstruct virtio_net *dev = *pdev;\n \tvhost_destroy_device_notify(dev);\n@@ -159,7 +161,8 @@ vhost_user_reset_owner(struct virtio_net **pdev,\n * The features that we support are requested.\n */\n static int\n-vhost_user_get_features(struct virtio_net **pdev, struct VhostUserMsg *msg)\n+vhost_user_get_features(struct virtio_net **pdev, struct VhostUserMsg *msg,\n+\t\t\tint main_fd __rte_unused)\n {\n \tstruct virtio_net *dev = *pdev;\n \tuint64_t features = 0;\n@@ -176,7 +179,8 @@ vhost_user_get_features(struct virtio_net **pdev, struct VhostUserMsg *msg)\n * The queue number that we support are requested.\n */\n static int\n-vhost_user_get_queue_num(struct virtio_net **pdev, struct VhostUserMsg *msg)\n+vhost_user_get_queue_num(struct virtio_net **pdev, struct VhostUserMsg *msg,\n+\t\t\tint main_fd __rte_unused)\n {\n \tstruct virtio_net *dev = *pdev;\n \tuint32_t queue_num = 0;\n@@ -193,7 +197,8 @@ vhost_user_get_queue_num(struct virtio_net **pdev, struct VhostUserMsg *msg)\n * We receive the negotiated features supported by us and the virtio device.\n */\n static int\n-vhost_user_set_features(struct virtio_net **pdev, struct VhostUserMsg *msg)\n+vhost_user_set_features(struct virtio_net **pdev, struct VhostUserMsg *msg,\n+\t\t\tint main_fd __rte_unused)\n {\n \tstruct virtio_net *dev = *pdev;\n \tuint64_t features = msg->payload.u64;\n@@ -275,7 +280,8 @@ vhost_user_set_features(struct virtio_net **pdev, struct VhostUserMsg *msg)\n */\n static int\n vhost_user_set_vring_num(struct virtio_net **pdev,\n-\t\t\t struct VhostUserMsg *msg)\n+\t\t\tstruct VhostUserMsg *msg,\n+\t\t\tint main_fd __rte_unused)\n {\n \tstruct virtio_net *dev = *pdev;\n \tstruct vhost_virtqueue *vq = dev->virtqueue[msg->payload.state.index];\n@@ -637,7 +643,8 @@ translate_ring_addresses(struct virtio_net *dev, int vq_index)\n * This function then converts these to our address space.\n */\n static int\n-vhost_user_set_vring_addr(struct virtio_net **pdev, struct VhostUserMsg *msg)\n+vhost_user_set_vring_addr(struct virtio_net **pdev, struct VhostUserMsg *msg,\n+\t\t\tint main_fd __rte_unused)\n {\n \tstruct virtio_net *dev = *pdev;\n \tstruct vhost_virtqueue *vq;\n@@ -674,7 +681,8 @@ vhost_user_set_vring_addr(struct virtio_net **pdev, struct VhostUserMsg *msg)\n */\n static int\n vhost_user_set_vring_base(struct virtio_net **pdev,\n-\t\t\t struct VhostUserMsg *msg)\n+\t\t\tstruct VhostUserMsg *msg,\n+\t\t\tint main_fd __rte_unused)\n {\n \tstruct virtio_net *dev = *pdev;\n \tdev->virtqueue[msg->payload.state.index]->last_used_idx =\n@@ -807,7 +815,8 @@ vhost_memory_changed(struct VhostUserMemory *new,\n }\n \n static int\n-vhost_user_set_mem_table(struct virtio_net **pdev, struct VhostUserMsg *msg)\n+vhost_user_set_mem_table(struct virtio_net **pdev, struct VhostUserMsg *msg,\n+\t\t\tint main_fd __rte_unused)\n {\n \tstruct virtio_net *dev = *pdev;\n \tstruct VhostUserMemory memory = msg->payload.memory;\n@@ -1022,7 +1031,8 @@ virtio_is_ready(struct virtio_net *dev)\n }\n \n static int\n-vhost_user_set_vring_call(struct virtio_net **pdev, struct VhostUserMsg *msg)\n+vhost_user_set_vring_call(struct virtio_net **pdev, struct VhostUserMsg *msg,\n+\t\t\tint main_fd __rte_unused)\n {\n \tstruct virtio_net *dev = *pdev;\n \tstruct vhost_vring_file file;\n@@ -1046,7 +1056,8 @@ vhost_user_set_vring_call(struct virtio_net **pdev, struct VhostUserMsg *msg)\n }\n \n static int vhost_user_set_vring_err(struct virtio_net **pdev __rte_unused,\n-\t\t\tstruct VhostUserMsg *msg)\n+\t\t\tstruct VhostUserMsg *msg,\n+\t\t\tint main_fd __rte_unused)\n {\n \tif (!(msg->payload.u64 & VHOST_USER_VRING_NOFD_MASK))\n \t\tclose(msg->fds[0]);\n@@ -1056,7 +1067,8 @@ static int vhost_user_set_vring_err(struct virtio_net **pdev __rte_unused,\n }\n \n static int\n-vhost_user_set_vring_kick(struct virtio_net **pdev, struct VhostUserMsg *msg)\n+vhost_user_set_vring_kick(struct virtio_net **pdev, struct VhostUserMsg *msg,\n+\t\t\tint main_fd __rte_unused)\n {\n \tstruct virtio_net *dev = *pdev;\n \tstruct vhost_vring_file file;\n@@ -1115,7 +1127,8 @@ free_zmbufs(struct vhost_virtqueue *vq)\n */\n static int\n vhost_user_get_vring_base(struct virtio_net **pdev,\n-\t\t\t struct VhostUserMsg *msg)\n+\t\t\tstruct VhostUserMsg *msg,\n+\t\t\tint main_fd __rte_unused)\n {\n \tstruct virtio_net *dev = *pdev;\n \tstruct vhost_virtqueue *vq = dev->virtqueue[msg->payload.state.index];\n@@ -1171,7 +1184,8 @@ vhost_user_get_vring_base(struct virtio_net **pdev,\n */\n static int\n vhost_user_set_vring_enable(struct virtio_net **pdev,\n-\t\t\t struct VhostUserMsg *msg)\n+\t\t\tstruct VhostUserMsg *msg,\n+\t\t\tint main_fd __rte_unused)\n {\n \tstruct virtio_net *dev = *pdev;\n \tint enable = (int)msg->payload.state.num;\n@@ -1199,7 +1213,8 @@ vhost_user_set_vring_enable(struct virtio_net **pdev,\n \n static int\n vhost_user_get_protocol_features(struct virtio_net **pdev,\n-\t\t\t\t struct VhostUserMsg *msg)\n+\t\t\tstruct VhostUserMsg *msg,\n+\t\t\tint main_fd __rte_unused)\n {\n \tstruct virtio_net *dev = *pdev;\n \tuint64_t features, protocol_features;\n@@ -1224,7 +1239,8 @@ vhost_user_get_protocol_features(struct virtio_net **pdev,\n \n static int\n vhost_user_set_protocol_features(struct virtio_net **pdev,\n-\t\t\t\t struct VhostUserMsg *msg)\n+\t\t\tstruct VhostUserMsg *msg,\n+\t\t\tint main_fd __rte_unused)\n {\n \tstruct virtio_net *dev = *pdev;\n \tuint64_t protocol_features = msg->payload.u64;\n@@ -1241,7 +1257,8 @@ vhost_user_set_protocol_features(struct virtio_net **pdev,\n }\n \n static int\n-vhost_user_set_log_base(struct virtio_net **pdev, struct VhostUserMsg *msg)\n+vhost_user_set_log_base(struct virtio_net **pdev, struct VhostUserMsg *msg,\n+\t\t\tint main_fd __rte_unused)\n {\n \tstruct virtio_net *dev = *pdev;\n \tint fd = msg->fds[0];\n@@ -1307,7 +1324,8 @@ vhost_user_set_log_base(struct virtio_net **pdev, struct VhostUserMsg *msg)\n }\n \n static int vhost_user_set_log_fd(struct virtio_net **pdev __rte_unused,\n-\t\t\tstruct VhostUserMsg *msg)\n+\t\t\tstruct VhostUserMsg *msg,\n+\t\t\tint main_fd __rte_unused)\n {\n \tclose(msg->fds[0]);\n \tRTE_LOG(INFO, VHOST_CONFIG, \"not implemented.\\n\");\n@@ -1324,7 +1342,8 @@ static int vhost_user_set_log_fd(struct virtio_net **pdev __rte_unused,\n * a flag 'broadcast_rarp' to let rte_vhost_dequeue_burst() inject it.\n */\n static int\n-vhost_user_send_rarp(struct virtio_net **pdev, struct VhostUserMsg *msg)\n+vhost_user_send_rarp(struct virtio_net **pdev, struct VhostUserMsg *msg,\n+\t\t\tint main_fd __rte_unused)\n {\n \tstruct virtio_net *dev = *pdev;\n \tuint8_t *mac = (uint8_t *)&msg->payload.u64;\n@@ -1354,7 +1373,8 @@ vhost_user_send_rarp(struct virtio_net **pdev, struct VhostUserMsg *msg)\n }\n \n static int\n-vhost_user_net_set_mtu(struct virtio_net **pdev, struct VhostUserMsg *msg)\n+vhost_user_net_set_mtu(struct virtio_net **pdev, struct VhostUserMsg *msg,\n+\t\t\tint main_fd __rte_unused)\n {\n \tstruct virtio_net *dev = *pdev;\n \tif (msg->payload.u64 < VIRTIO_MIN_MTU ||\n@@ -1371,7 +1391,8 @@ vhost_user_net_set_mtu(struct virtio_net **pdev, struct VhostUserMsg *msg)\n }\n \n static int\n-vhost_user_set_req_fd(struct virtio_net **pdev, struct VhostUserMsg *msg)\n+vhost_user_set_req_fd(struct virtio_net **pdev, struct VhostUserMsg *msg,\n+\t\t\tint main_fd __rte_unused)\n {\n \tstruct virtio_net *dev = *pdev;\n \tint fd = msg->fds[0];\n@@ -1438,7 +1459,8 @@ is_vring_iotlb_invalidate(struct vhost_virtqueue *vq,\n }\n \n static int\n-vhost_user_iotlb_msg(struct virtio_net **pdev, struct VhostUserMsg *msg)\n+vhost_user_iotlb_msg(struct virtio_net **pdev, struct VhostUserMsg *msg,\n+\t\t\tint main_fd __rte_unused)\n {\n \tstruct virtio_net *dev = *pdev;\n \tstruct vhost_iotlb_msg *imsg = &msg->payload.iotlb;\n@@ -1483,7 +1505,8 @@ vhost_user_iotlb_msg(struct virtio_net **pdev, struct VhostUserMsg *msg)\n }\n \n typedef int (*vhost_message_handler_t)(struct virtio_net **pdev,\n-\t\t\t\t\tstruct VhostUserMsg *msg);\n+\t\t\t\t\tstruct VhostUserMsg *msg,\n+\t\t\t\t\tint main_fd);\n static vhost_message_handler_t vhost_message_handlers[VHOST_USER_MAX] = {\n \t[VHOST_USER_NONE] = NULL,\n \t[VHOST_USER_GET_FEATURES] = vhost_user_get_features,\n@@ -1761,7 +1784,7 @@ vhost_user_msg_handler(int vid, int fd)\n \tif (request > VHOST_USER_NONE && request < VHOST_USER_MAX) {\n \t\tif (!vhost_message_handlers[request])\n \t\t\tgoto skip_to_post_handle;\n-\t\tret = vhost_message_handlers[request](&dev, &msg);\n+\t\tret = vhost_message_handlers[request](&dev, &msg, fd);\n \n \t\tswitch (ret) {\n \t\tcase VH_RESULT_ERR:\n", "prefixes": [ "v3", "08/19" ] }{ "id": 46029, "url": "