Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/46022/?format=api
http://patches.dpdk.org/api/patches/46022/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20181004081403.8039-2-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20181004081403.8039-2-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20181004081403.8039-2-maxime.coquelin@redhat.com", "date": "2018-10-04T08:13:45", "name": "[v3,01/19] vhost: fix messages error checks", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c7ee87925ed3fdabea2ce6b23d7131a3744201b3", "submitter": { "id": 512, "url": "http://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20181004081403.8039-2-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 1685, "url": "http://patches.dpdk.org/api/series/1685/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1685", "date": "2018-10-04T08:13:44", "name": "vhost: add postcopy live-migration support", "version": 3, "mbox": "http://patches.dpdk.org/series/1685/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/46022/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/46022/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0D4881B101;\n\tThu, 4 Oct 2018 10:14:23 +0200 (CEST)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id B98011B101;\n\tThu, 4 Oct 2018 10:14:21 +0200 (CEST)", "from smtp.corp.redhat.com\n\t(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.26])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 0C1AF46202;\n\tThu, 4 Oct 2018 08:14:21 +0000 (UTC)", "from localhost.localdomain (unknown [10.36.112.13])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 057773091322;\n\tThu, 4 Oct 2018 08:14:17 +0000 (UTC)" ], "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, tiwei.bie@intel.com, zhihong.wang@intel.com,\n\tjfreimann@redhat.com, nicknickolaev@gmail.com, i.maximets@samsung.com,\n\tbruce.richardson@intel.com, alejandro.lucero@netronome.com", "Cc": "dgilbert@redhat.com, stable@dpdk.org,\n\tMaxime Coquelin <maxime.coquelin@redhat.com>", "Date": "Thu, 4 Oct 2018 10:13:45 +0200", "Message-Id": "<20181004081403.8039-2-maxime.coquelin@redhat.com>", "In-Reply-To": "<20181004081403.8039-1-maxime.coquelin@redhat.com>", "References": "<20181004081403.8039-1-maxime.coquelin@redhat.com>", "X-Scanned-By": "MIMEDefang 2.84 on 10.5.11.26", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]); Thu, 04 Oct 2018 08:14:21 +0000 (UTC)", "Subject": "[dpdk-dev] [PATCH v3 01/19] vhost: fix messages error checks", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Return of message handling has now changed to an enum that can\ntake non-negative value that is not zero in case a reply is\nneeded. But the code checking the variable afterwards has not\nbeen updated, leading to success messages handling being\ntreated as errors.\n\nFixes: 2f270595c05d (\"vhost: rework message handling as a callback array\")\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n lib/librte_vhost/vhost_user.c | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c\nindex 7ef3fb4a4..060b41893 100644\n--- a/lib/librte_vhost/vhost_user.c\n+++ b/lib/librte_vhost/vhost_user.c\n@@ -1783,7 +1783,7 @@ vhost_user_msg_handler(int vid, int fd)\n \t}\n \n skip_to_post_handle:\n-\tif (!ret && dev->extern_ops.post_msg_handle) {\n+\tif (ret != VH_RESULT_ERR && dev->extern_ops.post_msg_handle) {\n \t\tuint32_t need_reply;\n \n \t\tret = (*dev->extern_ops.post_msg_handle)(\n@@ -1800,10 +1800,10 @@ vhost_user_msg_handler(int vid, int fd)\n \t\tvhost_user_unlock_all_queue_pairs(dev);\n \n \tif (msg.flags & VHOST_USER_NEED_REPLY) {\n-\t\tmsg.payload.u64 = !!ret;\n+\t\tmsg.payload.u64 = ret == VH_RESULT_ERR;\n \t\tmsg.size = sizeof(msg.payload.u64);\n \t\tsend_vhost_reply(fd, &msg);\n-\t} else if (ret) {\n+\t} else if (ret == VH_RESULT_ERR) {\n \t\tRTE_LOG(ERR, VHOST_CONFIG,\n \t\t\t\"vhost message handling failed.\\n\");\n \t\treturn -1;\n", "prefixes": [ "v3", "01/19" ] }{ "id": 46022, "url": "