Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/45981/?format=api
{ "id": 45981, "url": "http://patches.dpdk.org/api/patches/45981/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20181003173612.67101-9-kevin.laatz@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20181003173612.67101-9-kevin.laatz@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20181003173612.67101-9-kevin.laatz@intel.com", "date": "2018-10-03T17:36:10", "name": "[v2,08/10] telemetry: add ability to disable selftest", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9c3c498807ecf899340ec4df923ce56fc522bf62", "submitter": { "id": 921, "url": "http://patches.dpdk.org/api/people/921/?format=api", "name": "Kevin Laatz", "email": "kevin.laatz@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20181003173612.67101-9-kevin.laatz@intel.com/mbox/", "series": [ { "id": 1671, "url": "http://patches.dpdk.org/api/series/1671/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1671", "date": "2018-10-03T17:36:03", "name": "introduce telemetry library", "version": 2, "mbox": "http://patches.dpdk.org/series/1671/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/45981/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/45981/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8AC691B217;\n\tWed, 3 Oct 2018 19:36:48 +0200 (CEST)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n\tby dpdk.org (Postfix) with ESMTP id BB85B1B171\n\tfor <dev@dpdk.org>; Wed, 3 Oct 2018 19:36:46 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t03 Oct 2018 10:36:45 -0700", "from silpixa00397517.ir.intel.com (HELO\n\tsilpixa00397517.ger.corp.intel.com) ([10.237.222.54])\n\tby orsmga001.jf.intel.com with ESMTP; 03 Oct 2018 10:36:36 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.54,336,1534834800\"; d=\"scan'208\";a=\"96182500\"", "From": "Kevin Laatz <kevin.laatz@intel.com>", "To": "dev@dpdk.org", "Cc": "harry.van.haaren@intel.com, stephen@networkplumber.org,\n\tgaetan.rivet@6wind.com, shreyansh.jain@nxp.com, thomas@monjalon.net, \n\tCiara Power <ciara.power@intel.com>,\n\tBrian Archbold <brian.archbold@intel.com>,\n\tKevin Laatz <kevin.laatz@intel.com>", "Date": "Wed, 3 Oct 2018 18:36:10 +0100", "Message-Id": "<20181003173612.67101-9-kevin.laatz@intel.com>", "X-Mailer": "git-send-email 2.9.5", "In-Reply-To": "<20181003173612.67101-1-kevin.laatz@intel.com>", "References": "<1535026093-101872-1-git-send-email-ciara.power@intel.com>\n\t<20181003173612.67101-1-kevin.laatz@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 08/10] telemetry: add ability to disable\n\tselftest", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Ciara Power <ciara.power@intel.com>\n\nThis patch adds functionality to enable/disable the selftest.\n\nSigned-off-by: Ciara Power <ciara.power@intel.com>\nSigned-off-by: Brian Archbold <brian.archbold@intel.com>\nSigned-off-by: Kevin Laatz <kevin.laatz@intel.com>\n---\n lib/librte_telemetry/rte_telemetry.c | 23 +++++++++++++----------\n 1 file changed, 13 insertions(+), 10 deletions(-)", "diff": "diff --git a/lib/librte_telemetry/rte_telemetry.c b/lib/librte_telemetry/rte_telemetry.c\nindex 43f7a93..5b87216 100644\n--- a/lib/librte_telemetry/rte_telemetry.c\n+++ b/lib/librte_telemetry/rte_telemetry.c\n@@ -654,6 +654,7 @@ static int32_t\n rte_telemetry_initial_accept(struct telemetry_impl *telemetry)\n {\n \tint pid, ret;\n+\tint selftest = 0;\n \n \tRTE_ETH_FOREACH_DEV(pid) {\n \t\ttelemetry->reg_index = rte_telemetry_reg_ethdev_to_metrics(pid);\n@@ -666,18 +667,20 @@ rte_telemetry_initial_accept(struct telemetry_impl *telemetry)\n \t}\n \n \ttelemetry->metrics_register_done = 1;\n-\tret = rte_telemetry_socket_messaging_testing(telemetry->reg_index,\n-\t\ttelemetry->server_fd);\n-\tif (ret < 0)\n-\t\treturn -1;\n+\tif (selftest) {\n+\t\tret = rte_telemetry_socket_messaging_testing(telemetry->reg_index,\n+\t\t\t\ttelemetry->server_fd);\n+\t\tif (ret < 0)\n+\t\t\treturn -1;\n \n-\tret = rte_telemetry_parser_test(telemetry);\n-\tif (ret < 0) {\n-\t\tTELEMETRY_LOG_ERR(\"Parser Tests Failed\");\n-\t\treturn -1;\n-\t}\n+\t\tret = rte_telemetry_parser_test(telemetry);\n+\t\tif (ret < 0) {\n+\t\t\tTELEMETRY_LOG_ERR(\"Parser Tests Failed\");\n+\t\t\treturn -1;\n+\t\t}\n \n-\tTELEMETRY_LOG_INFO(\"Success - All Parser Tests Passed\");\n+\t\tTELEMETRY_LOG_INFO(\"Success - All Parser Tests Passed\");\n+\t}\n \n \treturn 0;\n }\n", "prefixes": [ "v2", "08/10" ] }