Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 4589,
    "url": "http://patches.dpdk.org/api/patches/4589/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1430406219-23901-27-git-send-email-helin.zhang@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1430406219-23901-27-git-send-email-helin.zhang@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1430406219-23901-27-git-send-email-helin.zhang@intel.com",
    "date": "2015-04-30T15:03:32",
    "name": "[dpdk-dev,v2,26/33] i40e/base: Reassign incorrect PHY type as a workaround for a FW issue",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "8051cfe974f910027e8c90ca8e03e29502be7f76",
    "submitter": {
        "id": 14,
        "url": "http://patches.dpdk.org/api/people/14/?format=api",
        "name": "Zhang, Helin",
        "email": "helin.zhang@intel.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1430406219-23901-27-git-send-email-helin.zhang@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/4589/comments/",
    "check": "pending",
    "checks": "http://patches.dpdk.org/api/patches/4589/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 265C2CD16;\n\tThu, 30 Apr 2015 17:06:02 +0200 (CEST)",
            "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 53492CC34\n\tfor <dev@dpdk.org>; Thu, 30 Apr 2015 17:05:57 +0200 (CEST)",
            "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga101.fm.intel.com with ESMTP; 30 Apr 2015 08:04:46 -0700",
            "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby fmsmga002.fm.intel.com with ESMTP; 30 Apr 2015 08:04:46 -0700",
            "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id t3UF4gRJ029757;\n\tThu, 30 Apr 2015 23:04:42 +0800",
            "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid t3UF4cKC024119; Thu, 30 Apr 2015 23:04:40 +0800",
            "(from hzhan75@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id t3UF4cik024115; \n\tThu, 30 Apr 2015 23:04:38 +0800"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.11,677,1422950400\"; d=\"scan'208\";a=\"718493280\"",
        "From": "Helin Zhang <helin.zhang@intel.com>",
        "To": "dev@dpdk.org",
        "Date": "Thu, 30 Apr 2015 23:03:32 +0800",
        "Message-Id": "<1430406219-23901-27-git-send-email-helin.zhang@intel.com>",
        "X-Mailer": "git-send-email 1.7.4.1",
        "In-Reply-To": "<1430406219-23901-1-git-send-email-helin.zhang@intel.com>",
        "References": "<1429518150-28098-1-git-send-email-helin.zhang@intel.com>\n\t<1430406219-23901-1-git-send-email-helin.zhang@intel.com>",
        "Cc": "monica.kenguva@intel.com, steven.j.murray@intel.com,\n\tshannon.nelson@intel.com",
        "Subject": "[dpdk-dev] [PATCH v2 26/33] i40e/base: Reassign incorrect PHY type\n\tas a workaround for a FW issue",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The FW for SW3E is incorrectly reporting a breakout cable as PHY\ntype 0x3 when it should be 0x16 (I40E_PHY_TYPE_10GBASE_SFPP_CU).\nAs this is supposed to be fixed in the next FW version\n(FW versions >= 4.4), if we get this value back from FW and the\nversion is < 4.4, reassign it to I40E_PHY_TYPE_10GBASE_SFPP_CU.\n\nSigned-off-by: Helin Zhang <helin.zhang@intel.com>\n---\n lib/librte_pmd_i40e/i40e/i40e_common.c | 4 ++++\n 1 file changed, 4 insertions(+)",
    "diff": "diff --git a/lib/librte_pmd_i40e/i40e/i40e_common.c b/lib/librte_pmd_i40e/i40e/i40e_common.c\nindex e728e8e..d6cfde8 100644\n--- a/lib/librte_pmd_i40e/i40e/i40e_common.c\n+++ b/lib/librte_pmd_i40e/i40e/i40e_common.c\n@@ -1507,6 +1507,10 @@ enum i40e_status_code i40e_aq_get_link_info(struct i40e_hw *hw,\n \telse\n \t\thw_link_info->lse_enable = false;\n \n+\tif ((hw->aq.fw_maj_ver < 4 || (hw->aq.fw_maj_ver == 4 &&\n+\t     hw->aq.fw_min_ver < 40)) && hw_link_info->phy_type == 0xE)\n+\t\thw_link_info->phy_type = I40E_PHY_TYPE_10GBASE_SFPP_CU;\n+\n \t/* save link status information */\n \tif (link)\n \t\ti40e_memcpy(link, hw_link_info, sizeof(struct i40e_link_status),\n",
    "prefixes": [
        "dpdk-dev",
        "v2",
        "26/33"
    ]
}