Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/45874/?format=api
{ "id": 45874, "url": "http://patches.dpdk.org/api/patches/45874/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20181002133026.21527-2-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20181002133026.21527-2-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20181002133026.21527-2-maxime.coquelin@redhat.com", "date": "2018-10-02T13:30:25", "name": "[1/2] vhost: add packed ring support to vring base requests", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "2803bd49d46f61c9bdec0ae39f720e6ab2e0a7c9", "submitter": { "id": 512, "url": "http://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20181002133026.21527-2-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 1642, "url": "http://patches.dpdk.org/api/series/1642/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1642", "date": "2018-10-02T13:30:24", "name": "vhost: packed ring support completion", "version": 1, "mbox": "http://patches.dpdk.org/series/1642/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/45874/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/45874/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 94A2F5B3A;\n\tTue, 2 Oct 2018 15:30:35 +0200 (CEST)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id E57D6569B\n\tfor <dev@dpdk.org>; Tue, 2 Oct 2018 15:30:33 +0200 (CEST)", "from smtp.corp.redhat.com\n\t(int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 1F26F308FB8D;\n\tTue, 2 Oct 2018 13:30:33 +0000 (UTC)", "from localhost.localdomain (ovpn-112-50.ams2.redhat.com\n\t[10.36.112.50])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 60D3A1C92C;\n\tTue, 2 Oct 2018 13:30:31 +0000 (UTC)" ], "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, jfreimann@redhat.com, tiwei.bie@intel.com,\n\tzhihong.wang@intel.com", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Date": "Tue, 2 Oct 2018 15:30:25 +0200", "Message-Id": "<20181002133026.21527-2-maxime.coquelin@redhat.com>", "In-Reply-To": "<20181002133026.21527-1-maxime.coquelin@redhat.com>", "References": "<20181002133026.21527-1-maxime.coquelin@redhat.com>", "X-Scanned-By": "MIMEDefang 2.84 on 10.5.11.23", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.43]); Tue, 02 Oct 2018 13:30:33 +0000 (UTC)", "Subject": "[dpdk-dev] [PATCH 1/2] vhost: add packed ring support to vring base\n\trequests", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "For consistency with Vhost kernel backend, save the wrap\ncounter value into bit 31 of num's vring state field.\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\nReviewed-by: Jens Freimann <jfreimann@redhat.com>\n---\n lib/librte_vhost/vhost_user.c | 17 +++++++++++++----\n 1 file changed, 13 insertions(+), 4 deletions(-)", "diff": "diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c\nindex 7ef3fb4a4..e671ed0ba 100644\n--- a/lib/librte_vhost/vhost_user.c\n+++ b/lib/librte_vhost/vhost_user.c\n@@ -677,10 +677,16 @@ vhost_user_set_vring_base(struct virtio_net **pdev,\n \t\t\t struct VhostUserMsg *msg)\n {\n \tstruct virtio_net *dev = *pdev;\n-\tdev->virtqueue[msg->payload.state.index]->last_used_idx =\n-\t\t\tmsg->payload.state.num;\n-\tdev->virtqueue[msg->payload.state.index]->last_avail_idx =\n-\t\t\tmsg->payload.state.num;\n+\tstruct vhost_virtqueue *vq = dev->virtqueue[msg->payload.state.index];\n+\n+\tif (dev->features & (1ULL << VIRTIO_F_RING_PACKED)) {\n+\t\tvq->avail_wrap_counter = msg->payload.state.num >> 31;\n+\t\tvq->used_wrap_counter = vq->avail_wrap_counter;\n+\t\tmsg->payload.state.num &= ~(1 << 31);\n+\t}\n+\n+\tvq->last_used_idx = msg->payload.state.num;\n+\tvq->last_avail_idx = msg->payload.state.num;\n \n \treturn VH_RESULT_OK;\n }\n@@ -1128,6 +1134,9 @@ vhost_user_get_vring_base(struct virtio_net **pdev,\n \t/* Here we are safe to get the last avail index */\n \tmsg->payload.state.num = vq->last_avail_idx;\n \n+\tif (dev->features & (1ULL << VIRTIO_F_RING_PACKED))\n+\t\tmsg->payload.state.num |= vq->avail_wrap_counter << 31;\n+\n \tRTE_LOG(INFO, VHOST_CONFIG,\n \t\t\"vring base idx:%d file:%d\\n\", msg->payload.state.index,\n \t\tmsg->payload.state.num);\n", "prefixes": [ "1/2" ] }