Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/45849/?format=api
{ "id": 45849, "url": "http://patches.dpdk.org/api/patches/45849/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1538483561-96182-8-git-send-email-jia.guo@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1538483561-96182-8-git-send-email-jia.guo@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1538483561-96182-8-git-send-email-jia.guo@intel.com", "date": "2018-10-02T12:32:41", "name": "[v11,7/7] testpmd: use hot-unplug failure handle mechanism", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1a2e5f461675ad8fa5b63362e46c3a93119ec99e", "submitter": { "id": 507, "url": "http://patches.dpdk.org/api/people/507/?format=api", "name": "Guo, Jia", "email": "jia.guo@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1538483561-96182-8-git-send-email-jia.guo@intel.com/mbox/", "series": [ { "id": 1635, "url": "http://patches.dpdk.org/api/series/1635/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1635", "date": "2018-10-02T12:32:35", "name": "hot-unplug failure handle mechanism", "version": 12, "mbox": "http://patches.dpdk.org/series/1635/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/45849/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/45849/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 91A7D5699;\n\tTue, 2 Oct 2018 14:29:47 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id 29DA04F94\n\tfor <dev@dpdk.org>; Tue, 2 Oct 2018 14:29:43 +0200 (CEST)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t02 Oct 2018 05:29:41 -0700", "from jeffguo-s2600wt2.sh.intel.com (HELO localhost.localdomain)\n\t([10.67.110.10])\n\tby fmsmga005.fm.intel.com with ESMTP; 02 Oct 2018 05:29:20 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.54,331,1534834800\"; d=\"scan'208\";a=\"267734690\"", "From": "Jeff Guo <jia.guo@intel.com>", "To": "stephen@networkplumber.org, bruce.richardson@intel.com,\n\tferruh.yigit@intel.com, konstantin.ananyev@intel.com,\n\tgaetan.rivet@6wind.com, jingjing.wu@intel.com, thomas@monjalon.net,\n\tmotih@mellanox.com, matan@mellanox.com, harry.van.haaren@intel.com,\n\tqi.z.zhang@intel.com, shaopeng.he@intel.com,\n\tbernard.iremonger@intel.com, \n\tarybchenko@solarflare.com, wenzhuo.lu@intel.com,\n\tanatoly.burakov@intel.com, jerin.jacob@caviumnetworks.com", "Cc": "jblunck@infradead.org, shreyansh.jain@nxp.com, dev@dpdk.org,\n\tjia.guo@intel.com, helin.zhang@intel.com", "Date": "Tue, 2 Oct 2018 20:32:41 +0800", "Message-Id": "<1538483561-96182-8-git-send-email-jia.guo@intel.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1538483561-96182-1-git-send-email-jia.guo@intel.com>", "References": "<1498711073-42917-1-git-send-email-jia.guo@intel.com>\n\t<1538483561-96182-1-git-send-email-jia.guo@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v11 7/7] testpmd: use hot-unplug failure handle\n\tmechanism", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch use testpmd for example, to show how an app smoothly handle\nfailure when device be hot-unplug. Except app should enabled the device\nevent monitor and register the hotplug event’s callback, it also need\nenable hotplug handle mechanism before running. Once app detect the\nremoval event, the hot-unplug callback would be called. It will first stop\nthe packet forwarding, then stop the port, close the port, and finally\ndetach the port to clean the device and release the resources.\n\nSigned-off-by: Jeff Guo <jia.guo@intel.com>\n---\nv12->v11:\nno change.\n---\n app/test-pmd/testpmd.c | 39 +++++++++++++++++++++++++++++++--------\n 1 file changed, 31 insertions(+), 8 deletions(-)", "diff": "diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\nindex 001f0e5..bfef483 100644\n--- a/app/test-pmd/testpmd.c\n+++ b/app/test-pmd/testpmd.c\n@@ -2093,14 +2093,22 @@ pmd_test_exit(void)\n \n \tif (hot_plug) {\n \t\tret = rte_dev_event_monitor_stop();\n-\t\tif (ret)\n+\t\tif (ret) {\n \t\t\tRTE_LOG(ERR, EAL,\n \t\t\t\t\"fail to stop device event monitor.\");\n+\t\t\treturn;\n+\t\t}\n \n \t\tret = eth_dev_event_callback_unregister();\n \t\tif (ret)\n+\t\t\treturn;\n+\n+\t\tret = rte_dev_hotplug_handle_disable();\n+\t\tif (ret) {\n \t\t\tRTE_LOG(ERR, EAL,\n-\t\t\t\t\"fail to unregister all event callbacks.\");\n+\t\t\t\t\"fail to disable hotplug handling.\");\n+\t\t\treturn;\n+\t\t}\n \t}\n \n \tprintf(\"\\nBye...\\n\");\n@@ -2244,6 +2252,9 @@ static void\n eth_dev_event_callback(char *device_name, enum rte_dev_event_type type,\n \t\t\t __rte_unused void *arg)\n {\n+\tuint16_t port_id;\n+\tint ret;\n+\n \tif (type >= RTE_DEV_EVENT_MAX) {\n \t\tfprintf(stderr, \"%s called upon invalid event %d\\n\",\n \t\t\t__func__, type);\n@@ -2254,9 +2265,12 @@ eth_dev_event_callback(char *device_name, enum rte_dev_event_type type,\n \tcase RTE_DEV_EVENT_REMOVE:\n \t\tRTE_LOG(ERR, EAL, \"The device: %s has been removed!\\n\",\n \t\t\tdevice_name);\n-\t\t/* TODO: After finish failure handle, begin to stop\n-\t\t * packet forward, stop port, close port, detach port.\n-\t\t */\n+\t\tret = rte_eth_dev_get_port_by_name(device_name, &port_id);\n+\t\tif (ret) {\n+\t\t\tprintf(\"can not get port by device %s!\\n\", device_name);\n+\t\t\treturn;\n+\t\t}\n+\t\trmv_event_callback((void *)(intptr_t)port_id);\n \t\tbreak;\n \tcase RTE_DEV_EVENT_ADD:\n \t\tRTE_LOG(ERR, EAL, \"The device: %s has been added!\\n\",\n@@ -2779,14 +2793,23 @@ main(int argc, char** argv)\n \tinit_config();\n \n \tif (hot_plug) {\n-\t\t/* enable hot plug monitoring */\n+\t\tret = rte_dev_hotplug_handle_enable();\n+\t\tif (ret) {\n+\t\t\tRTE_LOG(ERR, EAL,\n+\t\t\t\t\"fail to enable hotplug handling.\");\n+\t\t\treturn -1;\n+\t\t}\n+\n \t\tret = rte_dev_event_monitor_start();\n \t\tif (ret) {\n-\t\t\trte_errno = EINVAL;\n+\t\t\tRTE_LOG(ERR, EAL,\n+\t\t\t\t\"fail to start device event monitoring.\");\n \t\t\treturn -1;\n \t\t}\n-\t\teth_dev_event_callback_register();\n \n+\t\tret = eth_dev_event_callback_register();\n+\t\tif (ret)\n+\t\t\treturn -1;\n \t}\n \n \tif (start_port(RTE_PORT_ALL) != 0)\n", "prefixes": [ "v11", "7/7" ] }