Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/45834/?format=api
{ "id": 45834, "url": "http://patches.dpdk.org/api/patches/45834/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20181002093651.24795-17-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20181002093651.24795-17-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20181002093651.24795-17-maxime.coquelin@redhat.com", "date": "2018-10-02T09:36:50", "name": "[v2,16/17] vhost: add flag to enable postcopy live-migration", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7b850b3e973fe8691ccda32b2a042901af348a69", "submitter": { "id": 512, "url": "http://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "http://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20181002093651.24795-17-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 1630, "url": "http://patches.dpdk.org/api/series/1630/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=1630", "date": "2018-10-02T09:36:34", "name": "vhost: add postcopy live-migration support", "version": 2, "mbox": "http://patches.dpdk.org/series/1630/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/45834/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/45834/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 315E7548B;\n\tTue, 2 Oct 2018 11:38:47 +0200 (CEST)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id 73D765B34;\n\tTue, 2 Oct 2018 11:38:45 +0200 (CEST)", "from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id C200F30022F3;\n\tTue, 2 Oct 2018 09:38:44 +0000 (UTC)", "from localhost.localdomain (ovpn-112-50.ams2.redhat.com\n\t[10.36.112.50])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 4DEC017119;\n\tTue, 2 Oct 2018 09:38:41 +0000 (UTC)" ], "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, tiwei.bie@intel.com, zhihong.wang@intel.com,\n\tjfreimann@redhat.com, nicknickolaev@gmail.com, i.maximets@samsung.com,\n\tbruce.richardson@intel.com, alejandro.lucero@netronome.com", "Cc": "dgilbert@redhat.com, stable@dpdk.org,\n\tMaxime Coquelin <maxime.coquelin@redhat.com>", "Date": "Tue, 2 Oct 2018 11:36:50 +0200", "Message-Id": "<20181002093651.24795-17-maxime.coquelin@redhat.com>", "In-Reply-To": "<20181002093651.24795-1-maxime.coquelin@redhat.com>", "References": "<20181002093651.24795-1-maxime.coquelin@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.16", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.43]); Tue, 02 Oct 2018 09:38:44 +0000 (UTC)", "Subject": "[dpdk-dev] [PATCH v2 16/17] vhost: add flag to enable postcopy\n\tlive-migration", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Postcopy live-migration feature require the application to\nnot populate the guest memory. As the vhost library cannot\nprevent the application to that (e.g. preventing the\napplication to call mlockall()), the feature is disabled by\ndefault.\n\nThe application should only enable the feature if it does not\nforce the guest memory to be populated.\n\nIn case the user passes the RTE_VHOST_USER_POSTCOPY_SUPPORT\nflag at registration but the feature was not compiled,\nregistration fails.\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n doc/guides/prog_guide/vhost_lib.rst | 8 ++++++++\n lib/librte_vhost/rte_vhost.h | 1 +\n lib/librte_vhost/socket.c | 19 +++++++++++++++++--\n 3 files changed, 26 insertions(+), 2 deletions(-)", "diff": "diff --git a/doc/guides/prog_guide/vhost_lib.rst b/doc/guides/prog_guide/vhost_lib.rst\nindex 77af4d775..c77df338f 100644\n--- a/doc/guides/prog_guide/vhost_lib.rst\n+++ b/doc/guides/prog_guide/vhost_lib.rst\n@@ -106,6 +106,14 @@ The following is an overview of some key Vhost API functions:\n Enabling this flag with these Qemu version results in Qemu being blocked\n when multiple queue pairs are declared.\n \n+ - ``RTE_VHOST_USER_POSTCOPY_SUPPORT``\n+\n+ Postcopy live-migration support will be enabled when this flag is set.\n+ It is disabled by default.\n+\n+ Enabling this flag should only be done when the calling application does\n+ not pre-fault the guest shared memory, otherwise migration would fail.\n+\n * ``rte_vhost_driver_set_features(path, features)``\n \n This function sets the feature bits the vhost-user driver supports. The\ndiff --git a/lib/librte_vhost/rte_vhost.h b/lib/librte_vhost/rte_vhost.h\nindex b3cc6990d..b26afbffa 100644\n--- a/lib/librte_vhost/rte_vhost.h\n+++ b/lib/librte_vhost/rte_vhost.h\n@@ -28,6 +28,7 @@ extern \"C\" {\n #define RTE_VHOST_USER_NO_RECONNECT\t(1ULL << 1)\n #define RTE_VHOST_USER_DEQUEUE_ZERO_COPY\t(1ULL << 2)\n #define RTE_VHOST_USER_IOMMU_SUPPORT\t(1ULL << 3)\n+#define RTE_VHOST_USER_POSTCOPY_SUPPORT\t\t(1ULL << 4)\n \n /** Protocol features. */\n #ifndef VHOST_USER_PROTOCOL_F_MQ\ndiff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c\nindex c04d3d305..3df303be8 100644\n--- a/lib/librte_vhost/socket.c\n+++ b/lib/librte_vhost/socket.c\n@@ -51,6 +51,8 @@ struct vhost_user_socket {\n \tuint64_t supported_features;\n \tuint64_t features;\n \n+\tuint64_t protocol_features;\n+\n \t/*\n \t * Device id to identify a specific backend device.\n \t * It's set to -1 for the default software implementation.\n@@ -731,7 +733,7 @@ rte_vhost_driver_get_protocol_features(const char *path,\n \tdid = vsocket->vdpa_dev_id;\n \tvdpa_dev = rte_vdpa_get_device(did);\n \tif (!vdpa_dev || !vdpa_dev->ops->get_protocol_features) {\n-\t\t*protocol_features = VHOST_USER_PROTOCOL_FEATURES;\n+\t\t*protocol_features = vsocket->protocol_features;\n \t\tgoto unlock_exit;\n \t}\n \n@@ -744,7 +746,7 @@ rte_vhost_driver_get_protocol_features(const char *path,\n \t\tgoto unlock_exit;\n \t}\n \n-\t*protocol_features = VHOST_USER_PROTOCOL_FEATURES\n+\t*protocol_features = vsocket->protocol_features\n \t\t& vdpa_protocol_features;\n \n unlock_exit:\n@@ -863,6 +865,7 @@ rte_vhost_driver_register(const char *path, uint64_t flags)\n \tvsocket->use_builtin_virtio_net = true;\n \tvsocket->supported_features = VIRTIO_NET_SUPPORTED_FEATURES;\n \tvsocket->features = VIRTIO_NET_SUPPORTED_FEATURES;\n+\tvsocket->protocol_features = VHOST_USER_PROTOCOL_FEATURES;\n \n \t/* Dequeue zero copy can't assure descriptors returned in order */\n \tif (vsocket->dequeue_zero_copy) {\n@@ -875,6 +878,18 @@ rte_vhost_driver_register(const char *path, uint64_t flags)\n \t\tvsocket->features &= ~(1ULL << VIRTIO_F_IOMMU_PLATFORM);\n \t}\n \n+\tif (!(flags & RTE_VHOST_USER_POSTCOPY_SUPPORT)) {\n+\t\tvsocket->protocol_features &=\n+\t\t\t~(1ULL << VHOST_USER_PROTOCOL_F_PAGEFAULT);\n+\t} else {\n+#ifndef RTE_LIBRTE_VHOST_POSTCOPY\n+\t\tRTE_LOG(ERR, VHOST_CONFIG,\n+\t\t\t\"Postcopy requested but not compiled\\n\");\n+\t\tret = -1;\n+\t\tgoto out_mutex;\n+#endif\n+\t}\n+\n \tif ((flags & RTE_VHOST_USER_CLIENT) != 0) {\n \t\tvsocket->reconnect = !(flags & RTE_VHOST_USER_NO_RECONNECT);\n \t\tif (vsocket->reconnect && reconn_tid == 0) {\n", "prefixes": [ "v2", "16/17" ] }